[jira] Closed: (OFBIZ-2717) Add a new "Deposit/Withdraw" screen to the FinAccount subscreens

2009-07-15 Thread Rishi Solanki (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rishi Solanki closed OFBIZ-2717. Resolution: Fixed As per description given in my last comment all the desired functionality relate

[jira] Commented: (OFBIZ-2717) Add a new "Deposit/Withdraw" screen to the FinAccount subscreens

2009-07-15 Thread Rishi Solanki (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731810#action_12731810 ] Rishi Solanki commented on OFBIZ-2717: -- User Manual : * Goto - https://localhost

[jira] Assigned: (OFBIZ-2731) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-2731: --- Assignee: Anil K Patel > voidPayment service should reverse the accounting transaction in sam

[jira] Updated: (OFBIZ-2723) OFBiz 09.04 Chinese Localization

2009-07-15 Thread Shi Yusen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2723?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Yusen updated OFBIZ-2723: - Attachment: localization-zh-09.04-applications-manufacturing.patch localization-zh-09.04-a

Re: Verify Pick Process

2009-07-15 Thread Vikas Mayur
On Jul 16, 2009, at 1:08 AM, David E Jones wrote: My question is why payment is captured when the invoice status is In-Process? Shouldn't the system look for Invoice Ready status to capture the payments. If what I said above is true, I could use the existing artifacts and do some changes

Re: Verify Pick Process

2009-07-15 Thread Vikas Mayur
On Jul 15, 2009, at 7:21 PM, Jacopo Cappellato wrote: Coming back to my question a little bit, in the Verify Order step 8, I do not want to capture payment and which is logical because Invoice status is In-Process status. My question is why payment is captured when the invoice status is

Re: opinion about community about cleanup Request*.xml to CustRequest*.xml

2009-07-15 Thread Anil Patel
Hans, Thanks for looking into the issue. This seems to be a good idea to me. It will bring things inline with best practices. Regards Anil Patel On Jul 16, 2009, at 9:13 AM, Hans Bakker wrote: I would like to ask the community about the following change. Currently the screens and forms fil

opinion about community about cleanup Request*.xml to CustRequest*.xml

2009-07-15 Thread Hans Bakker
I would like to ask the community about the following change. Currently the screens and forms files in the system for the Entity CustRequest are called RequestForms.xml and RequestScreens.xml if you work pretty often in this area it still happens pretty frequently that i cannot find them because

[jira] Created: (OFBIZ-2733) search in PROMOTIONS category causes ScreenRenderException

2009-07-15 Thread yt (JIRA)
search in PROMOTIONS category causes ScreenRenderException -- Key: OFBIZ-2733 URL: https://issues.apache.org/jira/browse/OFBIZ-2733 Project: OFBiz Issue Type: Bug Components:

Re: Refactoring OrderPaymentPreference entity

2009-07-15 Thread BJ Freeman
Just make sure the Facetoface(POS) is considered. in that one you want 1) immeadiate response to CC status 2) immeadiate payment of Cash. Jacopo Cappellato sent the following on 7/15/2009 6:46 AM: > Hi all, > > I would like to start talking about possible improvements in the way > Orders are asso

Re: Verify Pick Process

2009-07-15 Thread David E Jones
On Jul 15, 2009, at 4:35 AM, Vikas Mayur wrote: Hi, I have introduced a feature called Verify Pick in Facility component few months back based on a requirement. I was reviewing the code more closely and found some issues. The pre-condition to run this process is that order is in approved

Re: Determining who received the payment

2009-07-15 Thread David E Jones
Bob, Which user is it that you would like to capture, the one who called the quick ship service? Are there other services that the user you want to track will call? Either way I guess you have 2 options: 1. trace down through the service you know the user will call to see if/where the u

Re: Purchase Order Entry

2009-07-15 Thread David E Jones
On Jul 15, 2009, at 8:19 AM, Joe Eckard wrote: Last week I created a patch that allows PO entry without requiring a ProductStore. The main change is that when creating a new ShoppingCart, the productStoreId and currencyUom parameters can be null (currencyUom will be set to the system defau

[jira] Commented: (OFBIZ-2729) special security should be required for setting passwords

2009-07-15 Thread Si Chen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731548#action_12731548 ] Si Chen commented on OFBIZ-2729: Somebody can use a CSR's credentials to try to reset a p

[jira] Closed: (OFBIZ-2732) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Pandit closed OFBIZ-2732. --- Resolution: Duplicate Accidentally created. (same as OFBIZ-2731). I apologized. > voidPayment servi

[jira] Commented: (OFBIZ-2731) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731482#action_12731482 ] Sumit Pandit commented on OFBIZ-2731: - Thanks Arpit for contribution. > voidPayment se

[jira] Updated: (OFBIZ-2731) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2731?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Pandit updated OFBIZ-2731: Attachment: OFBiz_2731.patch Patch is attached for given description. > voidPayment service should

[jira] Created: (OFBIZ-2732) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Sumit Pandit (JIRA)
voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there. -- Key: OFBIZ-2732 U

[jira] Created: (OFBIZ-2731) voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there.

2009-07-15 Thread Sumit Pandit (JIRA)
voidPayment service should reverse the accounting transaction in same state (posted/unposted) as it was origanally there. -- Key: OFBIZ-2731 U

Purchase Order Entry

2009-07-15 Thread Joe Eckard
Last week I created a patch that allows PO entry without requiring a ProductStore. The main change is that when creating a new ShoppingCart, the productStoreId and currencyUom parameters can be null (currencyUom will be set to the system default if null). I would like to commit this soon, d

Re: svn commit: r792402 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml src/org/ofbiz/order/shoppingcart/CheckOutEvents.java src/org/ofbiz/order/shoppingcart/CheckOutHelper.java webapp/

2009-07-15 Thread Joe Eckard
Oh, I see now - I hadn't looked closely at the patch and thought another type of note had been created. Can we call (and label) this new note a "Public Note" or "Public Order Note" instead of a "Shipping Note"? -Joe On Jul 15, 2009, at 2:27 AM, Vikas Mayur wrote: Hi Joe, I am sorry that

Re: Verify Pick Process

2009-07-15 Thread Jacopo Cappellato
Hi Vikas, On Jul 15, 2009, at 12:35 PM, Vikas Mayur wrote: Hi, I have introduced a feature called Verify Pick in Facility component few months back based on a requirement. I was reviewing the code more closely and found some issues. The pre-condition to run this process is that order is

Refactoring OrderPaymentPreference entity

2009-07-15 Thread Jacopo Cappellato
Hi all, I would like to start talking about possible improvements in the way Orders are associated to Payments. Currently the OrderPaymentPreference entity is associated to the PaymentGatewayResponse entity and also the status of the payment is tracked in the OrderPaymentPreference.statusId

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Tim Ruppert
I guess the question remains that either it's a pattern we've employed as a best practice in OFBiz or not. If it is - then Hans do the needful and stop making up your own practices - if not, then Anil let Hans decide on the variable names when he's making commits. My personal vote is that we s

[jira] Updated: (OFBIZ-2730) Junit test for the "depositWithdrawPayments"

2009-07-15 Thread Awdesh Singh Parihar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2730?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awdesh Singh Parihar updated OFBIZ-2730: Attachment: OFBiz-2730.patch -- Imlemented test case to test service depositWithdra

[jira] Created: (OFBIZ-2730) Junit test for the "depositWithdrawPayments"

2009-07-15 Thread Rishi Solanki (JIRA)
Junit test for the "depositWithdrawPayments" Key: OFBIZ-2730 URL: https://issues.apache.org/jira/browse/OFBIZ-2730 Project: OFBiz Issue Type: Sub-task Components: accounting Affects

[jira] Resolved: (OFBIZ-2720) Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.

2009-07-15 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel resolved OFBIZ-2720. - Resolution: Fixed Applied update in r794235. > Add statusId field to the FinAccountTrans entity

[jira] Updated: (OFBIZ-2720) Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.

2009-07-15 Thread Surya Kusumakar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surya Kusumakar updated OFBIZ-2720: --- Attachment: AddedStatusIdToFinAccountTrans.patch Did minor modification in migration service.

Re: Verify Pick Process

2009-07-15 Thread Vikas Mayur
I did some changes for what I described earlier and I think this would be the correct way to generate invoice for shipment. Changes are copied below for reference. Vikas Index: applications/product/src/org/ofbiz/shipment/verify/ VerifyPickSession.java =

Verify Pick Process

2009-07-15 Thread Vikas Mayur
Hi, I have introduced a feature called Verify Pick in Facility component few months back based on a requirement. I was reviewing the code more closely and found some issues. The pre-condition to run this process is that order is in approved status. Steps to do Verify Pick are: 1) Creat

[jira] Commented: (OFBIZ-2717) Add a new "Deposit/Withdraw" screen to the FinAccount subscreens

2009-07-15 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731382#action_12731382 ] Anil K Patel commented on OFBIZ-2717: - Applied patch to r794217. Not closing he issue.

[jira] Assigned: (OFBIZ-2717) Add a new "Deposit/Withdraw" screen to the FinAccount subscreens

2009-07-15 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-2717: --- Assignee: Anil K Patel (was: Ashish Vijaywargiya) > Add a new "Deposit/Withdraw" screen to t

[jira] Reopened: (OFBIZ-2720) Add statusId field to the FinAccountTrans entity and verify that existing functionality is not broken.

2009-07-15 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Pandit reopened OFBIZ-2720: - Reopened issue for a improvement in efficiency. Use tag for iteration. Thanks Vikas for report. >

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Hans Bakker
On Wed, 2009-07-15 at 15:29 +0530, Anil Patel wrote: > Hans, > Sure I will not mind if you change ftl's into form widget as long as > FUNCTIONALITY is not lost. > the same is true when you change the projectInfo variable... -- Antwebsystems.com: Quality OFBiz services for competitive rates

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Anil Patel
Correction inline. On Jul 15, 2009, at 3:29 PM, Anil Patel wrote: Hans, Sure I will not mind if you change ftl's into form widget as long as FUNCTIONALITY is not lost. Rest Inline. Regards Anil Patel On Jul 15, 2009, at 3:15 PM, Hans Bakker wrote: I do not understand your variable hunti

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Anil Patel
Hans, Sure I will not mind if you change ftl's into form widget as long as FUNCTIONALITY is not lost. Rest Inline. Regards Anil Patel On Jul 15, 2009, at 3:15 PM, Hans Bakker wrote: I do not understand your variable hunting. both project and projectinfo are not entities. :-) In cont

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Hans Bakker
I do not understand your variable hunting. both project and projectinfo are not entities. :-) Feel free to change them, i hope then that you do not mind if i change your ftl's into forms Regards, Hans On Wed, 2009-07-15 at 14:36 +0530, Anil Patel wrote: > Hans, > I am interested to kno

Re: svn commit: r794195 - in /ofbiz/trunk/specialpurpose/projectmgr/widget: ProjectScreens.xml forms/ProjectForms.xml

2009-07-15 Thread Anil Patel
Hans, I am interested to know motivation for renaming project variable to projectInfo. Ofbiz best practices (declared or assumed) recommend using entity name for the variable name. Unless there is specific reason I like to use project as variable name instead. Regards Anil Patel On Jul