Re: svn commit: r959868 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/JdbcValueHandler.java

Okay, we can rejoice. I just checked the java.sql.Timestamp source code and the stored strings are referenced to UTC. -Adrian --- On Thu, 7/1/10, Adrian Crum wrote: > From: Adrian Crum > Subject: Re: svn commit: r959868 - > /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/jdbc/JdbcValueHan

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

I'm sure I'll get regret my decision shortly, but in the meantime I'll feel good about doing the right thing. Regards Scott On 2/07/2010, at 7:18 PM, Adrian Crum wrote: > My new mantra: Just say no to copy and paste. > > I'm questioning nearly all of the code I come across. > > -Adrian > >

Re: svn commit: r959894 - /ofbiz/branches/jquery/framework/common/widget/CommonScreens.xml

As a side note, this approach to i18n for the calendar doesn't work very well, the browser reports 404 errors when trying to retrieve localization scripts. Ideally we'd check if the file exists before telling the browser to use it. Regards Scott HotWax Media http://www.hotwaxmedia.com On 2/07

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884606#action_12884606 ] Erwan de FERRIERES commented on OFBIZ-3830: --- Hi Sascha, Thanks for the patch, bu

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884607#action_12884607 ] Sascha Rodekamp commented on OFBIZ-3830: Hi Erwan, nope if a file with a specific

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884610#action_12884610 ] Scott Gray commented on OFBIZ-3830: --- Hi Sascha Direct from my browser after visiting the

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884613#action_12884613 ] Erwan de FERRIERES commented on OFBIZ-3830: --- You beat me on the answer. Yeah Scot

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884612#action_12884612 ] Sascha Rodekamp commented on OFBIZ-3830: Jep Scott that's right, but this is an iss

[jira] Commented: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884615#action_12884615 ] Scott Gray commented on OFBIZ-3830: --- Sounds great, I knew you were working on a branch bu

[jira] Closed: (OFBIZ-3830) jQuery Calendar Implementation

[ https://issues.apache.org/jira/browse/OFBIZ-3830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3830. - Resolution: Fixed So we can close. Thanks all ! > jQuery Calendar Implementation > -

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

Le 02/07/2010 09:18, Adrian Crum a écrit : My new mantra: Just say no to copy and paste. I'm questioning nearly all of the code I come across. -Adrian just run a sonar analysis of the project, there is a copy and paste detector !! Cheers, -- Erwan de FERRIERES www.nereide.biz

Adding agreementId to OrderHeader

When an order is initiated, it is possible to select an agreement that will govern the orders (OrderTerms are cloned from AgreementTerms, if the agreement has a price list then the agreement prices are used in place of ProductPrice); however the agreementId is only added to the cart but it is lo

Re: svn commit: r959673 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

I reverted at r959943, I will use getCategoryMembers service instead (see comment in commit if interested by details) Jacques Scott Gray wrote: On 2/07/2010, at 9:56 AM, BJ Freeman wrote: [ I'm sure it doesn't need to be stated but the trunk is not dumping ground for you to stash incomplete

Re: Adding agreementId to OrderHeader

Quick answer: I can't see any problems with that as they are no ways to retrieve the agreementId from the OrderTerms. Jacques From: "Jacopo Cappellato" When an order is initiated, it is possible to select an agreement that will govern the orders (OrderTerms are cloned from AgreementTerms, if

Re: svn commit: r959673 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

Thanks Anil, I will consider your work, and I even wonder, now that we want to embedd/replace by jQuery, if we should not do it there (I mean in the jQuery branch) For now I have commited a 1st phase at revision: 959951. It already usable without too much work even if all in not completly in

Re: svn commit: r959673 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

Ha... also I wanted to internationalize the service (when they are no products). I will do it for country/states also... Jacques From: "Jacques Le Roux" Thanks Anil, I will consider your work, and I even wonder, now that we want to embedd/replace by jQuery, if we should not do it there (I mea

[jira] Created: (OFBIZ-3845) Multiple lookups target problem

Multiple lookups target problem --- Key: OFBIZ-3845 URL: https://issues.apache.org/jira/browse/OFBIZ-3845 Project: OFBiz Issue Type: Bug Components: ALL COMPONENTS Affects Versions: jQuery

Re: svn commit: r959673 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

Done at r959984 Jacques From: "Jacques Le Roux" Ha... also I wanted to internationalize the service (when they are no products). I will do it for country/states also... Jacques From: "Jacques Le Roux" Thanks Anil, I will consider your work, and I even wonder, now that we want to embedd/re

[jira] Updated: (OFBIZ-3845) Multiple lookups target problem

[ https://issues.apache.org/jira/browse/OFBIZ-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shubham Dubey updated OFBIZ-3845: - Issue Type: Sub-task (was: Bug) Parent: OFBIZ-3814 > Multiple lookups target problem > -

[jira] Commented: (OFBIZ-3845) Multiple lookups target problem

[ https://issues.apache.org/jira/browse/OFBIZ-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884675#action_12884675 ] Shubham Dubey commented on OFBIZ-3845: -- Seems a problem in the jquery code in htmlForm

[jira] Commented: (OFBIZ-3845) Multiple lookups target problem

[ https://issues.apache.org/jira/browse/OFBIZ-3845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12884678#action_12884678 ] Shubham Dubey commented on OFBIZ-3845: -- Sorry a typo, instead of div it's a lookupId

Re: svn commit: r959943 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

jler...@apache.org wrote: > Author: jleroux > Date: Fri Jul 2 10:32:58 2010 > New Revision: 959943 > > URL: http://svn.apache.org/viewvc?rev=959943&view=rev > Log: > Revert r959673 on Scott's advice. There is already a getCategoryMembers. A > bit different but it's ok, as it does not make much s

Re: svn commit: r959943 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

From: "Adam Heath" jler...@apache.org wrote: Author: jleroux Date: Fri Jul 2 10:32:58 2010 New Revision: 959943 URL: http://svn.apache.org/viewvc?rev=959943&view=rev Log: Revert r959673 on Scott's advice. There is already a getCategoryMembers. A bit different but it's ok, as it does not make

Re: Adding agreementId to OrderHeader

I used the model on page 146 and the example agreementID 10002 since the Agreement has the product agreement, the service matches the product agreement productID and updates the orderitem orderterms(page 128) and table 4.9(page 129) . an SECA checks that the order terms can be accepted based on

Re: svn commit: r959943 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

Jacques Le Roux wrote: > From: "Adam Heath" >> jler...@apache.org wrote: >>> Author: jleroux >>> Date: Fri Jul 2 10:32:58 2010 >>> New Revision: 959943 >>> >>> URL: http://svn.apache.org/viewvc?rev=959943&view=rev >>> Log: >>> Revert r959673 on Scott's advice. There is already a >>> getCategoryMe

Re: svn commit: r959943 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

From: "Adam Heath" Jacques Le Roux wrote: From: "Adam Heath" jler...@apache.org wrote: Author: jleroux Date: Fri Jul 2 10:32:58 2010 New Revision: 959943 URL: http://svn.apache.org/viewvc?rev=959943&view=rev Log: Revert r959673 on Scott's advice. There is already a getCategoryMembers. A bi

Re: Adding agreementId to OrderHeader

Interesting, so you enhanced the OOTB model and actions, right? Jacques From: "BJ Freeman" I used the model on page 146 and the example agreementID 10002 since the Agreement has the product agreement, the service matches the product agreement productID and updates the orderitem orderterms(pag

Re: Adding agreementId to OrderHeader

never saw it as enhanced only following the Data model book. since most told me that features were not complete in ofbiz, I completed them. Since most of my discussion were ignored I just made my own, using the OOTB as a basis. I use what I can of the svn and add on top the way I see it. ===

Re: Adding agreementId to OrderHeader

Pretty logical, I see. Maybe Jacopo will consider it? Thanks Jacques From: "BJ Freeman" never saw it as enhanced only following the Data model book. since most told me that features were not complete in ofbiz, I completed them. Since most of my discussion were ignored I just made my own, usi

Re: Adding agreementId to OrderHeader

thanks it would be nice if ofbiz was more based on the Data model book. in my opinion some of the shortcuts have really crippled it. = BJ Freeman http://bjfreeman.elance.com Strategic Power Office with Supplier Automation

Re: [jira] Created: (OFBIZ-3837) r931594 breaks shipping cost calculations

Hi Rohit, you should set the estimation cost first Inside catalog-->store-> ship estimation then value of shipping method automatically changed. But i have another query may be have some solution.if you have some then please reply asap. how can i make destination based shipping charge? Than

Re: svn commit: r959673 - /ofbiz/trunk/framework/common/src/org/ofbiz/common/CommonWorkers.java

short enough :D = BJ Freeman Strategic Power Office with Supplier Automation Specialtymarket.com Systems Integrator-- Glad to Assist Chat

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

How do you know it was copy and paste? It could very well have been different code written by different people and at different times, possibly even with no reference to the other code. Redundant similar code is annoying and nice to eliminate, but it's existence does not imply copy/paste, or e

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: > Because I've done it myself. ;-) Wait, do you mean that in this case you did the actual copying and pasting? Well... I guess that would be one way to know for sure! > I agree that code can look redundant and not be copy and paste. The obvious >

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

On 3/07/2010, at 2:13 PM, Adrian Crum wrote: > --- On Fri, 7/2/10, David E Jones wrote: >> On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: >> >>> Because I've done it myself. ;-) >> >> Wait, do you mean that in this case you did the actual >> copying and pasting? Well... I guess that would be on

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

Scott Gray wrote: > On 3/07/2010, at 2:13 PM, Adrian Crum wrote: > >> --- On Fri, 7/2/10, David E Jones wrote: >>> On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: >>> Because I've done it myself. ;-) >>> Wait, do you mean that in this case you did the actual >>> copying and pasting? Well... I

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

On 3/07/2010, at 3:03 PM, Adam Heath wrote: > Scott Gray wrote: >> On 3/07/2010, at 2:13 PM, Adrian Crum wrote: >> >>> --- On Fri, 7/2/10, David E Jones wrote: On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: > Because I've done it myself. ;-) Wait, do you mean that in this cas

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

--- On Fri, 7/2/10, Scott Gray wrote: From: Scott Gray Subject: Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java To: dev@ofbiz.apache.org Date: Friday, July 2, 2010, 8:36 PM On 3/07/2010, at 3:03 PM, Adam Heath wrote: > Scott Gray wrote: >>

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

Scott Gray wrote: > On 3/07/2010, at 3:03 PM, Adam Heath wrote: > >> Scott Gray wrote: >>> On 3/07/2010, at 2:13 PM, Adrian Crum wrote: >>> --- On Fri, 7/2/10, David E Jones wrote: > On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: > >> Because I've done it myself. ;-) > Wait,

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

The reason ofbiz hasn't seen these bugs that often, is because most DCL uses are done at startup. But that doesn't mean they can't happen at all, and that DCL is ok to use for startup code.

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

Adrian Crum wrote: > --- > In Adam's example, it is entirely possible that > > object = new Result(foo, bar); > > will be executed before > > Object foo = getFoo(); > Object bar = getBar(); > > --- To resta

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

On 3/07/2010, at 3:54 PM, Adam Heath wrote: > Scott Gray wrote: >> On 3/07/2010, at 3:03 PM, Adam Heath wrote: >> >>> Scott Gray wrote: On 3/07/2010, at 2:13 PM, Adrian Crum wrote: > --- On Fri, 7/2/10, David E Jones wrote: >> On Jul 2, 2010, at 7:11 PM, Adrian Crum wrote: >>>

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

--- On Fri, 7/2/10, Scott Gray wrote: > The book would have done well to use a more complicated > example of why DCL shouldn't be used though.  This > article seems to do a better better job of it: > http://www.ibm.com/developerworks/java/library/j-dcl.html That was the article I found a while b

Re: svn commit: r959875 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/ModelWidgetAction.java

Scott Gray wrote: > That's fine, I'll take your word and stand corrected. I actually don't need > a nightstand because I'm able to build one out of the stack of great books > that are still in queue to be read. > The book would have done well to use a more complicated example of why DCL > shoul

Re: Adding agreementId to OrderHeader

yes, I will do. Jacopo On Jul 2, 2010, at 8:01 PM, Jacques Le Roux wrote: > Pretty logical, I see. Maybe Jacopo will consider it? > > Thanks > > Jacques > > From: "BJ Freeman" >> never saw it as enhanced only following the Data model book. >> since most told me that features were not complet