Re: New Icons

2011-04-25 Thread Adrian Crum
Main style sheet: .button-bar ul a.create,.button-bar a.create { padding:6px 10px 6px 10px; } Optional icons style sheet: .button-bar ul a.create,.button-bar a.create { background: url(../images/button_sprite.png) no-repeat 0px 0px; padding:6px 10px 6px 30px; } No changes to markup needed. It

I have selected to the GSoC project: Code/Test separation and add pure webdriver integration for OFBiz

2011-04-25 Thread Ganath Rathnayaka
Hi all, I have selected to the GSoC project Code/Test separation and add pure webdriver integration for OFBiz. Thank you for everything you done for accepting my proposal and I am hoping to work with you and like to have all of your help to get it done successfully. -- thanks Ganath

Re: New Icons

2011-04-25 Thread Nicolas Malin
Your are against me ? My popularity increases :) At this time : Screen definition : Output html render : --- href="javascript:void(0);">Nouvel exemple Style theme definition : -- style.css : .button-bar ul a.create,

Re: Discussion: New TransactionUtil.java Methods

2011-04-25 Thread Bilgin Ibryam
I like it, seems less error prone and I don't see any bad consequences using it. Bilgin On Mon, Apr 25, 2011 at 5:13 PM, Adrian Crum < adrian.c...@sandglass-software.com> wrote: > Setting up transactions properly can be complicated. I've seen cases where > it was done wrong. Even when it's done

Discussion: New TransactionUtil.java Methods

2011-04-25 Thread Adrian Crum
Setting up transactions properly can be complicated. I've seen cases where it was done wrong. Even when it's done right, it adds a lot of client code that gets repeated every time a transaction is used. I have an idea to make transaction handling easier and more reliable: 1. Create an interfac

Re: New Icons

2011-04-25 Thread Jacques Le Roux
Still limited to "all icons or none". I feel that we could do a flexible way (allow icons or not in buttons and menus of choice) also with CSS rules but it would be far less easier than having it controlled by field/entry. Also note we had already image-location attribute for submit button elemen

[jira] [Updated] (OFBIZ-4264) Implement product price history screen

2011-04-25 Thread Amit Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Sharma updated OFBIZ-4264: --- Attachment: OFBIZ-4264.patch Here is the patch for the same. Steps for testing. # Goto https://loc

[jira] [Created] (OFBIZ-4264) Implement product price history screen

2011-04-25 Thread Amit Sharma (JIRA)
Implement product price history screen -- Key: OFBIZ-4264 URL: https://issues.apache.org/jira/browse/OFBIZ-4264 Project: OFBiz Issue Type: Improvement Reporter: Amit Sharma Priority

Re: New Icons

2011-04-25 Thread Adrian Crum
I'm against the idea of widgets controlling styling. Period. I am against Nicolas or any other developer deciding which icons get used and where - that is a decision that should be reserved for theme designers. To summarize my view: 1. Icon display and the choice of icons should be left to the

Re: New Icons

2011-04-25 Thread Jacques Le Roux
On a second thought, we may use another technology than CSS and still have styles, see for instance in POS: posstyles.xml. So yes, styles add flexibility and independence. At 1st glance, Adrian's proposition sounds better from flexibility POV. But, if I have well understood, is still limited to

Re: New Icons

2011-04-25 Thread Adrian Crum
You can control icon display through user preferences without embedding the icons in markup. A user setting can conditionally load a stylesheet that references the icons. I'm not against having new icons in the project. An expanded selection of icons is a great tool for theme designers to use.

Re: New Icons

2011-04-25 Thread Jacques Le Roux
I like the idea +1 1st step committed at r1096457 FYI: related to https://issues.apache.org/jira/browse/OFBIZ-4259 Jacques From: "Nicolas Malin" Adrian I understand your remark but I'm not completely in agreement with that. Icons is at once of the most visual but also a help user. We could as

[jira] [Commented] (OFBIZ-4259) Add famfamfam icons has generic and add possibility to surchage

2011-04-25 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024774#comment-13024774 ] Jacques Le Roux commented on OFBIZ-4259: Thanks Nicolas, Committed in trunk at r1

[jira] [Commented] (OFBIZ-4263) "linkPartyRecord" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Amit Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024764#comment-13024764 ] Amit Sharma commented on OFBIZ-4263: Thanks Ashish! -- Amit > "linkPartyRecord" serv

[jira] [Closed] (OFBIZ-4263) "linkPartyRecord" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-4263. -- Resolution: Fixed Fixed at trunk r1096441 and releasebranch10.04 r1096442. Thanks Amit.

[jira] [Assigned] (OFBIZ-4263) "linkPartyRecord" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-4263: -- Assignee: Ashish Vijaywargiya > "linkPartyRecord" service throwing error "ERROR

[jira] [Updated] (OFBIZ-4259) Add famfamfam icons has generic and add possibility to surchage

2011-04-25 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nicolas Malin updated OFBIZ-4259: - Attachment: remove-img-OFBIZ-4259.patch > Add famfamfam icons has generic and add possibility to

[jira] [Issue Comment Edited] (OFBIZ-4259) Add famfamfam icons has generic and add possibility to surchage

2011-04-25 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024744#comment-13024744 ] Nicolas Malin edited comment on OFBIZ-4259 at 4/25/11 8:43 AM: -

[jira] [Commented] (OFBIZ-4259) Add famfamfam icons has generic and add possibility to surchage

2011-04-25 Thread Nicolas Malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4259?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024744#comment-13024744 ] Nicolas Malin commented on OFBIZ-4259: -- Jacques, First quick step, I remove img on m

Re: New Icons

2011-04-25 Thread Nicolas Malin
Adrian I understand your remark but I'm not completely in agreement with that. Icons is at once of the most visual but also a help user. We could associated directly to a themes but the reality is more complex. If I take the GTK project, every user can define if he wants icons, icons and text

[jira] [Updated] (OFBIZ-4263) "linkPartyRecord" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Amit Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Sharma updated OFBIZ-4263: --- Attachment: OFBIZ-4263.patch Here is the patch for the same. -- Amit > "linkPartyRecord" service th

[jira] [Updated] (OFBIZ-4263) "linkPartyRecord" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Amit Sharma (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Amit Sharma updated OFBIZ-4263: --- Description: When we link party from https://localhost:8443/partymgr/control/linkparty?partyId=1

[jira] [Created] (OFBIZ-4263) "linkParty" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

2011-04-25 Thread Amit Sharma (JIRA)
"linkParty" service throwing error "ERROR: update or delete on table "party_role" violates foreign key constraint "prdstrrle_prle" on table "product_store_role"

Re: Plan for OFBiz stable Release_11.04?

2011-04-25 Thread Ashish Vijaywargiya
Thanks Jacopo! -- Ashish On Mon, Apr 25, 2011 at 12:38 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxmedia.com> wrote: > Ok, I am going to create the branch by the end of April. > > Kind regards, > > Jacopo > > On Apr 13, 2011, at 11:01 AM, Sam Hamilton wrote: > > > +1 > > > > > > On 12 Apr 20

Re: Plan for OFBiz stable Release_11.04?

2011-04-25 Thread Jacopo Cappellato
Ok, I am going to create the branch by the end of April. Kind regards, Jacopo On Apr 13, 2011, at 11:01 AM, Sam Hamilton wrote: > +1 > > > On 12 Apr 2011, at 18:52, Ashish Vijaywargiya wrote: > >> Its mid of April month so I thought to start a thread in which we all can >> discuss about the