[jira] [Assigned] (OFBIZ-4375) TYPO in CategoryTree.groovy, lot's of un-used/un-wanted variables and un-clean really hard to understand code

2011-08-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-4375: -- Assignee: Jacques Le Roux TYPO in CategoryTree.groovy, lot's of un-used/un-wanted

[jira] [Commented] (OFBIZ-4375) TYPO in CategoryTree.groovy, lot's of un-used/un-wanted variables and un-clean really hard to understand code

2011-08-28 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092434#comment-13092434 ] Jacques Le Roux commented on OFBIZ-4375: Hi Atul, Good work, I only reviewed so

[jira] [Updated] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4376: Attachment: CountryAddressFormat.patch new patch, besides key-map error fix, also change the field name

[jira] [Updated] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4376: Attachment: (was: CountryAddressFormat.patch) wrong key-map definition for recently introduced entity

[jira] [Issue Comment Edited] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092474#comment-13092474 ] Leon edited comment on OFBIZ-4376 at 8/28/11 12:39 PM: --- new patch,

Re: svn commit: r1162498 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/marketing/segment/SegmentServices.xml servicedef/services.xml

2011-08-28 Thread Jacques Le Roux
HI Adrian, I don't use them neither, but maybe someone is outside of OFBiz? Why not deprecate them in a 1s time and remove them later if nobody complains? Jacques adri...@apache.org wrote: Author: adrianc Date: Sun Aug 28 11:29:18 2011 New Revision: 1162498 URL:

Re: svn commit: r1162498 - in /ofbiz/trunk/applications/marketing: config/MarketingUiLabels.xml script/org/ofbiz/marketing/segment/SegmentServices.xml servicedef/services.xml

2011-08-28 Thread Adrian Crum
Jacques, Look at the code I removed - it doesn't do anything. They were empty simple methods. -Adrian On 8/28/2011 2:25 PM, Jacques Le Roux wrote: HI Adrian, I don't use them neither, but maybe someone is outside of OFBiz? Why not deprecate them in a 1s time and remove them later if

[jira] [Commented] (OFBIZ-4375) TYPO in CategoryTree.groovy, lot's of un-used/un-wanted variables and un-clean really hard to understand code

2011-08-28 Thread Atul Vani (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092516#comment-13092516 ] Atul Vani commented on OFBIZ-4375: -- 1. // prodCatalogMap should be prodCatalogMap2, it's

[jira] [Commented] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092525#comment-13092525 ] Adrian Crum commented on OFBIZ-4376: Leon, The ant run-install task throws a lot of

[jira] [Commented] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092607#comment-13092607 ] Leon commented on OFBIZ-4376: - humm, interesting. I review the OFBIZ-4270 and noticed that you

[jira] [Updated] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4376: Attachment: (was: CountryAddressFormat.patch) wrong key-map definition for recently introduced entity

[jira] [Updated] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leon updated OFBIZ-4376: Attachment: CountryAddressFormat.patch Just fix anonther bug, the stateProvGeoAssocTypeId of FRA in imported data

[jira] [Commented] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092615#comment-13092615 ] Leon commented on OFBIZ-4376: - hi, Adrian, Should be ok this time. Passed the run-instal test

[jira] [Commented] (OFBIZ-4270) State dropdown only finds states and does not include county information

2011-08-28 Thread Leon (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092616#comment-13092616 ] Leon commented on OFBIZ-4270: - Some info related to this commit, pls see OFBIZ-4376 State

[jira] [Commented] (OFBIZ-4376) wrong key-map definition for recently introduced entity CountryAddressFormat

2011-08-28 Thread Deepak Dixit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13092624#comment-13092624 ] Deepak Dixit commented on OFBIZ-4376: - Hi Adrian, Leon I have already opened ticket