about last years commits for JMS

2012-06-22 Thread Jacopo Cappellato
Jacques, could you please help me to understand all the changes you did around JMS? I see some issues (e.g. the value of ServiceDispatcher.enableJMS is ignored) and reviewing the history of commits I have seen that you have committed changes, then fixed them (partially reverting?) but all in

Re: about last years commits for JMS

2012-06-22 Thread Jacopo Cappellato
The refactoring you did has completely broken the architecture: * JmsListenerFactory is now used as a singleton that is initialized with the dispatcher that created it * when a new dispatcher is created, in the constructor you have: if (enableJMS) { this.jlf =

Re: about last years commits for JMS

2012-06-22 Thread Jacques Le Roux
I will get back to you as soon as I will get a chance. I did not that for my pleasure, I crossed issues and tried to fix them, maybe not the right way indeed... So basically we are now stuck with only one JMS listener, that's your concern, right? In the meantime, this may help

Re: about last years commits for JMS

2012-06-22 Thread Jacopo Cappellato
On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote: https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting issue following https://issues.apache.org/jira/browse/OFBIZ-4296 See also https://issues.apache.org/jira/browse/OFBIZ-4454 annoying... in short, the old JMS

Re: about last years commits for JMS

2012-06-22 Thread Jacques Le Roux
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote: https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting issue following https://issues.apache.org/jira/browse/OFBIZ-4296 See also

Re: about last years commits for JMS

2012-06-22 Thread Jacques Le Roux
I will have a look this weekend... Jacques From: Jacques Le Roux jacques.le.r...@les7arts.com From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote: https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting issue

Controllers redirections do 302

2012-06-22 Thread Jacques Le Roux
Hi, Since all redirect response types (url, cross-redirect, request-redirect, request-redirect-noparam) call HttpServletResponse.sendRedirect() through RequestHandler.callRedirect(), all controllers redirections do 302 redirections.

[jira] [Created] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
Varun Bhansaly created OFBIZ-4943: - Summary: Email configuration - mail.smtp.starttls.enable ignored Key: OFBIZ-4943 URL: https://issues.apache.org/jira/browse/OFBIZ-4943 Project: OFBiz

[jira] [Updated] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Bhansaly updated OFBIZ-4943: -- Attachment: OFBIZ-4943-trunk.patch Email configuration - mail.smtp.starttls.enable

[jira] [Updated] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Bhansaly updated OFBIZ-4943: -- Attachment: OFBIZ-4943-trunk.patch This is applicable to the trunk version.

[jira] [Updated] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Bhansaly updated OFBIZ-4943: -- Attachment: OFBIZ-4943-1004.patch This is applicable to 1004 Email

[jira] [Updated] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Varun Bhansaly updated OFBIZ-4943: -- Attachment: (was: OFBIZ-4943-trunk.patch) Email configuration -

[jira] [Comment Edited] (OFBIZ-4943) Email configuration - mail.smtp.starttls.enable ignored

2012-06-22 Thread Varun Bhansaly (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4943?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13399836#comment-13399836 ] Varun Bhansaly edited comment on OFBIZ-4943 at 6/23/12 4:42 AM: