I'm going to try one more time to ask nicely, and if that doesn't work,
then I'm prepared to veto your commit.
You added redundant methods to the existing code that do nothing more
than duplicate existing functionality. You are not taking the time to
understand how to use the feature
[
https://issues.apache.org/jira/browse/OFBIZ-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-2882.
--
Resolution: Invalid
I close this issue because the fixing patch is now invalid. But I applied
[
https://issues.apache.org/jira/browse/OFBIZ-2882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661341#comment-13661341
]
Adrian Crum commented on OFBIZ-2882:
I agree this issue can be closed. I came to the
From: Adrian Crum adrian.c...@sandglass-software.com
I'm going to try one more time to ask nicely, and if that doesn't work,
then I'm prepared to veto your commit.
You added redundant methods to the existing code that do nothing more
than duplicate existing functionality.
duplicate
Hi,
While working on OFBIZ-5192 I stumbled upon OFBIZ-2882. I closed it as invalid
since the fixing patch no longer makes sense. On the other hand I applied the
test class locally and it passes, which is a good news even if does not cover
(yet?) the OFBIZ-5192 stale cache case. Now I wonder if
I already added cache tests, so it isn't necessary.
It would be helpful to find a way to reproduce OFBIZ-5192 in the entity
tests so we can fix it.
-Adrian
On 5/18/2013 12:17 PM, Jacques Le Roux wrote:
Hi,
While working on OFBIZ-5192 I stumbled upon OFBIZ-2882. I closed it as invalid
No, you do not want a simple average - because it is meaningless. You
don't have to be an expert in statistics to understand why.
Your design averages all requests since server start. A server could run
for weeks, months, years... so your average includes response times from
so long ago that
I'm voting -1 on this commit.
Most of these modifications are not necessary and they break the design
of the metrics feature. The one change is useful - fixing the
measurement for chained requests (RequestHandler.java ). The rest of the
issues mentioned in the commit message do not need to be
OK, Then I let you revert it and implement the measurement for chained requests
Jacques
From: Adrian Crum adrian.c...@sandglass-software.com
I'm voting -1 on this commit.
Most of these modifications are not necessary and they break the design
of the metrics feature. The one change is
[
https://issues.apache.org/jira/browse/OFBIZ-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux updated OFBIZ-5192:
---
Attachment: OFBIZ-5192.patch
I had another look.
The pb is the party profile page uses
I had another look, see https://issues.apache.org/jira/browse/OFBIZ-5192
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
Jacques Le Roux wrote:
From: Adrian Crum adrian.c...@sandglass-software.com
I don't understand what you mean when you say
[
https://issues.apache.org/jira/browse/OFBIZ-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661376#comment-13661376
]
Jacques Le Roux commented on OFBIZ-5192:
I notably don't like that it iterates and
[
https://issues.apache.org/jira/browse/OFBIZ-5192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13661380#comment-13661380
]
Jacques Le Roux commented on OFBIZ-5192:
BTW I just noticed
Okay, I reverted your commit and made some changes to the performance
metrics feature. Those changes should accommodate your requirements.
The discussion will go smoother if you list your requirements, and allow
me to show you how to configure the metrics to do what you want.
-Adrian
On
14 matches
Mail list logo
