Re: [Vote] upgrading OFBiz to JDK 8 on trunk

2015-06-18 Thread Taher Alkhateeb
All tests pass from my side on Debian Linux with JDK 8 U 45 after applying the commits in OFBIZ-6458 and thanks to Adrian we have all other issues ironed out. Taher Alkhateeb On Jun 18, 2015 10:48 PM, "Nicolas Malin" wrote: > Ok for me, move to the height level :) > > Nicolas > > Le 18/06/2015 2

Re: [Vote] upgrading OFBiz to JDK 8 on trunk

2015-06-18 Thread Nicolas Malin
Ok for me, move to the height level :) Nicolas Le 18/06/2015 21:36, Jacques Le Roux a écrit : BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at OFBIZ-6458 and then allow to commit Java 8 specific code

Re: [Vote] upgrading OFBiz to JDK 8 on trunk

2015-06-18 Thread Jacques Le Roux
BTW, as I just wrote at OFBIZ-6458 we could simply use a lazy consensus. So I propose that if nobody is against we commit the last 2 patches at OFBIZ-6458 and then allow to commit Java 8 specific code. Though if we want the trunk demo and build to work we need to make some infra changes before. I

[jira] [Reopened] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-6458: > Upgrade OFBiz to Java JDK 8 > --- > > Key: OFBIZ-6458

[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592357#comment-14592357 ] Jacques Le Roux commented on OFBIZ-6458: Right, Taher but it depends on a vote bef

[jira] [Commented] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms

2015-06-18 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6516?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592187#comment-14592187 ] Adrian Crum commented on OFBIZ-6516: I don't think "buttontext" is a valid CSS class:

[jira] [Commented] (OFBIZ-6398) Print Pick Sheet PDF using orderId.pdf as attachement name.

2015-06-18 Thread Michael Brohl (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14592007#comment-14592007 ] Michael Brohl commented on OFBIZ-6398: -- I'm going to implement Christian's suggestion

[jira] [Commented] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-18 Thread Taher Alkhateeb (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591797#comment-14591797 ] Taher Alkhateeb commented on OFBIZ-6458: Hi Jacques, Patches 3 and 4 which apply

[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination

2015-06-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591770#comment-14591770 ] Jacques Le Roux commented on OFBIZ-5403: In France it's only about tax rates. But

[jira] [Closed] (OFBIZ-6458) Upgrade OFBiz to Java JDK 8

2015-06-18 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6458?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6458. -- Resolution: Done This was finalised by Adrian at r1684216 for StringUtil and r1684217 for the G

Re: [Vote] upgrading OFBiz to JDK 8 on trunk

2015-06-18 Thread Jacques Le Roux
Hi Taher, All, This was a bit premature, but I think now that Adrian has agreed about using LinkedHashMap in StringUtil substitutionPatternMap (with an improvement on thread-safety, also thanks Scoot for confirmation about the origin of the issue) and fixed generics for ECJ (Eclipse compiler for

[jira] [Created] (OFBIZ-6516) Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms

2015-06-18 Thread Gavin Mabie (JIRA)
Gavin Mabie created OFBIZ-6516: -- Summary: Facilitate the use of Icons in Ofbiz by adding descriptive style to the widget-style attribute in forms Key: OFBIZ-6516 URL: https://issues.apache.org/jira/browse/OFBIZ-6516

Re: svn commit: r1686116 - in /ofbiz/trunk: framework/common/widget/ framework/webtools/widget/ framework/widget/dtd/ framework/widget/src/org/ofbiz/widget/artifact/ framework/widget/src/org/ofbiz/wid

2015-06-18 Thread Gavin Mabie
Good job! I wonder though if we are not missing a definitive reference for widgets > like we have > https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference +1 This will an ideal opportunity to standardise some conventions with the view to facili

[jira] [Updated] (OFBIZ-366) Separate VAT from Sales Tax

2015-06-18 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-366: - Labels: accounting tax (was: ) > Separate VAT from Sales Tax > --- > >

[jira] [Updated] (OFBIZ-5584) VAT on Purchase Orders

2015-06-18 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5584: -- Labels: accounting tax (was: ) > VAT on Purchase Orders > -- > >

[jira] [Updated] (OFBIZ-5163) Tax calculated on unit price before adjustments

2015-06-18 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5163?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5163: -- Labels: tax (was: ) > Tax calculated on unit price before adjustments > ---

[jira] [Updated] (OFBIZ-5403) Implement separate glAccounts per TaxAuthority-ProductCategory combination

2015-06-18 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul Foxworthy updated OFBIZ-5403: -- Summary: Implement separate glAccounts per TaxAuthority-ProductCategory combination (was: Imple

[jira] [Commented] (OFBIZ-5403) Implement separate glAccounts per TaxAuthoritiy-ProductCategory combination

2015-06-18 Thread Paul Foxworthy (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-5403?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14591477#comment-14591477 ] Paul Foxworthy commented on OFBIZ-5403: --- I have to agree this is important. In Austr

[jira] [Updated] (OFBIZ-6515) partymgr/control/EditPartyRelationships add odd-row="alternate-row" for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI

2015-06-18 Thread Christian Carlow (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Carlow updated OFBIZ-6515: Attachment: OFBIZ-6515.patch > partymgr/control/EditPartyRelationships add odd-row="alternat

[jira] [Created] (OFBIZ-6515) partymgr/control/EditPartyRelationships add odd-row="alternate-row" for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI

2015-06-18 Thread Christian Carlow (JIRA)
Christian Carlow created OFBIZ-6515: --- Summary: partymgr/control/EditPartyRelationships add odd-row="alternate-row" for ListPartRelationships and remove navigation-form-name for containing screenlet for better UI Key: OFBIZ-6515