[jira] [Commented] (OFBIZ-6795) Bug on SFA vcard import

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098479#comment-15098479 ] Jacques Le Roux commented on OFBIZ-6795: I reviewed your patch (not tested yet) and it looks good

[jira] [Updated] (OFBIZ-6800) Another .fo.ftl file use "align" attribute in "" tag.

2016-01-14 Thread Parinya Wongjina (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Parinya Wongjina updated OFBIZ-6800: Attachment: OFBIZ-6800.patch > Another .fo.ftl file use "align" attribute in "" tag. >

Re: New Service Execution API?

2016-01-14 Thread Nicolas Malin
Hi Scott, I smell good :) Just on the order to prepare the call I think it's more readable to start by the service name : As like this : ServiceResult createProductResult = ServiceWorker.init(dispatcher, "createProduct") .makeValid(context) .add("productName", productName)

Re: New Service Execution API?

2016-01-14 Thread Nicolas Malin
Le 14/01/2016 09:56, Scott Gray a écrit : We could do that but then you lose the ability to reuse the context for subsequent calls. Although I'm not sure it would have much use i.e. calling different services with similar input parameters. Ok I understand your orientation, and I think we use

[jira] [Commented] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jason Reast-Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097857#comment-15097857 ] Jason Reast-Jones commented on OFBIZ-6798: -- Are you not seeing the layered navigation as per the

[jira] [Closed] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6798. -- Resolution: Fixed Fix Version/s: Upcoming Branch 14.12.01 Thanks

[jira] [Commented] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jason Reast-Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097859#comment-15097859 ] Jason Reast-Jones commented on OFBIZ-6798: -- Maybe you need to be in a certain view state too:

Re: New Service Execution API?

2016-01-14 Thread Scott Gray
Yeah exactly Ashish, you can chain as many .add calls as you wish to add however many parameters are needed. The method will also accept a Map for situations where the inputs are coming from elsewhere. We could also add another method to take from an existing map only those parameters that the

[jira] [Comment Edited] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jason Reast-Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097857#comment-15097857 ] Jason Reast-Jones edited comment on OFBIZ-6798 at 1/14/16 9:06 AM: --- Are

[jira] [Comment Edited] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097896#comment-15097896 ] Jacques Le Roux edited comment on OFBIZ-6798 at 1/14/16 9:49 AM: - Yes, I

[jira] [Commented] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.

2016-01-14 Thread Pierre Smits (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097922#comment-15097922 ] Pierre Smits commented on OFBIZ-6689: - I agree that DOM manipulation (as in the example in the

Re: New Service Execution API?

2016-01-14 Thread Scott Gray
We could do that but then you lose the ability to reuse the context for subsequent calls. Although I'm not sure it would have much use i.e. calling different services with similar input parameters. I created a rough version of the ServiceContext today and I must say it was much easier to code

[jira] [Updated] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jason Reast-Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jason Reast-Jones updated OFBIZ-6798: - Attachment: LayeredNavScreenlet.png > Broken filter links if using ecommerce Layered

[jira] [Comment Edited] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jason Reast-Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097857#comment-15097857 ] Jason Reast-Jones edited comment on OFBIZ-6798 at 1/14/16 9:08 AM: --- Are

[jira] [Commented] (OFBIZ-6798) Broken filter links if using ecommerce Layered Navigation

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097896#comment-15097896 ] Jacques Le Roux commented on OFBIZ-6798: Yes, I did the change for seeing the layered navigation

Re: New Service Execution API?

2016-01-14 Thread Jacques Le Roux
I'm all for syntactic sugar :) Jacques Le 14/01/2016 00:07, Scott Gray a écrit : Following a builder pattern a bit like EntityQuery: ServiceResult createProductResult = ServiceContext.create(dispatcher, userLogin) .add("brandName", brandName) .add("productName", productName)

[jira] [Created] (OFBIZ-6801) Delete is not working in Configurations->content

2016-01-14 Thread Pramod Kumar Singh (JIRA)
Pramod Kumar Singh created OFBIZ-6801: - Summary: Delete is not working in Configurations->content Key: OFBIZ-6801 URL: https://issues.apache.org/jira/browse/OFBIZ-6801 Project: OFBiz

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

2016-01-14 Thread Hans Bakker
because this change makes the leadparty a mandatory field. If not filled in, it will not appear in the list screen. Regards, Hans On 15/01/16 03:58, Jacques Le Roux wrote: Le 10/01/2016 20:54, Jacques Le Roux a écrit : Hans, I have created https://issues.apache.org/jira/browse/OFBIZ-6791

[jira] [Updated] (OFBIZ-6795) Bug on SFA vcard import

2016-01-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chula Lathong updated OFBIZ-6795: - Attachment: (was: improtVcard.patch) > Bug on SFA vcard import > --- > >

[jira] [Commented] (OFBIZ-6795) Bug on SFA vcard import

2016-01-14 Thread Chula Lathong (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101100#comment-15101100 ] Chula Lathong commented on OFBIZ-6795: -- Thank you for your review Jacques Le Roux. 1. Why did you

Re: New Service Execution API?

2016-01-14 Thread Ashish Vijaywargiya
Thanks so much Scott!! :-) Kind Regards Ashish Vijaywargiya HotWax Systems - est. 1997 On Thu, Jan 14, 2016 at 2:28 PM, Scott Gray wrote: > Yeah exactly Ashish, you can chain as many .add calls as you wish to add > however many parameters are needed. The method

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

2016-01-14 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6802: --- Description: Currently it is possible to set the current accounting company in the option under

[jira] [Created] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other companent can change it too.

2016-01-14 Thread Hans Bakker (JIRA)
Hans Bakker created OFBIZ-6802: -- Summary: be able to set accounting company in the header, remove from accounting, so other companent can change it too. Key: OFBIZ-6802 URL:

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

2016-01-14 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hans Bakker updated OFBIZ-6802: --- Summary: be able to set accounting company in the header, remove from accounting, so other components

[jira] [Commented] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

2016-01-14 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101374#comment-15101374 ] Jacopo Cappellato commented on OFBIZ-6802: -- I like the idea of having a global session based

Re: New Service Execution API?

2016-01-14 Thread gil portenseigne
+1 It's would be a very nice improvement ! Thanks Scott. Gil On 14/01/2016 13:21, Jacques Le Roux wrote: I'm all for syntactic sugar :) Jacques Le 14/01/2016 00:07, Scott Gray a écrit : Following a builder pattern a bit like EntityQuery: ServiceResult createProductResult =

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

2016-01-14 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-6802: - Affects Version/s: (was: trun) Trunk > be able to set

[jira] [Updated] (OFBIZ-6802) be able to set accounting company in the header, remove from accounting, so other components can change it too.

2016-01-14 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6802?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacopo Cappellato updated OFBIZ-6802: - Fix Version/s: (was: tru) > be able to set accounting company in the header, remove

[jira] [Commented] (OFBIZ-6801) Delete is not working in Configurations->content

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098873#comment-15098873 ] Jacques Le Roux commented on OFBIZ-6801: Sorry to say but this is an incomplete report. Which

[jira] [Closed] (OFBIZ-6792) Exception when sending an order confirmation email

2016-01-14 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6792?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-6792. -- Resolution: Fixed Fix Version/s: Release Branch 15.12 Upcoming Branch

[jira] [Commented] (OFBIZ-6689) Have more flexibility in framework and applications regarding theming frameworks.

2016-01-14 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15098824#comment-15098824 ] Scott Gray commented on OFBIZ-6689: --- Adding pre-processors doesn't really add to the skill set burden

Re: svn commit: r1723248 - in /ofbiz/trunk/applications: marketing/widget/sfa/forms/OpportunityForms.xml order/script/org/ofbiz/order/opportunity/OpportunityServices.xml order/servicedef/secas.xml

2016-01-14 Thread Jacques Le Roux
Le 10/01/2016 20:54, Jacques Le Roux a écrit : Hans, I have created https://issues.apache.org/jira/browse/OFBIZ-6791 Before backporting, I just wonder why you committed this http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/servicedef/secas.xml?r1=1723248=1723247=1723248 Like