Re: Groovy and semicolon at EOL

2016-09-12 Thread Rishi Solanki
I remember the conversion of bsh to groovy was big one, and at that time in a conversation decided to keep the semicolon as is. For code consistency and for java based user of OFBiz. Even bsh/groovy help java based users to develop/understand OFBiz better. I tried but could not find the reference

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Scott Gray
We should probably just have a vote on the contentious points and be done with it. The general consensus doesn't seem to be good enough for Jacques. Regards Scott On 13 September 2016 at 03:41, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > I am rather interested in knowing

Re: svn commit: r1760427 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 8:29 PM, wrote: > Author: jleroux > Date: Mon Sep 12 18:29:38 2016 > New Revision: 1760427 > > URL: http://svn.apache.org/viewvc?rev=1760427=rev > Log: > Completes: Add the "Completes:" to my own personal selfish > tsvn:logtemplatecommit for when

Re: svn commit: r1760435 - in /ofbiz/trunk/applications: accounting/servicedef/services_finaccount.xml product/servicedef/services_facility.xml

2016-09-12 Thread Taher Alkhateeb
Hi Arun, I think perhaps you missed the thread on commit format -> http://markmail.org/message/kyynfcsz44abz4zf to which we have a wiki -> https://cwiki.apache.org/confluence/display/OFBADMIN/OFBiz+commit+message+template So heads up for future commits, or if you'd like to put your feedback.

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Michael Brohl
Thanks for your suggestion, Jacques, I think it makes sense to have something for tasks, in case Implemented, Improved, Fix for or Documentation does not apply. For sake of consistency with the prefixes we already agreed upon, I'd suggest to use "Completed". I will put it in the Wiki.

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 20:10, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 8:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... I another recent message, talking about myself, I said: "Only fools never change their minds" Jacques Ok... so you are not a fool because you have

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 8:06 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... > I another recent message, talking about myself, I said: "Only fools never > change their minds" > > Jacques > > Ok... so you are not a fool because you have changed your mind, right? :-) Jacopo

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 19:52, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 7:34 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: ... Why? Jacques Because it is the standard format that we agreed upon; when I say "we" I am also including you since you wrote (quoted): "I think

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 20:05, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 7:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: And while at it, to put a bit of sense in this thread, what would you put for Tasks? I suggest Completes and not Does (see the "Proposal for a more unified

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 7:57 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > And while at it, to put a bit of sense in this thread, what would you put > for Tasks? I suggest Completes and not Does (see the "Proposal for a more > unified commit message format" thread for the

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
12/09/2016 à 19:35, Jacques Le Roux a écrit : Le 12/09/2016 à 19:34, Jacques Le Roux a écrit : Le 12/09/2016 à 18:54, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 6:47 PM, wrote: Author: jleroux Date: Mon Sep 12 16:47:53 2016 New Revision: 1760406 URL:

Re: Proposal for a more unified commit message format

2016-09-12 Thread Jacques Le Roux
Hi All, We initialled missed something: what would you put for Tasks? I suggest "Completes:" (and not "Does:"). You can use "Completed:" if you want I don't care Jacques Le 06/09/2016 à 10:08, Michael Brohl a écrit : Fellow committers, as you might know, I'm preparing the monthly

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 7:34 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > ... > Why? > > Jacques > Because it is the standard format that we agreed upon; when I say "we" I am also including you since you wrote (quoted): "I think it's a good idea to normalize our commits comments

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 19:34, Jacques Le Roux a écrit : Le 12/09/2016 à 18:54, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 6:47 PM, wrote: Author: jleroux Date: Mon Sep 12 16:47:53 2016 New Revision: 1760406 URL: http://svn.apache.org/viewvc?rev=1760406=rev Log: Fixes:

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 18:54, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 6:47 PM, wrote: Author: jleroux Date: Mon Sep 12 16:47:53 2016 New Revision: 1760406 URL: http://svn.apache.org/viewvc?rev=1760406=rev Log: Fixes: Display of State/Province for non US entities in

Re: Groovy and semicolon at EOL

2016-09-12 Thread Taher Alkhateeb
Agreed, I think it is better to remove semicolons for groovy files. In fact our gradle scripts do not have semicolons. Perhaps people put them there out of habit. On Sep 12, 2016 7:56 PM, "Jacques Le Roux" wrote: > Hi > > While committing r1760406 I wondered if I

Groovy and semicolon at EOL

2016-09-12 Thread Jacques Le Roux
Hi While committing r1760406 I wondered if I should really put semicolons at end of Groovy files lines. We know it's useless in Groovy. Should we continue to put them, and if yes for which reasons? Thanks Jacques

Re: svn commit: r1760406 - in /ofbiz/trunk: framework/common/data/GeoData_JP.xml specialpurpose/ecommerce/groovyScripts/customer/ViewProfile.groovy specialpurpose/ecommerce/template/customer/ViewProfi

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 6:47 PM, wrote: > Author: jleroux > Date: Mon Sep 12 16:47:53 2016 > New Revision: 1760406 > > URL: http://svn.apache.org/viewvc?rev=1760406=rev > Log: > Fixes: Display of State/Province for non US entities in the customer's > profile of ecommerce >

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 17:41, Jacopo Cappellato a écrit : I am rather interested in knowing if other committers share similar concerns or resistance to comply with the template as it is defined in the Wiki at the moment. If this is not the case then I think that Jacques should step back and stop this

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Taher Alkhateeb
We write long emails, we write a lot of code, we write wiki pages, we write documentation, we write comments in Jiras and in fact what we do every day is write. Writing a few parentheses is hardly work especially since more than 90% of the time a commit is related to a single Jira. The effort we

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
I am rather interested in knowing if other committers share similar concerns or resistance to comply with the template as it is defined in the Wiki at the moment. If this is not the case then I think that Jacques should step back and stop this endless thread that is not going anywhere. Jacopo

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 15:51, Jacques Le Roux a écrit : Again, I really don't see the need for the parenthesis. And I'd be happy to change that myself once in wiki and elsewhere it's needed rather than have to type it every time I commit (yes I commit a lot :p) Jacques By elsewhere above I mean I

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Michael, inline... Le 12/09/2016 à 16:36, Michael Brohl a écrit : Am 12.09.16 um 15:51 schrieb Jacques Le Roux: Please do not start to question the blog style/format now, we use it for months, you reviewed it for month and did not raise such a question anytime in the past. Why now? Because,

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Michael Brohl
Jacques, inline. Am 12.09.16 um 15:51 schrieb Jacques Le Roux: the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Sorry, I did not notice this aspect. Do we really

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
I don't see the value of adding parenthesis everywhere. Remember this will stay forever in the project rules, except if someone has the guts to say no. Why would I want parenthesis there? Tell me! Jacques Le 12/09/2016 à 16:15, gil portenseigne a écrit : Hi Jacques, all, From my experience,

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 16:16, gil portenseigne a écrit : And moreover, Fixed over Fixes :) Le 12/09/2016 à 16:15, gil portenseigne a écrit : Fixes: Fix wrong menu name of NewPartyIdentification in screens Sorry I will stick with Fixes, at the moment I commit it's not yet fixed :p Jacques

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread gil portenseigne
And moreover, Fixed over Fixes :) Le 12/09/2016 à 16:15, gil portenseigne a écrit : Fixes: Fix wrong menu name of NewPartyIdentification in screens

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread gil portenseigne
Hi Jacques, all, From my experience, having a commit concerning lots of different JIRA is rare. In this case, don't you thinkthat the list of JIRAcould not be in the detail sectionand written in a more simple way OFBIZ-8118, OFBIZ-8122, OFBIZ-8123, etc. Indeed, in the commit message

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacques Le Roux
Michael, Le 12/09/2016 à 14:30, Michael Brohl a écrit : Jacques, the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Sorry, I did not notice this aspect. Do we really

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Michael Brohl
Jacques, the parenthesis comes from our blog post format where we put the JIRA issue reference just behind the title (you know it because we are working together on this every month). Of course, we can parse without the parenthesis and set them when we generate the development details. But

Re: svn commit: r1760325 - /ofbiz/trunk/applications/party/widget/partymgr/ProfileScreens.xml

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 11:37 AM, wrote: > Author: jleroux > Date: Mon Sep 12 09:37:11 2016 > New Revision: 1760325 > > URL: http://svn.apache.org/viewvc?rev=1760325=rev > Log: > Fixes: a bug introduced with one of > (OFBIZ-8118)(OFBIZ-8122)(OFBIZ-8123)(OFBIZ-8124)(OFBIZ- >

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 10:31, Jacopo Cappellato a écrit : On Mon, Sep 12, 2016 at 10:25 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: You are right, amended. It will take some time to get acquainted... Jacques Oh thanks, but you didn't need to fix, as I said it was just a joke and I

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Mon, Sep 12, 2016 at 10:25 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > > You are right, amended. It will take some time to get acquainted... > > Jacques > Oh thanks, but you didn't need to fix, as I said it was just a joke and I doubt that Michael will want to include this

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacques Le Roux
Le 12/09/2016 à 09:38, Jacopo Cappellato a écrit : On Sun, Sep 11, 2016 at 4:45 PM, wrote: Author: jleroux Date: Sun Sep 11 14:45:32 2016 New Revision: 1760251 URL: http://svn.apache.org/viewvc?rev=1760251=rev Log: No functional change, improves the tsvn:logtemplatecommit

Re: svn commit: r1760251 - /ofbiz/trunk/

2016-09-12 Thread Jacopo Cappellato
On Sun, Sep 11, 2016 at 4:45 PM, wrote: > Author: jleroux > Date: Sun Sep 11 14:45:32 2016 > New Revision: 1760251 > > URL: http://svn.apache.org/viewvc?rev=1760251=rev > Log: > No functional change, improves the tsvn:logtemplatecommit > > Only fools never change their minds: