I remember the conversion of bsh to groovy was big one, and at that time in a conversation decided to keep the semicolon as is. For code consistency and for java based user of OFBiz. Even bsh/groovy help java based users to develop/understand OFBiz better.
I tried but could not find the reference to that conversation in history. But yes we can address this code improvement and here I find something related on OFBiz wiki - https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=6553850 So +1 for this effort and we should remove all semicolons from groovy files. Best Regards, -- Rishi Rishi Solanki Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Mon, Sep 12, 2016 at 10:29 PM, Taher Alkhateeb < slidingfilame...@gmail.com> wrote: > Agreed, I think it is better to remove semicolons for groovy files. In fact > our gradle scripts do not have semicolons. Perhaps people put them there > out of habit. > > On Sep 12, 2016 7:56 PM, "Jacques Le Roux" <jacques.le.r...@les7arts.com> > wrote: > > > Hi > > > > While committing r1760406 I wondered if I should really put semicolons > at > > end of Groovy files lines. > > We know it's useless in Groovy. Should we continue to put them, and if > yes > > for which reasons? > > > > Thanks > > > > Jacques > > > > >
