Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

2017-04-28 Thread Taher Alkhateeb
It's much messier than this Michael, there are two tests that are failing because of these default values. The proper solution I can think of for now is moving all these screens to the order component with all their dependencies. However this would trigger a whole new set of challenges in fixing al

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

2017-04-28 Thread Michael Brohl
Hi Taher, I haven't had a look at the code, normally these screens are configured in the PRODUCT_STORE_EMAIL_SETTING table. I'd suggest to make it configurable through properties or even delete the default. If there are no settings, the corresponding email will simply not be sended. What d

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

2017-04-28 Thread Taher Alkhateeb
After hours of debugging, I discovered the below nasty bit of code inside org.apache.ofbiz.product.store.ProductStoreWorker! Essentially, there are hard-coded dependencies from the product component to ecommerce! OUCH static { defaultProductStoreEmailScreenLocation.put("PRDS_ODR_CONFIR

Re: svn commit: r1792866 [1/3] - in /ofbiz/ofbiz-framework/trunk/applications: accounting/ accounting/data/ marketing/data/ order/ order/data/ party/testdef/data/ product/data/ workeffort/minilang/tes

2017-04-28 Thread Jacques Le Roux
Hi Taher, Thanks for your effort and this explanation. It must be a daunting task! Jacques Le 28/04/2017 à 06:46, Taher Alkhateeb a écrit : Hi Scott, sure I will attempt to explain this as much as I can So my objective here is to accomplish two things: - run all tests successfully on framewo

Re: tutorial for new version

2017-04-28 Thread Jacques Le Roux
Le 28/04/2017 à 08:04, Jacques Le Roux a écrit : I noticed weird characters in Chinese translation when creating an ofbizDemo component. I mean those weird characters existed before pasting in Confluence. This happens only on Windows and does not happen with R15.12 (did not test R16.11, I gu

Re: Using Google Analytics in Confluence

2017-04-28 Thread James Yong
Hi Taher, Ok, I will also put them in wiki. Thank you for the review. Regards, James Yong On 2017-04-28 13:07 (+0800), Taher Alkhateeb wrote: > Hi James, > > First of all, thank you again for taking this initiative and your work on > it. > > What I understood so far is that your objective

Re: iframe tag

2017-04-28 Thread James Yong
Hi Taher, I will try without iframe and see how it goes. Thanks. Regards, James On 2017-04-27 12:52 (+0800), Taher Alkhateeb wrote: > Why iframes? It's rarely useful except maybe in sandboxing (and even then > maybe there are better ways), I would say just a few divs with CSS would > give you