Re: svn commit: r1795781 - in /ofbiz/ofbiz-plugins/trunk: lucene/build.gradle solr/build.gradle

2017-06-29 Thread Michael Brohl
Hi Jacques, why do we need the solr.log.dir in the Lucene plugin? I think the it only belongs in the Solr Plugin. I'll remove it during my work on https://issues.apache.org/jira/browse/OFBIZ-9440 if there are no objections. Regards, Michael Am 22.05.17 um 11:18 schrieb

Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Taher Alkhateeb
Hi Nicolas, Good input and good to have your perspective on this, thank you! I started a thread last year [1] exactly to advocate for being brave and innovative and to shift our somewhat conservative culture. This is something I definitely hold near to my heart and I'm happy to say that I think

Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Nicolas Malin
It's a difficult subject because I'm sure Jacques realized some change with the clear aims to improve the framework with his knowledge. When your knowledge is completed by other commiter's remark you are on the crossway : * revert all your work to try to continue to sharing on the resolution to

[VOTE] [RESULT] Apache OFBiz 16.11.03 - second attempt

2017-06-29 Thread Jacopo Cappellato
The vote is successful thanks to 7 binding and 2 non binding positive (i.e. "+1") votes and no negative votes. I am going to publish the release files. Thank you, Jacopo On Wed, Jun 21, 2017 at 3:41 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > This is the vote thread

Re: Call to action: fixing defects reported by code analysis tools

2017-06-29 Thread Michael Brohl
Hi all, just wanted to bring this back in mind in case there are people interested in helping out with this. Every support is well appreciated, thank you! Regards, Michael Brohl ecomify GmbH www.ecomify.de Am 13.12.16 um 18:35 schrieb Jacopo Cappellato: Hi all, thanks to Gradle we have

Re: [VOTE] [RELEASE] Apache OFBiz 16.11.03 - second attempt

2017-06-29 Thread Jacopo Cappellato
+1 Jacopo On Wed, Jun 21, 2017 at 3:41 PM, Jacopo Cappellato < jacopo.cappell...@hotwaxsystems.com> wrote: > This is the vote thread for the second attempt to release a new bug fix > release for the release16.11 branch. This new release, "Apache OFBiz > 16.11.03" will supersede the recently

Re: Reducing excessive and improperly studied commits

2017-06-29 Thread Jacopo Cappellato
+1 Review Than Commit should be used more often. I also wish that Jacques, from now on, will to be less resistant to requests to revert his commits: the act of reverting a commit is not a shame on the author nor a punishment but instead it is a mechanism that helps to keep the code clean while

Re: buildbot failure in on ofbiz-branch16

2017-06-29 Thread Jacques Le Roux
Works \o/ https://ci.apache.org/projects/ofbiz/logs/framework/ Jacques Le 29/06/2017 à 09:08, Jacques Le Roux a écrit : With INFRA-14464 a directory at https://ci.apache.org/projects/ofbiz/logs/ for the OFBiz framework only tests has been created I have changed the Buildbot config to

Re: buildbot failure in on ofbiz-branch16

2017-06-29 Thread Jacques Le Roux
With INFRA-14464 a directory at https://ci.apache.org/projects/ofbiz/logs/ for the OFBiz framework only tests has been created I have changed the Buildbot config to populate it. I test because I know Builbot is failing to load config changes and don't know if it's fixed or if I need to create

Re: svn commit: r1799736 - /ofbiz/ofbiz-framework/trunk/build.gradle

2017-06-29 Thread Taher Alkhateeb
Hi Scott, I really appreciate your feedback, especially with respect to how other contributors might react. It is important to stress to all contributors and committers that I'm a deep believer in community work and I look forward to learning from and working with all of you. I warmly remember