Rule to deprecated a service

2017-08-04 Thread Nicolas Malin
Hello with the thread https://lists.apache.org/thread.html/Zoz5yfpkrfcxts1 and the voluntary to have a good coherence on crud service name, I would be have your suggest to manage old name and deprecated process. I review the issue OFBIZ-9550 [1] that contains this problematic : -*

Re: svn commit: r1804139 - /ofbiz/site/dtds/widget-form.xsd

2017-08-04 Thread Nicolas Malin
Thanks Jacques, I also forgot this. Nicolas Le 04/08/2017 à 17:55, jler...@apache.org a écrit : Author: jleroux Date: Fri Aug 4 15:55:38 2017 New Revision: 1804139 URL: http://svn.apache.org/viewvc?rev=1804139=rev Log: Monthly update of DTDS Modified: ofbiz/site/dtds/widget-form.xsd

[FYI] Let's encrypt certificate renewal failed

2017-08-04 Thread Jacques Le Roux
Hi, Today I noticed our Let's encrypt certificate renewal failed. So I asked help on Infra Hipchat. It's a known issue and actually easy to fix. For history and possibly future need, here the discussion I had with Chris Thistlethwaite: [4:14 PM] Jacques Le Roux: Hi, we have an issue with

Re: Proper record maintenance in marketing component

2017-08-04 Thread Suraj Khurana
Thanks, Rishi, Deepak. Created a new Jira issue here . -- Best Regards, *Suraj Khurana* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78,

Re: Missing Method Implementations in OrderChangeHelper

2017-08-04 Thread Jacques Le Roux
Hi Kyra, Actually it was an error to remove this comment (thanks Deepak!) at r1758006 https://s.apache.org/neiF. I wonder if other alike comments were not wrongly removed... But anyway I think it's clear those 2 methods (releaseInitialOrderHold and abortOrderProcessing) are no longer needed

Re: Missing Method Implementations in OrderChangeHelper

2017-08-04 Thread Kyra Pritzel-Hentley
Hello Deepak, thank you for this information. I understand now that there used to be an implementation that is now deprecated. Would it not make sense to comment on these methods so that who ever else may stumble upon them knows that nothing is wrong? In the newest trunk, nothing indicates

Re: [Discussion] Failing the build if data loading fails

2017-08-04 Thread Jacques Le Roux
Yes, I meant that for such next endeavours you might commit directly. Especially if you can commit smaller pieces... Anyway it's up to you... Jacques Le 04/08/2017 à 09:35, Taher Alkhateeb a écrit : Starting a JIRA more than a month ago, putting 5 patches and asking for reviews multiple

Re: [Discussion] Failing the build if data loading fails

2017-08-04 Thread Taher Alkhateeb
Starting a JIRA more than a month ago, putting 5 patches and asking for reviews multiple times on the mailing list is not CTR. On Fri, Aug 4, 2017 at 10:21 AM, Jacques Le Roux wrote: > Hi Taher, > > My last reviews of your work (previous commits) let me think that

Re: [Discussion] Failing the build if data loading fails

2017-08-04 Thread Jacques Le Roux
Hi Taher, My last reviews of your work (previous commits) let me think that we can go in a CTR mode :) I'll try to do a review today though... About the "old paramters for --load-data" did you check that they are not indirectly be used by webtools I mean

Re: [Discussion] Failing the build if data loading fails

2017-08-04 Thread Taher Alkhateeb
Hello everyone, So I didn't get feedback for quite a while, probably because the patch is large. However, I think given that this is only a refactoring / cleanup exercise (plus the feature in this thread) I will go ahead and commit this work soon. I've tested it on my machine and things seem to