Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Paul Foxworthy
On 21 November 2017 at 21:48, Suraj Khurana wrote: > > I think in this case, one *FinAccountTrans* record will be created when you > receive a cheque payments from a customer with DEPOSIT purpose which marks > *paymentId* in *FinAccountTrans *entity. > Yes,

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Suraj Khurana
Hi Paul, Please see my comments inline. On Tue, Nov 21, 2017 at 3:30 PM, Paul Foxworthy wrote: > Hi Suraj, > > Yes, that information is valuable, and you should be able to find it. I > still don't think it all belongs in the FinAccountTrans. > > You are right that a credit

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Paul Foxworthy
Hi Suraj, Yes, that information is valuable, and you should be able to find it. I still don't think it all belongs in the FinAccountTrans. You are right that a credit card payment or a store account payment will almost certainly be for one order. But other FinAccountTrans instances will be more

Re: Java Applets

2017-11-21 Thread Taher Alkhateeb
I'm in favor of removing any Java Applets. It was an idea born dead. With that being said, there is very little code in the code base for applets. On a quick grep I only saw these files (one or few lines in each). Probably not used by anyone. - applications/datamodel/data/seed/ContentSeedData.xml

Re: [PROPOSAL] Extend returnId and shipmentId in FinAccountTrans entity

2017-11-21 Thread Suraj Khurana
Hello all, Just adding some thoughts, *FinAccount* is also used for various other types as well such as *STORE_CREDIT_ACCT, CREDIT_CARD_ACCOUNT *etc. and IMO, recording these transactions (orderId, returnId, shipmentId etc.) for such accounts is a valuable information to be stored to track reason