I see, well I suppose perhaps JIRA is also not the best place for
discussing "general" standards and coding practices. The ML is usually
the first platform for these discussions.
I also noted that Michael had concerns with the _value_ of the maximum
width, not whether we should or should not have
Actually we had a good discussion in the related Jira
https://issues.apache.org/jira/browse/OFBIZ-9877
We agreed it's time to rediscuss this again and I agree/and-suggested-there the
dev ML is the best place for that
Jacques
Le 16/12/2017 à 14:27, Taher Alkhateeb a écrit :
I think it is
Le 16/12/2017 à 14:21, Taher Alkhateeb a écrit :
Social network icons are more appropriate in header than footer and the web
template allows it as I can remember.
I'll see that, thanks
I think twitter feeds are a nice feature in the website and it does not
make sense to remove them just
I think it is always better to respect limit width because it has many
implications that affect other developers.
Anyway, I do not think the right place to make arguments is in commit
messages. A commit message is supposed to hold information on what was
done, not a place to argue formatting
Social network icons are more appropriate in header than footer and the web
template allows it as I can remember.
I think twitter feeds are a nice feature in the website and it does not
make sense to remove them just because you're not familiar with how to code
your proposal.
On Dec 16, 2017
I answered to myself at revision: 1818392
Jacques
Le 14/12/2017 à 14:07, Jacques Le Roux a écrit :
Done at revision: 1818125
BTW, I find funny that users have to get to this section after failing with the
"Quick start" section ;)
"C'est la vie" would say some
Jacques
Le 14/12/2017 à
Le 14/12/2017 à 17:28, Jacques Le Roux a écrit :
Le 11/12/2017 à 13:29, Jacques Le Roux a écrit :
Hi,
I wanted to put the social networks icons above "Latest tweets" but it's not as
easy as I thought without breaking the layout.
Could someone with more knowledge with the site have a look
