Re: Demo Trunk Break

2018-03-15 Thread Scott Gray
I guess what Michael is getting at, is that the demo server is for demos, it's not intended for use as a development sandbox. As far as I can tell you don't *need* to be using the demo servers for this, it's just convenient for you. But the problem is, if you're modifying the code on the demos

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
Before Jacopo asked to revert my work on OFBIZ-9833 I continued to work on a replacing solution. This other solution still uses the same (slightly modified) externalServerLoginCheck preprocessor. FYI this solution is still based on AutoUserLogin cookies, and uses now Ajax and CORS, instead of 

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
You're completely right Rajesh, sorry, I jumped the gun without having a proper look in my reply. Your fix looks correct except that we need to move dispatcher/delegator to local variables rather than instance fields. The EventHandler objects are singletons shared among all incoming requests so

Re: tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hi Scott , I could get it to work by setting dispatcher and delegator only. I referred SOAPEventHandler.java which handles tenants fine. I could not see userLogin handling tenantId as suggested by you, can you please see the below and tell if it is correct. Do we have test coverage to see if

Re: tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hey Thanks so much for taking the time and even suggesting a to solution. BTW i saw that the SOAP handler does it well. I would definitely try. regds mallah. On Thu, Mar 15, 2018 at 9:51 PM, Scott Gray wrote: > Hi Rajesh, > > It looks like the XmlRpcEventHandler

Re: Demo Trunk Break

2018-03-15 Thread Michael Brohl
I still do not understand why you had to change the demo instance for your developments. What was this change? Michael Am 15.03.18 um 14:46 schrieb Jacques Le Roux: Because for testing changes for OFBIZ-9833 I had to make a slight change on the trunk demo instance and needed to restart but

Re: tenant handling in XMLRPC

2018-03-15 Thread Scott Gray
Hi Rajesh, It looks like the XmlRpcEventHandler class doesn't support this but it could easily be modified to do so. I'd suggest filing a ticket, and perhaps even providing a patch :-) The tenantId just needs to be derived from the url and then passed into the userLogin service in the

Re: svn commit: r1824889 - /ofbiz/branches/release16.11/framework/webapp/src/main/java/org/apache/ofbi z/webapp/control/LoginWorker.java

2018-03-15 Thread Jacques Le Roux
Michael, Taher, This was not refactored in R16, I just made as it was before my commit previous commit I don't remember well but I think I got a conflict that's why I put it back as it was. You can check by yourself in svn history, there were no changes but mine in LoginWorker.java since

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
It's seems related to the VM config. I mean having trunk, stable on the same machine. So if you want to do that you need to reproduce the config on a machine following the relevant parts in tools\demo-backup At least having a trunk and stable instance running on the same machine As it's

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
Can we test with java -jar build/lib/ofbiz.jar --shutdown? If it is stable with raw java, then we know it is a gradle setup issue. If not, then we investigate the shutdown code in the start component. On Mar 15, 2018 4:59 PM, "Jacques Le Roux" wrote: > In the case

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
In the case I faced this morning it hanged at 91%  I did not check more. This happens sometimes, not often, I'd say 15%  of the time, I don't see any reason Jacques Le 15/03/2018 à 14:52, Taher Alkhateeb a écrit : Can you be specific about "does not always behave well"? Maybe we can debug

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
Can you be specific about "does not always behave well"? Maybe we can debug and fix the situation. What happens? Does it not shut down at all? Does it hang? What happens exactly? On Thu, Mar 15, 2018 at 4:46 PM, Jacques Le Roux wrote: > Because for testing changes

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
Because for testing changes for OFBIZ-9833 I had to make a slight change on the trunk demo instance and needed to restart but ./gradlew --no-daemon "ofbiz --shutdown" Does not always behaves well, at least on demos VM where there is 3 instances So you get unstable situation and have to use

Re: Demo Trunk Break

2018-03-15 Thread Michael Brohl
Of course it should read: "I try to understand why trunk demo was broken while the trunk codebase seems to have no issues." Michael Am 15.03.18 um 13:51 schrieb Michael Brohl: To be more clear: I try to understand why trunk demo was broken while the trunk demo seems to have no issues.

Re: Demo Trunk Break

2018-03-15 Thread Michael Brohl
To be more clear: I try to understand why trunk demo was broken while the trunk demo seems to have no issues. Michael Am 15.03.18 um 13:36 schrieb Jacques Le Roux: Ho, it would be convoluted, please wait, WIP... Jacques Le 15/03/2018 à 12:37, Michael Brohl a écrit : Jacques did changes he

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
Ho, it would be convoluted, please wait, WIP... Jacques Le 15/03/2018 à 12:37, Michael Brohl a écrit : Jacques did changes he already reverted in the mantime, see his post this morning. Jacques, can you please explain what happened? Am 15.03.18 um 12:24 schrieb Taher Alkhateeb: Hi Rishi,

Re: Demo Trunk Break

2018-03-15 Thread Michael Brohl
Jacques did changes he already reverted in the mantime, see his post this morning. Jacques, can you please explain what happened? Am 15.03.18 um 12:24 schrieb Taher Alkhateeb: Hi Rishi, I'm not getting any errors in the demo on my side? Could it be a web browser cache thing? I always fall in

Re: Demo Trunk Break

2018-03-15 Thread Taher Alkhateeb
Hi Rishi, I'm not getting any errors in the demo on my side? Could it be a web browser cache thing? I always fall in that trap myself. On Thu, Mar 15, 2018 at 10:59 AM, Rishi Solanki wrote: > It seems something specific with deployment/data at demo instance, locally > It

tenant handling in XMLRPC

2018-03-15 Thread Rajesh Mallah
Hello All , Is it possible to direct the webservice call to a particular tenant using XMLRPC? I am referring to https://cwiki.apache.org/confluence/display/OFBIZ/Using+XMLRPC+as+an+alternative+to+SOAP consider the snippet ===

Re: Demo Trunk Break

2018-03-15 Thread Michael Brohl
Did you use the official demo trunk to test individual changes? Am 15.03.18 um 09:24 schrieb Jacques Le Roux: Hi Rishi, It was me currently "playing" with the trunk demo. I just restarted it and it's OK Sorry for the disturbance, I have no other ways to test one thing Jacques Le

Re: Demo Trunk Break

2018-03-15 Thread Rishi Solanki
Jacques, No worries, thanks for the information. Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Mar 15, 2018 at 1:54 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi

Re: Demo Trunk Break

2018-03-15 Thread Jacques Le Roux
Hi Rishi, It was me currently "playing" with the trunk demo. I just restarted it and it's OK Sorry for the disturbance, I have no other ways to test one thing Jacques Le 15/03/2018 à 08:59, Rishi Solanki a écrit : It seems something specific with deployment/data at demo instance, locally

Re: Demo Trunk Break

2018-03-15 Thread Rishi Solanki
It seems something specific with deployment/data at demo instance, locally It is working. No issue with latest trunk fresh data. Best, Rishi Solanki Sr Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com www.hotwax.co On Thu, Mar

Demo Trunk Break

2018-03-15 Thread Rishi Solanki
Devs, On browsing - https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Party Received following exception, Any one facing the similar issue with demo please share. I'm looking into it and get back if find the root cause for the same. Thanks! Here is the error received