Re: Confusing entity names

2018-04-13 Thread Jacques Le Roux
Hi Suraj, Did you get a chance to check if these entities are covered by tests somehow? Thanks Jacques Le 13/04/2018 à 10:09, Suraj Khurana a écrit : Thanks everyone for your thoughts. One more point is we also manage Data Migration By release document so it will help existing uses. Such

Re: Accessibility scope of variables in Java packages and modules

2018-04-13 Thread Taher Alkhateeb
Hello Pradhan, Refactoring is exactly what we need and is a welcomed activity. I think we should, however, try to avoid "big ideas" across the entire code base. The subject of your message is the reason why I say that. So, if you want to start refactoring, I suggest to start with one piece of

Re: Accessibility scope of variables in Java packages and modules

2018-04-13 Thread Jacques Le Roux
Hi, Please avoid ThreadLocal as much as possible For the rest I think a Jira with a patch fits (means sounds OK with me at 1st glance) Jacques Le 13/04/2018 à 11:14, Pradhan Yash Sharma a écrit : Hello, While I was working on UtilCache.java file came across some improvements, they are as

Accessibility scope of variables in Java packages and modules

2018-04-13 Thread Pradhan Yash Sharma
Hello, While I was working on UtilCache.java file came across some improvements, they are as follows: 1) Method and Variable access modifiers can be narrowed down to private access modifier. 2) Then AtomicLong can be given value 0L instead of 0. 3) Some Variables is used in both synchronized

Re: svn commit: r1829040 - in /ofbiz/site: README.md security.html template/page/security.tpl.php

2018-04-13 Thread Deepak Dixit
Thanks Jacques. Thanks & Regards -- Deepak Dixit www.hotwax.co On Fri, Apr 13, 2018 at 2:46 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > oOps, thank you Deepak, fixed > > After a c/p I forgot to put the right link :/ > > BTW I prefer to not use Confluence shortcuts. > I still

Re: svn commit: r1829040 - in /ofbiz/site: README.md security.html template/page/security.tpl.php

2018-04-13 Thread Jacques Le Roux
oOps, thank you Deepak, fixed After a c/p I forgot to put the right link :/ BTW I prefer to not use Confluence shortcuts. I still remember the pain when we moved to ASF Confluence and lost pages and references because of Confluence shortcuts. When you have a plain URL you can at least look for

Re: svn commit: r1829040 - in /ofbiz/site: README.md security.html template/page/security.tpl.php

2018-04-13 Thread Deepak Dixit
Hi Jacques, I Thanks & Regards -- Deepak Dixit www.hotwaxsystems.com www.hotwax.co On Fri, Apr 13, 2018 at 1:38 PM, wrote: > >We strongly encourage OfBiz users to report > security problems affecting OFBiz to the private security mailing lists > (either

Re: Confusing entity names

2018-04-13 Thread Suraj Khurana
Thanks everyone for your thoughts. One more point is we also manage Data Migration By release document so it will help existing uses. Such as https://cwiki.apache.org/confl uence/display/OFBIZ/Data+Migration+by+releases

Re: HTTP based API using REST architectural style

2018-04-13 Thread Paul Foxworthy
Hello Mathieu, This might be of interest too: https://martinfowler.com/articles/richardsonMaturityModel.html Cheers Paul Foxworthy On 13 April 2018 at 17:51, Mathieu Lirzin wrote: > Hello Jacques, > > Jacques Le Roux writes: > > >

Re: Confusing entity names

2018-04-13 Thread Nicolas Malin
Hi On 10/04/2018 13:24, Suraj Khurana wrote: Hello, There are some entities which could be renamed as per their usage. - *OrderItemShipGroup*: It shows order ship groups and it doesn't contain anything at order item level. So, it could be re-named as *OrderShipGroup.* -

Re: HTTP based API using REST architectural style

2018-04-13 Thread Mathieu Lirzin
Hello Jacques, Jacques Le Roux writes: > Le 10/04/2018 à 11:05, Mathieu Lirzin a écrit : >> >> I have recently started a 5 month internship at Néréide >> during which I will work on implementing a >> HTTP based API using REST architectural

Re: Confusing entity names

2018-04-13 Thread gil
Hi All, Got the same feeling as Michael... Thanks, Gil On 12/04/2018 14:48, Michael Brohl wrote: Hi Suraj, thanks for your proposal. Looking at it in isolation, it seems a good idea to just rename these entities. Having the users in mind, I'm not sure if this is worth the need for

Re: HTTP based API using REST architectural style

2018-04-13 Thread Jacques Le Roux
Welcome Mathieu, It's great to see this initiative. For months, if not years, I have a Firefox REST tab groups with 35 tabs I collected. I have not yet completely re-read all the references but I'll and will come back if I have something to add. For now I simply wanted to give you this link

Re: Release notes lost in the new site

2018-04-13 Thread Jacques Le Roux
Hi Deepak, Could we include them somehow to not have to duplicate things? Some time ago[1] I suggested to use https://cwiki.apache.org/confluence/display/OFBIZ/Keeping+OFBiz+secure Jacopo recommended to link to it only. I agree and will do that. I believe this page can be useful for users and