Re: [Discussion]: Add method attribute to request-map (Was: svn commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)

A few comments: 1- I would suggest to try and avoid in the future committing any design changes to the framework without discussing it properly in the mailing list first 2- I think it would be better to revert this work. I noticed in the JIRA for example that Mathieu Lirzin asked for some time to

Re: [Discussion]: Add method attribute to request-map

Hello Taher, Taher Alkhateeb writes: > A few comments: > > 1- I would suggest to try and avoid in the future committing any > design changes to the framework without discussing it properly in the > mailing list first The limit between a “regular” and “design” change can sometimes hard to define

Re: Website Translation in French need contributors

First time contributor. I'll translate. Je sais pas si tu es très sévère avec les fautes de français. Anyways. Give me something to do. On 2018/04/26 16:47:05, Olivier Heintz wrote: > Hi all French contributors and committers and all others ;-)> > > I have create a JIRA to propose a French versi

Re: Website Translation in French need contributors

Hi, Your message has been moderated. Please use and subscribe to the MLs see here http://ofbiz.apache.org/mailing-lists.html Thanks Jacques Le 28/06/2018 à 00:26, Kev2600 a écrit : First time contributor. I'll translate. Je sais pas si tu es très sévère avec les fautes de français. Anyways

Re: [Discussion]: Add method attribute to request-map

Le 28/06/2018 à 09:56, Mathieu Lirzin a écrit : Hello Taher, Taher Alkhateeb writes: A few comments: 1- I would suggest to try and avoid in the future committing any design changes to the framework without discussing it properly in the mailing list first The limit between a “regular” and “d

Re: [Discussion]: Add method attribute to request-map (Was: svn commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)

A strong +1 to your recommendations. There were several commits in the OFBiz core recently which were not properly discussed before they were committed. We should avoid this. People should have in mind that other committers might not have the time to review, think and discuss these patches in

Re: [Discussion]: Add method attribute to request-map (Was: svn commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)

+1 Taher On Thu, Jun 28, 2018 at 2:01 PM Michael Brohl wrote: > A strong +1 to your recommendations. > > There were several commits in the OFBiz core recently which were not > properly discussed before they were committed. We should avoid this. > > People should have in mind that other committer

Re: svn commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework: base/src/main/java/org/apache/ofbiz/base/util/collections/ webapp/config/ webapp/dtd/ webapp/src/main/java/org/apache/ofbiz/webapp

Le 26/06/2018 à 13:31, Paul Foxworthy a écrit : On 26 June 2018 at 17:58, Taher Alkhateeb wrote: I could be mistaken, but this seems like a very major change that did not have a thorough and proper discussion at the mailing list? I would rather at least have an explanation of what was committe

Re: Welcome to Swapnil M. Mane as new committer!

Many congratulations Swapnil! On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Swapnil to become a new committer and we > arepleased to announce that he has accepted. > > Swapnil has a high level of commitment for Apache OFBiz an

Re: Welcome to Aditya Sharma as new committer!

Many congratulations Aditya! On Wed, Jun 27, 2018 at 1:29 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Aditya to become a new committer and we > arepleased to announce that he has accepted. > > Aditya has proved to be committed and doing a very good work

Re: Welcome to Suraj Khurana as new committer!

Many congratulations Suraj! On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Suraj to become a new committer and we > arepleased to announce that he has accepted. > > Suraj has proved to be committed for a long time now and is do

Re: Welcome to Swapnil M. Mane as new committer!

Congratulations Swapnil! Thanks and Regards -- Pritam Kute On Thu, Jun 28, 2018 at 5:32 PM Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Many congratulations Swapnil! > > On Wed, Jun 27, 2018 at 1:30 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has

Re: Welcome to Suraj Khurana as new committer!

Congratulations Suraj! Thanks and Regards -- *Pritam Kute* | Sr. Enterprise Software Engineer HotWax Commerce by HotWax Systems Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 Cell phone: +91 82519 20492 HotWax Systems r

Re: Welcome to Aditya Sharma as new committer!

Congratulations Aditya! Thanks and Regards -- Pritam Kute On Thu, Jun 28, 2018 at 5:32 PM Pranay Pandey < pranay.pan...@hotwaxsystems.com> wrote: > Many congratulations Aditya! > > On Wed, Jun 27, 2018 at 1:29 AM, Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has i

Re: [Discussion]: Add method attribute to request-map (Was: svn commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)

+1 to Taher's recommendations. Jacopo On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb wrote: > A few comments: > > 1- I would suggest to try and avoid in the future committing any > design changes to the framework without discussing it properly in the > mailing list first > 2- I think it would