Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-16 Thread Jacques Le Roux
Thanks Suraj, Jacques Le 16/04/2019 à 12:33, Suraj Khurana a écrit : Hello Jacques, Thanks for reporting this. Interestingly, I checked and got fail in a case when I have plugins as well in the directory structure. I am using this command to check single test: ./gradlew "ofbiz --test

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-16 Thread Suraj Khurana
Hello Jacques, Thanks for reporting this. Interestingly, I checked and got fail in a case when I have plugins as well in the directory structure. I am using this command to check single test: ./gradlew "ofbiz --test component=order --test suitename=ordertests --test case=order-tests" It works

Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

2019-04-16 Thread Jacques Le Roux
Hi Suraj, Any chances? Thanks Jacques Le 12/04/2019 à 12:03, Jacques Le Roux a écrit : Hi Suraj, Since this commit https://ci.apache.org/builders/ofbizTrunkFramework/builds/729 the testAddRequirementTask test fails when done in trunk framework only.

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-16 Thread Scott Gray
Reasons to increase the minimum version: - compelling new features - end of support of current minimum Reasons to not increase the minimum: - potential instability of new version - complicates the life of users and contributors who still use the existing minimum - lack of expertise in configuring

Re: PrepareLocalesForDropDown.groovy

2019-04-16 Thread Jacques Le Roux
To reassure you: I had a look at log history before removing it. It was part of the Sascha's Apache Jackrabbit effort 7 years ago. Jackrabbit was never adopted: https://issues.apache.org/jira/browse/OFBIZ-4659 Jacques Le 16/04/2019 à 10:07, Olivier Heintz a écrit : One of Example Component

Re: [OPTIONS] Java 11 and Java JDK origin

2019-04-16 Thread Jacques Le Roux
Hi Michael, All, I'll (somehow) give my (not opinionated) opinion in the ASF way. I don't want to be polemical, rather to complete this discussion. The more brains on it the better. So I'll try to gather some facts and let people have their own opinions Inline... Le 15/04/2019 à 10:46,

Re: PrepareLocalesForDropDown.groovy

2019-04-16 Thread Olivier Heintz
One of Example Component goal is to have some example of code or manner to do. So, code present in example not using in a production environment is not a argument to say we should remove it or not. If this code could be use in a localized OFBiz, we should retain it. My 2 cent. Olivier Le

Re: PrepareLocalesForDropDown.groovy

2019-04-16 Thread Michael Brohl
If functionality is in the codebase it might be used even if it is not used in the standard processes/functionality. Better discuss than revert, I'd say. I see no problem here. Thanks, Michael Brohl ecomify GmbH - www.ecomify.de Am 16.04.19 um 08:37 schrieb Pierre Smits: Why is this even

Re: Reformat and homogenize displaying number

2019-04-16 Thread Paul Foxworthy
On Fri, 12 Apr 2019 at 05:30, Nicolas Malin wrote: > > > I would probably limit the types of formatting to percentage and > > currency and quantity. Between those three you probably have all cases > > covered no? > "Currency" should not imply a fixed number of decimal places. Foreign exchange

Re: PrepareLocalesForDropDown.groovy

2019-04-16 Thread Pierre Smits
Why is this even a discussion topic? Are we not going overboard here with having to discuss everything and thus stifling furthering the code and the project? We should not keep stuff in the code base that is not used in production implementations and/or for development. Best regards, Pierre

Re: PrepareLocalesForDropDown.groovy

2019-04-16 Thread Jacques Le Roux
Thanks Nicolas, Removed at revision: 1857622 Jacques Le 15/04/2019 à 15:49, Nicolas Malin a écrit : :) ok for me just go out Nicolas On 14/04/2019 20:42, Jacques Le Roux wrote: This: plugins\example\groovyScripts\PrepareLocalesForDropDown.groovy Le 14/04/2019 à 19:01, Nicolas Malin a