Re: svn commit: r1856609 - in /ofbiz/ofbiz-framework/trunk/applications/order: groovyScripts/test/OrderTests.groovy testdef/data/OrderTestData.xml

[Jacques Le Roux]

Thanks Suraj,

Jacques

Le 16/04/2019 à 12:33, Suraj Khurana a écrit :

Hello Jacques,

Thanks for reporting this.

Interestingly, I checked and got fail in a case when I have plugins as well
in the directory structure.

I am using this command to check single test:
./gradlew "ofbiz --test component=order --test suitename=ordertests --test
case=order-tests"

It works fine when I run ./gradlew testIntegration. On a cursory view, IMO,
data is also not dependent anywhere in the plugins directory, so this
should not be the case.

I will have a deeper look into it and provide more details soon (probably
during the weekend).

--
Best Regards,
Suraj Khurana
TECHNICAL CONSULTANT
mobile: +91 9669750002
email: suraj.khur...@hotwax.co
www.hotwax.co






On Tue, Apr 16, 2019 at 3:01 PM Jacques Le Roux <
jacques.le.r...@les7arts.com> wrote:

Hi Suraj,

Any chances?

Thanks

Jacques

Le 12/04/2019 à 12:03, Jacques Le Roux a écrit :

Hi Suraj,

Since this commit

https://ci.apache.org/builders/ofbizTrunkFramework/builds/729 the
testAddRequirementTask test fails when done in trunk framework

only.

https://ci.apache.org/projects/ofbiz/logs/trunk/framework/html/

See also https://ci.apache.org/builders/ofbizTrunkFramework?numbuilds=40

It works when the plugins are also there:

https://ci.apache.org/builders/ofbizTrunkFrameworkPlugins?numbuilds=25

https://ci.apache.org/projects/ofbiz/logs/trunk/plugins/html/

I have no ideas why. Maybe some data issue (only in a plugin? Maybe

project, not sure).

|
|

|Thanks|

|Jacques|

|
|

Le 30/03/2019 à 08:12, sur...@apache.org a écrit :

Author: surajk
Date: Sat Mar 30 07:12:25 2019
New Revision: 1856609

URL: http://svn.apache.org/viewvc?rev=1856609&view=rev
Log:
Added: Unit test case for service - CreateReturnAdjustment.
(OFBIZ-8857)
Thanks Avnindra Sharma for reporting, Pawan Verma for discussion and

Vivek Singh Bisen for providing the updated patch.

Modified:

ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy
ofbiz/ofbiz-framework/trunk/applications/order/testdef/data/OrderTestData.xml

Modified:

ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy

URL:

http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy?rev=1856609&r1=1856608&r2=1856609&view=diff
==============================================================================

---

ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy
(original)

+++

ofbiz/ofbiz-framework/trunk/applications/order/groovyScripts/test/OrderTests.groovy
Sat Mar 30 07:12:25 2019

@@ -1,6 +1,7 @@
   import org.apache.ofbiz.entity.util.EntityQuery
   import org.apache.ofbiz.service.ServiceUtil
   import org.apache.ofbiz.testtools.GroovyScriptTestCase
+
   class OrderTests extends GroovyScriptTestCase {
       void testAddRequirementTask() {
           Map serviceCtx = [:]
@@ -10,4 +11,13 @@ class OrderTests extends GroovyScriptTes
           Map serviceResult = dispatcher.runSync("addRequirementTask",

serviceCtx)

           assert ServiceUtil.isSuccess(serviceResult)
       }
-}
+    void testCreateReturnAdjustment() {
+        Map serviceCtx = [:]
+        serviceCtx.amount = '2.0000'
+        serviceCtx.returnId = '1009'
+        serviceCtx.userLogin =

EntityQuery.use(delegator).from('UserLogin').where('userLoginId',
'system').cache().queryOne()

+        Map serviceResult =

dispatcher.runSync('createReturnAdjustment', serviceCtx)

+        assert ServiceUtil.isSuccess(serviceResult)
+        assert serviceResult.returnAdjustmentId != null
+    }
+}
\ No newline at end of file

Modified:

ofbiz/ofbiz-framework/trunk/applications/order/testdef/data/OrderTestData.xml

URL:

http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/testdef/data/OrderTestData.xml?rev=1856609&r1=1856608&r2=1856609&view=diff
==============================================================================

---

ofbiz/ofbiz-framework/trunk/applications/order/testdef/data/OrderTestData.xml
(original)

+++

ofbiz/ofbiz-framework/trunk/applications/order/testdef/data/OrderTestData.xml
Sat Mar 30 07:12:25 2019

@@ -54,5 +54,6 @@ under the License.
       <OrderRole orderId="TEST_DEMO10090" partyId="TestDemoCustomer"

roleTypeId="SHIP_TO_CUSTOMER"/>

       <OrderContactMech orderId="TEST_DEMO10090"

contactMechPurposeTypeId="ORDER_EMAIL" contactMechId="TestContactMech"/>

       <Requirement requirementId="1000"

requirementTypeId="CUSTOMER_REQUIREMENT"/>

+    <ReturnHeader returnId="1009" statusId="RETURN_RECEIVED"

returnHeaderTypeId="CUSTOMER_RETURN"/>

     </entity-engine-xml>