Re: buildbot failure in on ofbizBranch17FrameworkPlugins

Jacques Le Roux writes: > Also we get it in the Blamelist (also in Git), but Samuel is not a committer > :/ See my response to your other email for a rationale explaining why we got to Samuel appearing in the blame list. > Le 27/11/2019 à 19:28, build...@apache.org a écrit : >> The Buildbot

Re: [ofbiz-framework] branch release17.12 updated: Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

Hello Jacques, Jacques Le Roux writes: > Not a big deal (it's only in the commits log), I'm not sure we want stuff > like: > > Le 27/11/2019 à 17:48, m...@apache.org a écrit : >> Author: Samuel Trégouët > > Normally we rather use something like > >Thanks to Samuel Tregouet for this fix > >

Re: buildbot failure in on ofbizBranch17FrameworkPlugins

Also we get it in the Blamelist (also in Git), but Samuel is not a committer :/ Le 27/11/2019 à 19:28, build...@apache.org a écrit : The Buildbot has detected a new failure on builder ofbizBranch17FrameworkPlugins while building ofbizTrunkFramework. Full details are available at:

Re: [ofbiz-framework] branch release17.12 updated: Fixed: add XML declaration in “web.xml” files (OFBIZ-6993)

Hi Mathieu, All, Not a big deal (it's only in the commits log), I'm not sure we want stuff like: Le 27/11/2019 à 17:48, m...@apache.org a écrit : Author: Samuel Trégouët Normally we rather use something like Thanks to Samuel Tregouet for this fix I did not notice yet, we have already 10

Re: [POC Vue.Js] first presentation / summary

Hello Olivier, Olivier Heintz writes: > As explained in a previous mail, we (me and others co-worker in a company I > am working for) are working on a POC for using Vue.js as GUI generated > from the current screens/forms/menu xml ofbiz files. > The customer goals is to be able to migrate a

Re: question about ServiceHandler.checkSecureParameter

Hi James, Thanks for your detailed analysis and proposition. Le 26/11/2019 à 17:26, James Yong a écrit : Hi Jacques, all, Haven't look into the POC yet. Please see the following updates: 1. Not a good practice to allow state-changing request via GET method without a token to check for CSRF.

Re: PaymentMethod Plugin or Documentation

Please Charles, As I explained below get to http://ofbiz.apache.org/mailing-lists.html All is explained there Thanks Jacques Le 25/11/2019 à 19:57, Charles Beasley a écrit : Thank you. I will try to figure out what we need. How do I get subscribed? I thought I did subscribe when I

Re: question about ServiceHandler.checkSecureParameter

Hi James, Samuel, I did not read all your message yet James, but I agree with Samuel's answer when it comes about CSRF. Jacques Le 27/11/2019 à 09:28, Samuel Trégouët a écrit : Hi James, I still don't see any reason to keep checkSecureParameter in any form because it is related to

Re: PaymentMethod Plugin or Documentation

Thank you. I will try to figure out what we need. How do I get subscribed? I thought I did subscribe when I submitted this question, but I must be missing something. Sincerely, Charles On 2019/11/23 11:53:49, Jacques Le Roux wrote: > Hi Charles, > > Your message has been moderated. > >

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

To make things absolutely clear, in Buildbot we use pullAllPluginsSource. So "gradlew check" will include the plugins I created OFBIZ-11299 for that Jacques Le 26/11/2019 à 18:04, Mathieu Lirzin a écrit : Jacques Le Roux writes: Since it depends on the good will of scrutinizer/s and

Re: question about ServiceHandler.checkSecureParameter

Hi James, I still don't see any reason to keep checkSecureParameter in any form because it is related to ServiceEventHandler. Protection against csrf is a good idea but it has no thing to do with Service. It should be done upstream in http request processing so every type of event