Re: Github PRs and Jira

2019-12-02 Thread Jacopo Cappellato
On Fri, Nov 29, 2019 at 8:51 AM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Hi, > > Yesterday I have a short discussion with Pierre Smits about Github PRs and > Jira. > > Pierre was asking about https://github.com/apache/ofbiz-framework/pulls I > answered that our workflow is to

Re: Github PRs and Jira

2019-12-02 Thread Rishi Solanki
Hi, Do we have committers practices document ready for git? Sorry if I missed the discussion if already done. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 On Tue, Dec 3, 2019 at 10:57 AM Rishi Solanki wrote: > I don't have any better

Re: Github PRs and Jira

2019-12-02 Thread Rishi Solanki
I don't have any better idea around this. But adding contributors best practice and Readme should be good start to go with, later we can rethink on it. +1 Jacques and Pierre to start with. Best Regards, -- Rishi Solanki *CTO, Mindpath Technology* Intelligent Solutions cell: +91-98932-87847 On

Re: [ofbiz-site] branch master updated: We need to update https://projects.apache.org/project.html?ofbiz

2019-12-02 Thread Jacques Le Roux
En fait c'est https://issues.apache.org/jira/browse/OFBIZ-11285 à faire... Le 02/12/2019 à 19:08, jler...@apache.org a écrit : This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch master in repository

Re: OFBizDebug and OFBIZ-11302

2019-12-02 Thread Mathieu Lirzin
Hello, Jacques Le Roux writes: > With OFBIZ-11302 Mathieu removed the ofbizDebug Gradle task, because "ofbiz > --debug-jvm" can be used instead. This is now ‘gradlew "ofbiz" --debug-jvm’ with the --debug-jvm outside of the double quotes. > I have no problem with this change, it's easy to

Re: [ofbiz-site] branch master updated: Adds Gil and Mathieu as PMC

2019-12-02 Thread Jacques Le Roux
Le 02/12/2019 à 17:51, jler...@apache.org a écrit : This is an automated email from the ASF dual-hosted git repository. jleroux pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/ofbiz-site.git The following commit(s) were added to refs/heads/master by this

OFBizDebug and OFBIZ-11302

2019-12-02 Thread Jacques Le Roux
Hi, With OFBIZ-11302 Mathieu removed the ofbizDebug Gradle task, because "ofbiz --debug-jvm" can be used instead. I have no problem with this change, it's easy to remember. Though I like the idea of having syntax sugar to easy remember commands, like ofbizDebug and ofbizBackground BTW

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2019-12-02 Thread Jacques Le Roux
Le 30/11/2019 à 08:58, Jacques Le Roux a écrit : I think we should rely on a  Checkstyle pre-commit hook: https://gist.github.com/davetron5000/37350 to complement tasks.checkstyleMain.maxErrors So every committer would have it installed locally and the problem would be gone \o/ What do

Re: linting issues on ‘trunk’, ‘gradlew check’ fails.

2019-12-02 Thread Jacques Le Roux
Hi Nicolas, Pawan, With OFBIZ-11278 Mathieu reduced maxErrors to 37769, so it's not a worry for you anymore :) Jacques Le 30/11/2019 à 08:58, Jacques Le Roux a écrit : Hi Nicolas, Pawan, Mathieu said that the lint errors which remains are yours: