Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Deepak Dixit
Many Many Congratulations Girish!! Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Thu, Apr 23, 2020 at 10:46 AM Harsh Vijaywargiya < harsh.vijaywarg...@hotwaxsystems.com> wrote: > Many Congratulations Girish!! > > Thanks & Regards, > Harsh > > On Thu, Apr 23, 2020 at 10:22 AM Devanshu Vy

Re: Welcome James Young as new PMC member

2020-04-22 Thread Deepak Dixit
Many Many congrats James!! Thanks & Regards -- Deepak Dixit ofbiz.apache.org On Thu, Apr 23, 2020 at 11:03 AM Devanshu Vyas wrote: > Congratulations James! > > Thanks & Regards, > Devanshu Vyas. > > > On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > >

Re: Welcome James Young as new PMC member

2020-04-22 Thread Devanshu Vyas
Congratulations James! Thanks & Regards, Devanshu Vyas. On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited James Young to become member of the committee > and we are glad to announce that he has accepted the nomination. > > On beha

Re: Welcome James Young as new PMC member

2020-04-22 Thread Aditya Sharma
Congratulations James! Thanks and regards, Aditya Sharma On Wed, Apr 22, 2020 at 7:34 PM Swapnil M Mane wrote: > Congratulations James! > > - Best regards, > Swapnil M Mane, > ofbiz.apache.org > > > > On Wed, Apr 22, 2020 at 3:58 PM James Yong wrote: > > > Hi all, > > > > Thank you for your wo

Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Aditya Sharma
Congratulations Girish! Thanks and regards, Aditya Sharma On Wed, Apr 22, 2020 at 7:35 PM Swapnil M Mane wrote: > Congratulations Girish! > > - Best regards, > Swapnil M Mane, > ofbiz.apache.org > > > > On Wed, Apr 22, 2020 at 5:55 PM Girish Vasmatkar < > girish.vasmat...@hotwaxsystems.com> wro

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Harsh Vijaywargiya
Many Congratulations Girish!! Thanks & Regards, Harsh On Thu, Apr 23, 2020 at 10:22 AM Devanshu Vyas wrote: > Congratulations Girish! > > Thanks & Regards, > Devanshu Vyas. > > > On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux < > jacques.le.r...@les7arts.com> wrote: > > > The OFBiz PMC has inv

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Devanshu Vyas
Congratulations Girish! Thanks & Regards, Devanshu Vyas. On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invited Girish to become a new committer and we are > pleased to announce that he has accepted. > > Girish is part of the communit

Re: Default constructors in JAVA classes

2020-04-22 Thread Girish Vasmatkar
Hi I am unsure if this needs to be extended or applied to the service classes because even though the service classes do not appear to maintain state, they conceptually relate to the business domain and hence are not a worthy candidate. Moreover they are executed within a context and don't qualify

Re: Default constructors in JAVA classes

2020-04-22 Thread Jacques Le Roux
Le 22/04/2020 à 19:58, Jacques Le Roux a écrit : I have still to read the articles an understand the Lombok project and how we could possibly use it I'm thinking about https://projectlombok.org/setup/gradle but I have no ideas yet to what it entails, someone knows? Jacques

Re: Default constructors in JAVA classes

2020-04-22 Thread Jacques Le Roux
Hi, I agree about changing only non idempotent classes in a 1st approach. That's obviously service and events, but could be also few helper and worker classes. We need to check the later and decide one by one. And if they are not idempotent then they should not be called helper or worker. Or r

Re: Default constructors in JAVA classes

2020-04-22 Thread Daniel Watford
Hi again - I forgot the links! [1] - https://projectlombok.org/features/experimental/UtilityClass [2] - https://www.informit.com/articles/article.aspx?p=1216151&seqNum=4 On Wed, 22 Apr 2020 at 17:38, Daniel Watford wrote: > Hi Suraj, > > If the class author's intention was to create a utility c

Re: Default constructors in JAVA classes

2020-04-22 Thread Daniel Watford
Hi Suraj, If the class author's intention was to create a utility class then I would support demonstrating this by using the private constructor. The Lombok project briefly describes the case they support with the @UtilityClass [1]. Private constructors for utility classes also appears in Effect

Default constructors in JAVA classes

2020-04-22 Thread Suraj Khurana
Hello team, While checking codebase using QAPlug [1], it is suggesting to 'Make sure that utility classes (classes that contain only static methods) do not have a public constructor' as an efficiency enhancement. According to it, all our services, events, helper, worker classes which are mostly i

Re: Welcome James Young as new PMC member

2020-04-22 Thread Swapnil M Mane
Congratulations James! - Best regards, Swapnil M Mane, ofbiz.apache.org On Wed, Apr 22, 2020 at 3:58 PM James Yong wrote: > Hi all, > > Thank you for your words of congratulations. > Hope everyone is well and safe. > Also thanks PMC for the kind invitation. > Looking forward to deeper collabo

Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Swapnil M Mane
Congratulations Girish! - Best regards, Swapnil M Mane, ofbiz.apache.org On Wed, Apr 22, 2020 at 5:55 PM Girish Vasmatkar < girish.vasmat...@hotwaxsystems.com> wrote: > Hi All > > Thanks for your continuous support in this journey. I am honoured and > privileged to be part of this community. S

Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Girish Vasmatkar
Hi All Thanks for your continuous support in this journey. I am honoured and privileged to be part of this community. Sure, the committership comes with great responsibilities and I hope to back it up with even more commitment from my side. Thanks once again! Best, Girish On Wed, Apr 22, 2020

Re: Welcome to Girish Vasmatkar as new committer!

2020-04-22 Thread Jacques Le Roux
Sorry I missed Girish 1st name in subject :/ Le 22/04/2020 à 11:37, Jacques Le Roux a écrit : The OFBiz PMC has invited Girish to become a new committer and we are pleased  to announce that he has accepted. Girish is part of the community for near 2 years and has proposed several smart propos

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Taher Alkhateeb
Congratulations! On Wednesday, April 22, 2020 12:37 +03, Jacques Le Roux wrote:  The OFBiz PMC has invited Girish to become a new committer and we are pleased  to announce that he has accepted. Girish is part of the community for near 2 years and has proposed several smart propositions nota

Re: Welcome James Young as new PMC member

2020-04-22 Thread James Yong
Hi all, Thank you for your words of congratulations. Hope everyone is well and safe. Also thanks PMC for the kind invitation. Looking forward to deeper collaboration. Regards, James On 2020/04/22 10:16:36, Deepak Nigam wrote: > Congratulations James!!! > > Regards > -- > Deepak Nigam > > >

Re: Welcome James Young as new PMC member

2020-04-22 Thread Deepak Nigam
Congratulations James!!! Regards -- Deepak Nigam On Wed, Apr 22, 2020, 3:25 PM Pawan Verma wrote: > Congratulations James! > -- > Thanks & Regards > Pawan Verma > ofbiz.apache.org > > > On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana > wrote: > > > Congratulations James !! > > > > -- > > Best

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Deepak Nigam
Congratulations Girish!!! -- Deepak Nigam On Wed, Apr 22, 2020, 3:31 PM Ankush Upadhyay < ankush.upadh...@hotwaxsystems.com> wrote: > Congratulations Girish!! > > Kind Regards, > Ankush Upadhyay > Senior Technical Consultant > > *HotWax Systems* > *Enterprise open source experts* > cell: +91-81

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Ankush Upadhyay
Congratulations Girish!! Kind Regards, Ankush Upadhyay Senior Technical Consultant *HotWax Systems* *Enterprise open source experts* cell: +91-8109201285 office: 0731-409-3684 http://www.hotwaxsystems.com On Wed, Apr 22, 2020 at 3:26 PM Pawan Verma wrote: > Congratulations Girish! > -- > Than

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Pawan Verma
Congratulations Girish! -- Thanks & Regards Pawan Verma ofbiz.apache.org On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana wrote: > Congratulations Girish !! > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Wed, Apr 22, 2020 at 3:11 PM Ashish Vijaywargiya < > ashish.vi

Re: Welcome James Young as new PMC member

2020-04-22 Thread Pawan Verma
Congratulations James! -- Thanks & Regards Pawan Verma ofbiz.apache.org On Wed, Apr 22, 2020 at 3:16 PM Suraj Khurana wrote: > Congratulations James !! > > -- > Best Regards, > Suraj Khurana > Senior Technical Consultant > > > On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya < > ashish.vija

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Suraj Khurana
Congratulations Girish !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:11 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats Girish! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President of Operations > *HotWax Syste

Re: Welcome James Young as new PMC member

2020-04-22 Thread Suraj Khurana
Congratulations James !! -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Apr 22, 2020 at 3:15 PM Ashish Vijaywargiya < ashish.vijaywarg...@hotwaxsystems.com> wrote: > Congrats James! > > -- > Kind Regards, > Ashish Vijaywargiya > Vice President of Operations > *HotWax Systems

Re: Welcome James Young as new PMC member

2020-04-22 Thread Ashish Vijaywargiya
Congrats James! -- Kind Regards, Ashish Vijaywargiya Vice President of Operations *HotWax Systems* *Enterprise open source experts* cell: +91-9893479711 http://www.hotwaxsystems.com On Wed, Apr 22, 2020 at 2:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invit

Re: Welcome to Vasmatkar as new committer!

2020-04-22 Thread Ashish Vijaywargiya
Congrats Girish! -- Kind Regards, Ashish Vijaywargiya Vice President of Operations *HotWax Systems* *Enterprise open source experts* cell: +91-9893479711 http://www.hotwaxsystems.com On Wed, Apr 22, 2020 at 3:09 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > The OFBiz PMC has invi

Welcome to Vasmatkar as new committer!

2020-04-22 Thread Jacques Le Roux
The OFBiz PMC has invited Girish to become a new committer and we are pleased  to announce that he has accepted. Girish is part of the community for near 2 years and has proposed several smart propositions notably related to security and GraphQL, but not only. Please join me in welcoming and c

Re: Welcome James Young as new PMC member

2020-04-22 Thread Taher Alkhateeb
congratulations On Wednesday, April 22, 2020 11:36 +03, Jacques Le Roux wrote:  The OFBiz PMC has invited James Young to become member of the committee and we are glad to announce that he has accepted the nomination. On behalf of the OFBiz PMC, welcome on board!    

Welcome James Young as new PMC member

2020-04-22 Thread Jacques Le Roux
The OFBiz PMC has invited James Young to become member of the committee and we are glad to announce that he has accepted the nomination. On behalf of the OFBiz PMC, welcome on board!