Re: Github PR template

2020-05-27 Thread Jacques Le Roux
Le 28/05/2020 à 07:45, Aditya Sharma a écrit : I think this might not be a problem until you got to change it;) Thanks Aditya, Actually I simply forgot to commit from my Linux VM :) https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0

Re: Adopting Github Workflow

2020-05-27 Thread Aditya Sharma
>> So maybe Infra can use the description there +1 for using the description >> For the link to Jira it depends on README.adoc. But if we put a link to OFBiz site then the link to Jira is there. Makes sense Thanks and regards, Aditya Sharma On Tue, May 26, 2020 at 7:22 PM Jacques Le Roux < jacqu

Re: Github PR template

2020-05-27 Thread Aditya Sharma
Thanks Jacques! It works I tried creating a PR by comparing trunk to my fork branches and content from template show up. >> I don't think it's a problem, since it's only related to GH, but I don't see .github in Windows. I think this might not be a problem until you got to change it ;) Thanks and

Re: Help required - calling Minilang Experts

2020-05-27 Thread Scott Gray
Hi Carsten, call-simple-method executes in the same manner as if you copied the code from the method being called directly into your code, i.e. it has the same variable scope as the method it's being called from. So the "custRequest" variable from checkStatusCustRequest was available to updateCus

Re: EntityBatchIterator for large data set queries

2020-05-27 Thread Scott Gray
Hi Pritam, I'm not sure about PostgreSQL or Derby but I know with MySQL that using a cursor doesn't really work. You have to set the result set to TYPE_FORWARD_ONLY and CONCUR_READ_ONLY and also set the fetch size to INTEGER.MIN_VALUE. Only then will the driver stream the results and even then,

Help required - calling Minilang Experts

2020-05-27 Thread Carsten Schinzer
Hello MiniLang Experts, I am migrating the checkStatusCustRequest service to Groovy (OFBIZ-11692 ), part of our May CommunityDays scope and sprint. In the finalization I now notice that the original Minilang service „checkStatusCustRequest“ is

Re: Github PR template

2020-05-27 Thread Jacques Le Roux
Note (also added as a comment in OFBIZ-11722): As the Github PR template is not related to OFBiz I followed this GH advice: To store your file in a hidden directory, name the pull request template .github/pull_request_template.md. I don't think it's a problem, since it's only related to GH,

Re: Github PR template

2020-05-27 Thread Jacques Le Roux
Done, please review and amend if necessary Le 22/05/2020 à 12:45, Jacques Le Roux a écrit : I created https://issues.apache.org/jira/browse/OFBIZ-11722 for that Jacques Le 13/05/2020 à 12:13, Jacques Le Roux a écrit : Hi Deepak, Agreed, we had this discussion earlier: https://markmail.org/m

Re: LineLength for checkstyle

2020-05-27 Thread Suraj Khurana
Thanks Jacques. Using this I think we would also be able to configure like, hey don't check for services java files, they don't have default constructors ;) -- Best Regards, Suraj Khurana SENIOR TECHNICAL CONSULTANT mobile: +91 9669750002 email: suraj.khur...@hotwax.co *www.hotwax.co

Re: [GitHub] [ofbiz-framework] sonarcloud[bot] removed a comment on pull request #117: Improved: Update Data Sets

2020-05-27 Thread Jacques Le Roux
I created INFRA-20331 for that Jacques Le 23/05/2020 à 11:34, Pierre Smits a écrit : Thanks Jacques, forellen staking care of thuis. Op za 23 mei 2020 11:28 schreef Jacques Le Roux < jacques.le.r...@les7arts.com>: Actually we have also this information nicely coming to ofbiz-*@ noreply.githu