Re: Parameterized Unit Tests?

2020-05-28 Thread Carsten Schinzer
Hi, I admit, I did fail on the rather „quick“ attempt and decided to rather focus on getting the minilang migration lifted forward with a set of 8 dedicated tests, non-parameterized. So I created a story to investigate this test feature in depth some time in the future:

Re: Help required - calling Minilang Experts

2020-05-28 Thread Carsten Schinzer
Hi Scott, Thanks for your comment. I understand … and I don’t. See, this is the message sequence in the two cases: Case 1 updateCustRequest ==> calls checkStatusCustRequest (Will fail the check if not in an in-progress status) <== returns to calling simple service … do the updateCustRequest

Re: Github PR template

2020-05-28 Thread Jacques Le Roux
Le 28/05/2020 à 07:45, Aditya Sharma a écrit : I think this might not be a problem until you got to change it;) Thanks Aditya, Actually I simply forgot to commit from my Linux VM :) https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;a=commit;h=932303bf3061cde10030f18980212c6ae3c27db0

Re: Adopting Github Workflow

2020-05-28 Thread Aditya Sharma
>> So maybe Infra can use the description there +1 for using the description >> For the link to Jira it depends on README.adoc. But if we put a link to OFBiz site then the link to Jira is there. Makes sense Thanks and regards, Aditya Sharma On Tue, May 26, 2020 at 7:22 PM Jacques Le Roux <