Re: Add CHANGELOG.md file

2020-06-17 Thread Swapnil M Mane
+1 - Best regards, Swapnil M Mane, ofbiz.apache.org On Wed, Jun 17, 2020 at 11:23 AM Deepak Dixit wrote: > Hi Dev, > > As we have already moved to git for the version control system, I propose > to add a changelog file to maintain the changelogs[1]. > What is a changelog? > > A changelog is a

Re: Question re master branch rename support

2020-06-17 Thread Jacques Le Roux
Le 16/06/2020 à 06:51, Daniel Gruno a écrit : We have support built-in for adopting an approach of "master, trunk or $default". We just need to decide on that and apply to all features of .asf.yaml. I'd quite appreciate that because of INFRA-20424 TIA Jacques

Re: Add CHANGELOG.md file

2020-06-17 Thread Suraj Khurana
+1 -- Best Regards, Suraj Khurana Senior Technical Consultant On Wed, Jun 17, 2020 at 5:08 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > +1 > > I believe it would be better done manually with a community consensus. > > Could someone probes me wrong? > > Jacques > > Le 17/06/2020 à

Re: Use Compound Widget on rest of the project

2020-06-17 Thread James Yong
Hi Nicolas, Removed the additional namespace as I agree they are a distraction. Agreed that plugin may be a better place to apply compound widgets, as they are less likely being overriden by existing implementation. Just find it to be troublesome moving between related elements while making chan

Re: Use Compound Widget on rest of the project

2020-06-17 Thread James Yong
Hi Oliver, I would suggest grouping elements that are specific to the main screen being called by a particular requesturi. The example for compound widget is for showcasing the use of compound widgets using very simple forms. Regards, James On 2020/06/15 09:01:53, Olivier Heintz wrote: > Hi

Re: Add CHANGELOG.md file

2020-06-17 Thread Jacques Le Roux
+1 I believe it would be better done manually with a community consensus. Could someone probes me wrong? Jacques Le 17/06/2020 à 07:52, Deepak Dixit a écrit : Hi Dev, As we have already moved to git for the version control system, I propose to add a changelog file to maintain the changelogs[

Re: Add CHANGELOG.md file

2020-06-17 Thread Aditya Sharma
+1 Thanks and Regards, Aditya Sharma On Wed, Jun 17, 2020 at 12:57 PM Carsten Schinzer < cars...@dcs-verkaufssysteme.de> wrote: > +1 for a CHANGELOG.md > > Would this be maintained for all official release branches + trunk, right? > Or official release branches only. > Regards > > Carsten > >

Re: REST implementation

2020-06-17 Thread Carsten Schinzer
Hi Girish, Thanks to clarify :) What caught me on the OpenAPI integration is the snippet quoted below and I realize I should have read it in context. Actually then it is aligned with my view. Warm regards Carsten > Initial implementation does not contain OpenApi integration yet. And

Re: REST implementation

2020-06-17 Thread Girish Vasmatkar
Hi Carsten OpenAPI integration and the implementation go hand in hand so no reason separating them. I think what this draft does is just trying to see how this might work. I am also parallelly working on OpenAPI spec but I wanted the developers to review this work to get a better understanding of

Re: REST implementation

2020-06-17 Thread Carsten Schinzer
Hello Giresh, Thanks for the example, it makes clearer what you want to achieve. General considerations on RESTful or not: If you want to stop a productionRun, why do you use PATCH and not DELETE? Well, I know the connotation of Delete is „dismantle“ rather than „stop“, but PATCH also conside

Check Style on release branches?

2020-06-17 Thread Jacques Le Roux
Hi, While discussing with Aditya at OFBIZ-11304 I asked <> He suggested, and I tend to agree: <> What are your opinions? There are more information if needed at OFBIZ-11304 Thanks Jacques

Re: Add CHANGELOG.md file

2020-06-17 Thread Carsten Schinzer
+1 for a CHANGELOG.md Would this be maintained for all official release branches + trunk, right? Or official release branches only. Regards Carsten