Re: A little bit of Lombok

Thanks Jinghai, Is that long ago? Do you remember the most important issues you crossed? Jacques Le 27/08/2020 à 06:20, Shi Jinghai a écrit : Just my 2 cents. -1 for using Lombok plugin in OFBiz. I had some not good experiences with this plugin in Apereo CAS 5.3.x. 发送自 Windows 10 版邮件

[OFBIZ-11976] svg files not removed on clean

Hi, While looking at this issue I found that a simple "gradlew config" generates the files which are used by generatePluginDocumentation and generateAllPluginsDocumentation. So somehow these tasks are "activated" just launching any task. Does somebody knows why it's so? Thanks Jacques

JsLanguageFilesMappingCreator.java

Hi James, Suraj, As it's documented inside JsLanguageFilesMappingCreator::createJsLanguageFileMapping is used by the createJsLanguageFileMapping service to "create or update JsLanguageFilesMapping.java and JsLanguageFilesMapping.ftl files." This happens when we update the languages used by som

Re: JsLanguageFilesMappingCreator.java

James, Seems you are not concerned. Because with OFBIZ-11958 you created JsLanguageFilesMappingTransform.java. And it's not, and does not need to be, generated by JsLanguageFilesMappingCreator::createJsLanguageFileMapping If you agree you need to put an ASL2 header in it. And I'll revert http

Re: [OFBIZ-11976] svg files not removed on clean

Hi Jacques - This explains it nicely - https://blog.softwaremill.com/my-task-whats-wrong-with-your-gradle-task-82312100c595 Turns out that gradle's configuration phase appears to be "running" the tasks. Best, Girish On Thu, Aug 27, 2020 at 3:12 PM Jacques Le Roux < jacques.le.r...@les7arts.c

Re: JsLanguageFilesMappingCreator.java

Thanks Jacques. I have attached a patch at https://issues.apache.org/jira/browse/OFBIZ-11926 Could you please review it? TIA. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 3:38 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > James, > > Seems yo

Re: JsLanguageFilesMappingCreator.java

Sure I'll, it's long ago but I still remember the difficulties ;) Jacques Le 27/08/2020 à 12:59, Suraj Khurana a écrit : Thanks Jacques. I have attached a patch at https://issues.apache.org/jira/browse/OFBIZ-11926 Could you please review it? TIA. -- Best Regards, Suraj Khurana Senior Technic

Re: [OFBIZ-11976] svg files not removed on clean

Thanks Girish, Yes, I found that too. The weird part is if I run "gradlew generateAllPluginsDocumentation" then the OFBiz-Logo.svg in plugins are deleted. Not when I run any other task. So it seems that config does not run completely the tasks. But if I put a println("

Re: [OFBIZ-11976] svg files not removed on clean

Hi Jacques When you run "gradlew generateAllPluginsDocumentation", all "actions" defined in the task '"generateAllPluginsDocumentation" get executed as part of execution phase. doFirst and doLast are the actions defined hence they get executed. And when you run any other tasks, all tasks present

Re: [OFBIZ-11976] svg files not removed on clean

Thanks Girish! I'll have a look... Jacques Le 27/08/2020 à 14:21, Girish Vasmatkar a écrit : Hi Jacques When you run "gradlew generateAllPluginsDocumentation", all "actions" defined in the task '"generateAllPluginsDocumentation" get executed as part of execution phase. doFirst and doLast are

Re: JsLanguageFilesMappingCreator.java

Thanks Suraj, Pushed with slight changes Jacques Le 27/08/2020 à 13:37, Jacques Le Roux a écrit : Sure I'll, it's long ago but I still remember the difficulties ;) Jacques Le 27/08/2020 à 12:59, Suraj Khurana a écrit : Thanks Jacques. I have attached a patch at https://issues.apache.org/ji

Re: JsLanguageFilesMappingCreator.java

Thanks Jacques for taking care of it. -- Best Regards, Suraj Khurana Senior Technical Consultant On Thu, Aug 27, 2020 at 10:44 PM Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks Suraj, > > Pushed with slight changes > > Jacques > > Le 27/08/2020 à 13:37, Jacques Le Roux a écrit