Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-09 Thread Jacques Le Roux
Got it thanks Le 08/01/2018 à 18:15, Scott Gray a écrit : The argument was that the configs weren't being used by default, so the same would, in theory, apply to those files. Regards Scott On 9/01/2018 5:14 AM, "Jacques Le Roux" wrote: Le 08/01/2018 à 01:36, Scott Gray a écrit : The same g

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Scott Gray
The argument was that the configs weren't being used by default, so the same would, in theory, apply to those files. Regards Scott On 9/01/2018 5:14 AM, "Jacques Le Roux" wrote: Le 08/01/2018 à 01:36, Scott Gray a écrit : > The same goes for the fieldtype definitions. > I agree with you for en

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Jacques Le Roux
Le 08/01/2018 à 01:36, Scott Gray a écrit : The same goes for the fieldtype definitions. I agree with you for entityengine.xml, but those are separated, so I don't see the relationship. Jacques

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-08 Thread Michael Brohl
+1 Michael Am 08.01.18 um 01:36 schrieb Scott Gray: I'm in favor of the status quo. It's useful to have them available out of the box to be able to pick the one you need and proceed without having to look elsewhere. The same goes for the fieldtype definitions. Regards Scott On 8/01/2018 6:26

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Scott Gray
I'm in favor of the status quo. It's useful to have them available out of the box to be able to pick the one you need and proceed without having to look elsewhere. The same goes for the fieldtype definitions. Regards Scott On 8/01/2018 6:26 AM, "Pierre Smits" wrote: We could consider having ex

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Pierre Smits
We could consider having example configurations (entityengine.xml files) for applicable database solutions in the documentation (in confluence). Removing unused code snippets is always worth the effort put forward. Best regards, Pierre Smits V.P. Apache Trafodion On Sun, Jan 7, 2018 at 5:36

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread jler...@apache.org
Le 07/01/2018 à 11:43, Jacques Le Roux a écrit : My answer to your question is: we should keep them of course, except if a better way would be proposed, I see none for now... I must have said: I see none PROVIDED for now... We could consider a modular solution which would include split parts o

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread James Yong
Hi everyone, Only did a quick look at the 2 patches. I think the improvement is incomplete and effectively removed the datasource configurations like MSSQL, MySQL, Oracle etc. Developers (like me) using these databases will require additional work to find and apply the missing configurations.

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Jacques Le Roux
Michael, We crossed on wire. I put a comment just after yours in the Jira it's not an answer to your questions but my thoughts at large. My answer to your question is: we should keep them of course, except if a better way would be proposed, I see none for now... Jacques Le 07/01/2018 à 11:3

Re: [jira] [Commented] (OFBIZ-8230) Disentangle platform specific entity engine schemas

2018-01-07 Thread Michael Brohl
Hi everyone, please have a look at the issue mentioned below and express your opionion if we should remove the different schema configurations from the main entityengine.xml or if we should keep them. Thanks, Michael Am 07.01.18 um 11:23 schrieb Pierre Smits (JIRA): [ https://issues