Re: Deprecating and removing unused HTML renderers

2021-01-16 Thread Jacques Le Roux
Hi Daniel, Inline... Le 15/01/2021 à 11:21, Daniel Watford a écrit : Hi Jacopo, The consensus seemed to be to only mark the renderers as deprecated in trunk for the time being. These changes have already been committed. Thanks, as you certainly know, I made a small amendment using a date

Re: Deprecating and removing unused HTML renderers

2021-01-15 Thread Daniel Watford
Hi Jacopo, The consensus seemed to be to only mark the renderers as deprecated in trunk for the time being. These changes have already been committed. Since marking code as deprecated would probably be classified as an improvement rather than a bug-fix it wasn't appropriate to mark items as

Re: Deprecating and removing unused HTML renderers

2021-01-15 Thread Jacopo Cappellato
On Thu, Jan 14, 2021 at 2:57 PM Daniel Watford wrote: > >[...] > But when should we remove the unused HTML renderers? Is it okay to remove > them from trunk at the same time as marking them deprecated in release 18? > This would ensure they are removed from whichever release is planned to >

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Nicolas Malin
Hello Daniel, Fully agree to follow you proposal. Nicolas On 14/01/2021 16:03, Daniel Watford wrote: > Thanks Jaques, > > After reading the later messages in the thread you posted, and revisiting > the Commiter guidelines you linked to I think the steps for deprecating the > HTML renderers

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Eugen Stan
On 14.01.2021 16:43, Jacques Le Roux wrote: Hi Daniel, Quite a good question, we had similar discussions before. An old one is https://markmail.org/message/rlksriqjznsndq2g The end of last one is https://markmail.org/message/4aia3v5ugjjajmhf It's documented for services at

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Daniel Watford
Thanks Jaques, After reading the later messages in the thread you posted, and revisiting the Commiter guidelines you linked to I think the steps for deprecating the HTML renderers become: 1 - Mark classes as deprecated in trunk only. I've since been reminded that we would only backport bugfixes

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Jacques Le Roux
Le 14/01/2021 à 15:43, Jacques Le Roux a écrit : We currently have 201 @Deprecated occurrences in Java classes (121 in 2008). A large cleanup was done in with OFBIZ-6273 Jacques

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Jacques Le Roux
Hi Daniel, Quite a good question, we had similar discussions before. An old one is https://markmail.org/message/rlksriqjznsndq2g The end of last one is https://markmail.org/message/4aia3v5ugjjajmhf It's documented for services at https://s.apache.org/6ophi We currently have 201 @Deprecated

Re: Deprecating and removing unused HTML renderers

2021-01-14 Thread Eugen Stan
Hi, I am all for getting rid of the extra "fat" ASAP. Working on less code is easier. Mark for 18 + remove in trunk sounds reasonable to me considering the time differences. Larger projects like Kubernetes have a deprecation policy: - deprecate in release X - keep in release X+1 - remove

Deprecating and removing unused HTML renderers

2021-01-14 Thread Daniel Watford
Hello, https://issues.apache.org/jira/browse/OFBIZ-11927 refers to HTML renderers which do not appear to be used anymore. James has confirmed this observation. I assume that we only need to keep the unused classes around in case they are being used by a third party plugin, but we can at least