Re: JS library dynamic import

2022-05-30 Thread Florian Motteau
Thanks for the feedback Jacques & James, I'll read those tickets ! Florian Le 26/05/2022 à 12:05, Jacques Le Roux a écrit : Hi Florian, It all started with OFBIZ-1319. Then somehow related we had OFBIZ-9465 and at some point we envisioned to use Require.js: OFBIZ-9976 Finally in trunk we u

Re: JS library dynamic import

2022-05-27 Thread James Yong
Hi Florian, The reason for using importLibrary is for maintainability and was done under OFBIZ-11799. Beside those you have listed, there is also JS libraries like jstree, readmore, fjTimer, cookies, moments. Before the change, it was often unclear where and when the JS/CSS were used and how th

Re: JS library dynamic import

2022-05-26 Thread Jacques Le Roux
Hi Florian, It all started with OFBIZ-1319. Then somehow related we had OFBIZ-9465 and at some point we envisioned to use Require.js: OFBIZ-9976 Finally in trunk we use npm: OFBIZ-11960 (more with https://issues.apache.org/jira/browse/OFBIZ-11960?jql=project%20%3D%20OFBIZ%20AND%20text%20~%20%2

JS library dynamic import

2022-05-25 Thread Florian Motteau
Hi all, I am currently working on replacing jGrowl (notification library) for a client project. I came across the importLibrary function in OfbizUtil.js (common-theme), which loads external JS/CSS files when needed. If I understand correctly, some of the JS libraries (inputmask, elrte, datet