Re: OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

2021-02-16 Thread Nicolas Malin
Hi Daniel, Thanks for your check. I agree with the different function to create a link would be analyzed and maybe refactored with another logic. To move ahead, I will push my current code for the OFBIZ-11810 [1] as it and convert to the your refactoring effort after. I like to ensure to not

Re: OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

2021-02-10 Thread Daniel Watford
Hi Nicolas, OFBIZ-11900 [1] has been merged now, so there shouldn't be any sort of clash with OFBIZ-11810. OFBIZ-11900 is part of the OFBIZ-11456 [2] refactoring effort, but none of the other child tasks from OFBIZ-11456 are currently being worked on. Therefore I think you should be able to

Re: OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

2021-02-09 Thread Nicolas Malin
Hello Daniel, I'm a little confuse to take more than 6 month to response. You push me on my currently java knowledge limit, and after analyze I didn't understand all you done. However, your works feel good. During my works on the OFBIZ-11810 [1], I confronted to many duplicated code between

OFBIZ-11900: Approach so far for MacroFormRenderer refactoring

2020-07-28 Thread Daniel Watford
Hello, OFBIZ-11900 covers the work-in-progress effort to refactor MacroFormRenderer by extracting code which builds strings to be executed as FTL macros into a separate builder class. This github branch [1] contains the work-in-progress changes for this issue. Please take a look at this branch