Re: Should be keep the multitenant feature even if broken?

2017-03-08 Thread Rishi Solanki
Thanks Jacques! -- Rishi Solanki Sr. Manager, Enterprise Software Development HotWax Systems Pvt. Ltd. Direct: +91-9893287847 http://www.hotwaxsystems.com On Wed, Mar 8, 2017 at 3:37 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Thanks for your ideas Rishi, > > Fixed with

Re: Should be keep the multitenant feature even if broken?

2017-03-08 Thread Jacques Le Roux
Thanks for your ideas Rishi, Fixed with OFBIZ-9230 I had a look at checkRhsType() but that's another beast. Because AFAIK the delegator only misses when checkRhsType is called indirectly from the JobPoller. It begins to miss in this line in selectCountByCondition()

Re: Should be keep the multitenant feature even if broken?

2017-03-04 Thread Rishi Solanki
I dig into the issue and proposed one solution in the same Jira ticket OFBIZ-9230. Please see if it looks fine or may be we can proceed in that direction. Quick Reference from ticket: "In the template/FTL context or in the screen context whenever we get the delegator as null we can use this

Re: Should be keep the multitenant feature even if broken?

2017-03-03 Thread Taher Alkhateeb
All good points Michael. Replacing is neither short term nor easy as many places in the code base depend on this feature, not to mention the need for community approval too. I just mentioned this as an alternative solution from a technical standpoint. So our best bet is to fix the issue mentioned

Re: Should be keep the multitenant feature even if broken?

2017-03-03 Thread Michael Brohl
Hi Taher, I don't think that this is a valid short-term approach. As far as I know, there are users and also service providers relying on the multi-tenant feature and we should have a mid- to long-term roadmap for a migration to other solutions. It would be really helpful to have some

Re: Should be keep the multitenant feature even if broken?

2017-03-03 Thread Jacques Le Roux
Thanks Taher, IMO if we do that we should document clearly how to do it, before dropping and cleaning the multi-tenancy feature. Of course solving the 2 issues reported in OFBIZ-9230 (checkRhsType and getSystemPropertyValue) should be tried before. I'll not create Jiras for that before we get

Re: Should be keep the multitenant feature even if broken?

2017-03-03 Thread Taher Alkhateeb
In my opinion, the multi-tenancy feature can be reasonably replaced with non-java databases like mysql and postgres combined with docker. Both instances share the same code base but with two different runtime volumes and two databases. This would actually reduce the complexity of the code base,

Should be keep the multitenant feature even if broken?

2017-03-02 Thread Jacques Le Roux
Hi, After my analysis at https://s.apache.org/hvR9 if we don't fix the issues reported there I wonder if we don't need to remove the multitenant feature, better not to propose a broken solution! Jacques