Re: Single Form Widget on CSS Grid Layout

2021-01-27 Thread James Yong
Hi Ingo, Some macros like renderTextFindField contains a number of fields. The addition of span tags will group these fields together so that they can be correctly placed next to the form field label. I haven't looked info flexbox much. Thanks Jacques for the additional info. Regards, James

Re: Single Form Widget on CSS Grid Layout

2021-01-27 Thread James Yong
Hi Nicholas, Please see my reply inline.. Regards, James On 2021/01/26 16:59:25, Nicolas Malin wrote: > Hello James, > > I'm a little bit confused with your proposition, It's a direct conflict > with the separation between the model of a form and the way to rendering > it throw the theme.

Re: Single Form Widget on CSS Grid Layout

2021-01-27 Thread Jacques Le Roux
Hi Ingo, Le 27/01/2021 à 08:12, Ingo Könemann a écrit : It feels like using a Flexbox layout would be more appropriate for a    modern look and feel. Why do you feel so? This should help: https://www.google.com/search?q=Flexbox+vs+css+grid=UTF-8 Is there a reason you implemented a CSS

Re: Single Form Widget on CSS Grid Layout

2021-01-26 Thread Ingo Könemann
Hi all, I looked at the patch and have some additional questions about these changes. 1. There are some added elements I do not fully understand in the HtmlFormMacroLibrary.ftl template. Could you explain why they are necessary for the given proposition? 2. It feels like using a

Re: Single Form Widget on CSS Grid Layout

2021-01-26 Thread Nicolas Malin
Hello James, I'm a little bit confused with your proposition, It's a direct conflict with the separation between the model of a form and the way to rendering it throw the theme. If you want create a specific form for different display case maybe check the extend logic OFBIZ-11335

Single Form Widget on CSS Grid Layout

2021-01-26 Thread James Yong
Hi all, Planning to add a new form widget type i.e. single_css-grid-layout. This new type allows Single Form Widget to be layout with CSS Grid, instead of table. Created OFBIZ-12162 with patch for it. Regards, James