Hi,
On 26.06.2012 18:45, Jacopo Cappellato wrote:
The patch attached to OFBIZ-4453 has issues and I don't see how it can fix
the problems
introduced by the commits I reported at the beginning of this thread. The
patch I have attached
to an earlier post in this thread at least should revert
Speaking about DCC, I see a series of commits you did about it that make me
uncomfortable; I am talking about the ones related to:
https://issues.apache.org/jira/browse/OFBIZ-3987
https://issues.apache.org/jira/browse/OFBIZ-4296
for reference this is probably at the beginning of the story (no
Yes, I agree we should do an overhaul there. I agree it's not pretty. It works,
as long as you don't need more than one JMS service,
not sure if you need more (seems that Adrian was asking for).
I have never used more than one yet. It could be that I will need more than one
soon. So would be a
I don't recall asking for more than one JMS service. All I know is the
JMS code was broken such that when you configure OFBiz to not use JMS,
it is used anyway. In other words, there is no way to turn it off.
-Adrian
On 7/17/2012 7:29 PM, Jacques Le Roux wrote:
Yes, I agree we should do an
From: Adrian Crum adrian.c...@sandglass-software.com
I don't recall asking for more than one JMS service. All I know is the JMS code was broken such that when you configure OFBiz to
not use JMS, it is used anyway. In other words, there is no way to turn it off.
Ha yes indeed, I extrapolated to
The patch attached to OFBIZ-4453 has issues and I don't see how it can fix the
problems introduced by the commits I reported at the beginning of this thread.
The patch I have attached to an earlier post in this thread at least should
revert all that work.
Jacopo
On Jun 24, 2012, at 12:15 PM,
Sorry I did not get a chance to look at it seriously since. As long as it does
not prevent DCC to work it's fine with me
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
The patch attached to OFBIZ-4453 has issues and I don't see how it can fix the problems introduced by the
I just did a quick review of the status:
https://issues.apache.org/jira/browse/OFBIZ-4455 must obviously be done: Prevent a
Singelton creation with double lock
There is a pending patch from Martin Kreidenweis at https://issues.apache.org/jira/browse/OFBIZ-4453 which needs our attention,
I can also help in this; but it would be really helpful if you could provide
one diff of all the changes you did (I mean a diff between the current version
and the original version excluding all the commits/reverts happened between
them) and if you could recall all the issues you were
Yes, this or reverting all and restarting from scratch, I'm looking at it now
Jacques
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
I can also help in this; but it would be really helpful if you could provide one diff of all the changes you did (I mean a diff
between the current
This should be enough to revert the two commits (I don't know if there were
others, maybe I will check later in the weekend).
Jacopo
Index: framework/service/src/org/ofbiz/service/ServiceDispatcher.java
===
---
Jacques,
could you please help me to understand all the changes you did around JMS? I
see some issues (e.g. the value of ServiceDispatcher.enableJMS is ignored) and
reviewing the history of commits I have seen that you have committed changes,
then fixed them (partially reverting?) but all in
The refactoring you did has completely broken the architecture:
* JmsListenerFactory is now used as a singleton that is initialized with the
dispatcher that created it
* when a new dispatcher is created, in the constructor you have:
if (enableJMS) {
this.jlf =
I will get back to you as soon as I will get a chance. I did not that for my
pleasure, I crossed issues and tried to fix them, maybe
not the right way indeed...
So basically we are now stuck with only one JMS listener, that's your concern,
right?
In the meantime, this may help
On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting
issue following https://issues.apache.org/jira/browse/OFBIZ-4296
See also https://issues.apache.org/jira/browse/OFBIZ-4454
annoying... in short, the old JMS
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting issue following
https://issues.apache.org/jira/browse/OFBIZ-4296
See also
I will have a look this weekend...
Jacques
From: Jacques Le Roux jacques.le.r...@les7arts.com
From: Jacopo Cappellato jacopo.cappell...@hotwaxmedia.com
On Jun 22, 2012, at 11:36 AM, Jacques Le Roux wrote:
https://issues.apache.org/jira/browse/OFBIZ-4453 seems the last interesting issue
17 matches
Mail list logo
