Re: orderSkipInvoice, complete an order without generating an invoice

2018-03-01 Thread Rishi Solanki
Nicolas, I have some concerns like how to override the enumeration at order level and overriding it at order level is okay, may be people from community advise here. But yes a POC would be of help to understand the exact use cases, which may clear my most concerns. Please consider one suggestion

Re: orderSkipInvoice, complete an order without generating an invoice

2018-03-01 Thread Antoine Ouvrard
Hi Taher and everyone, Thank for your feedback, and I'm very sorry (and I'm little ashamed) to have generated a patch with postgres config. So bad!:) I will rework this approvement with Enumeration mechanism (thank Nicolas). And I hope to offer you a more flexible solution. See you soon!

Re: orderSkipInvoice, complete an order without generating an invoice

2018-03-01 Thread Nicolas Malin
Hello Rishi On 28/02/2018 11:43, Rishi Solanki wrote: Nicolas, Thank you for the detailed information. I agree on setting the trigger value on on store level so that each store may behaves as per business need, in case of multiple stores. Just one question here, orderHeader will also have the

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-28 Thread Rishi Solanki
Nicolas, Thank you for the detailed information. I agree on setting the trigger value on on store level so that each store may behaves as per business need, in case of multiple stores. Just one question here, orderHeader will also have the same field or it is intended to override some default

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-27 Thread Nicolas Malin
Hi Rishi On 26/02/2018 15:11, Rishi Solanki wrote: Antoine, In general I observe that for a party business may want to send invoice at the end of month. But for that as well I think its okay to generate the invoice at the time of order completion and send all invoices once. Also what Taher

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-26 Thread Suraj Khurana
+1 Rishi. I agree to you. -- Thanks and Regards *Suraj Khurana* | Sr. Enterprise Software Engineer *HotWax Commerce* by *HotWax Systems* Plot no. 80, Scheme no. 78, Vijay Nagar, Indore, M.P. India 452010 Cell phone: +91 96697-50002 On Mon, Feb 26, 2018 at 7:41 PM, Rishi Solanki

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-26 Thread Rishi Solanki
Antoine, In general I observe that for a party business may want to send invoice at the end of month. But for that as well I think its okay to generate the invoice at the time of order completion and send all invoices once. Also what Taher suggested looks promising to me. That means use invoice

Re: orderSkipInvoice, complete an order without generating an invoice

2018-02-26 Thread Taher Alkhateeb
Hi Antoine, Thank you for your work and I hope we get to work with you more often. I have a few comments / questions: - First of all, you added a postgres dependency to the build file (probably by mistake?). - perhaps others can pitch in but I'm not sure if it is useful to introduce? Is this a

orderSkipInvoice, complete an order without generating an invoice

2018-02-26 Thread Antoine Ouvrard
Hello, I would like to introduce you a improvement. In some case, we need to delay billing at the end of the month for example. But to complete the order we need to disable triggering the invoice generation. Here's my proposal https://issues.apache.org/jira/browse/OFBIZ-10241 Antoine