Mathieu Lirzin writes:
> Taher Alkhateeb writes:
>
>> - I still don't understand your answer on the new data structure
>> "MultiValuedMapContext". This is essentially a whole new data
>> structure designed by you and it overrides nearly all standard
>> methods. Having such a custom and un-tested
Hello,
Just wanted to correct a mistake I have made.
Mathieu Lirzin writes:
> I needed a MultiMap meaning a map which associates a key to a List of
> values not to a scalar. What is nice is that “MultivaluedMap::put” is
> not destructive, it just appends the new value to the already associated
Hello Taher,
Taher Alkhateeb writes:
> First of all, I would like to say I really enjoy looking at your code.
> I can tell that it was done with lots of love :)
Thanks for your kind words. :-)
> I took a deeper look at the code and I have a few more questions /
> comments / suggestions:
> - Fi
Oh and for the rest of the folks in our community, this is a very
critical piece of work, I think more than one pair of eyes should be
on it, so please take a look at it if you can.
On Sun, Jul 15, 2018 at 7:47 PM, Taher Alkhateeb
wrote:
> Hello Mathieu,
>
> First of all, I would like to say I re
Hello Mathieu,
First of all, I would like to say I really enjoy looking at your code.
I can tell that it was done with lots of love :)
I took a deeper look at the code and I have a few more questions /
comments / suggestions:
- First of all and to stay consistent with the rest of the OFBiz
archit
Hello,
Taher Alkhateeb writes:
> Examining your patch I have a few comments / questions:
FYI I have updated the third patch on OFBIZ-10438 [1] to improve the
tests for the ‘resolveMethod’ static method.
[1] https://issues.apache.org/jira/browse/OFBIZ-10438
Thanks.
--
Mathieu Lirzin
GPG: F2A
Le 09/07/2018 à 19:43, nig...@gmail.com a écrit :
Currently, we can define request-map which invokes Java method, like following
example:
Security element just checks, if user is Signed in or not. If you want to add
permission check, you will have
Hi,
Your message has been moderated. Please subscribe to the dev ML for next
exchanges
http://ofbiz.apache.org/mailing-lists.html
Thanks
Jacques
Le 09/07/2018 à 19:43, nig...@gmail.com a écrit :
Currently, we can define request-map which invokes Java method, like following
example
Currently, we can define request-map which invokes Java method, like following
example:
Security element just checks, if user is Signed in or not. If you want to add
permission check, you will have to keep adding code inside java method. And if
developer
xample that Scott presented. IIUC what Scott is
providing is a DSL for generating the representations of a resource and
the action that it supports. This could potentially be plugged in the
‘request-map’ change I am proposing but I see this as a complementary if
not as an alternate work.
> - Can
Thank you Mathieu, this makes things clearer and yes I stand corrected
on using the word protocol instead of method.
I appreciate your patience and help in easing my way to your code, and
please excuse any dumb questions from my side :) it's a bug chunk of
code indeed.
Examining your patch I have
Hello Taher,
Taher Alkhateeb writes:
> Before we dig into the details, may I first understand _why_ are you
> adding that functionality in the first place? In other words, you can
> decide on the HTTP protocol from the calling page right? If it is a
> form, it's a POST, if it is a URL, it's a GE
thing here?
On Tue, Jul 3, 2018 at 7:05 PM, Mathieu Lirzin
wrote:
> Hello,
>
> Following revert of rev 1834917, I want to “properly” propose adding a
> ‘method’ attribute to ‘request-map’ elements.
>
> I am currently working on adding REST based Web APIs to OFBiz [1]. In
> order
Shi Jinghai writes:
> Yeah, I forgot the site-conf.xsd, now I reverted it in rev. 1835043.
Thanks, I have updated the patches from OFBIZ-10438 to re-add those :-)
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
Jacques Le Roux writes:
> FYI: You were lucky that your attached patches passed, it's not usually.
>
> In general better to reference patches in some place. An existing
> Jira, like OFBIZ-4274 or OFBIZ-10438 here, fits here
OK, I have included those patches in OFBIZ-10438.
Thank you for the exp
Thank you Mathieu!
Yeah, I forgot the site-conf.xsd, now I reverted it in rev. 1835043.
-邮件原件-
发件人: Mathieu Lirzin [mailto:mathieu.lir...@nereide.fr]
发送时间: 2018年7月4日 0:06
收件人: dev@ofbiz.apache.org
主题: Add ‘method’ attribute to ‘request-map’ elements
Hello,
Following revert of rev
evert of rev 1834917, I want to “properly” propose adding a
‘method’ attribute to ‘request-map’ elements.
I am currently working on adding REST based Web APIs to OFBiz [1]. In
order to do that, it is important for the HTTP controller to handle
various HTTP methods differently, meaning allow
Hello,
Following revert of rev 1834917, I want to “properly” propose adding a
‘method’ attribute to ‘request-map’ elements.
I am currently working on adding REST based Web APIs to OFBiz [1]. In
order to do that, it is important for the HTTP controller to handle
various HTTP methods differently
m]
> 发送时间: 2018年7月3日 18:00
> 收件人: dev@ofbiz.apache.org
> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
> r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
>
> That is not a constructive thing to say in my opinion. Sounds to me like:
> hey I don&#
2018年6月28日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
commit: r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1 to Taher's recommendations.
Jacopo
On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb <
slidingfilame...@g
Le 03/07/2018 à 11:53, Mathieu Lirzin a écrit :
If you or Mathieu would like to start a discussion I'd recommend a new thread
I will open a new thread summarizing the goal/intent of adding a
‘method’ attribute to ‘request-map’ elements, and describing the
proposed changes.
Thanks Ma
org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
That is not a constructive thing to say in my opinion. Sounds to me like:
hey I don't like reverting, but I know this code is good and now that I
reverted I d
te to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
That is not a constructive thing to say in my opinion. Sounds to me like:
hey I don't like reverting, but I know this code is good and now that I
reverted I don't care. This is not how a community work
his valuable code I needed :)
>
>
> -邮件原件-
> 发件人: Taher Alkhateeb [mailto:slidingfilame...@gmail.com]
> 发送时间: 2018年7月3日 15:09
> 收件人: OFBIZ Development Mailing List
> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
> commit: r1834389 - in /
gt;> If you or Mathieu would like to start a discussion I'd recommend a new thread
I will open a new thread summarizing the goal/intent of adding a
‘method’ attribute to ‘request-map’ elements, and describing the
proposed changes.
Thanks.
--
Mathieu Lirzin
GPG: F2A3 8D7E EB2B 6640 5761 070D 0ADE E100 9460 4D37
邮件原件-
> >> 发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
> >> 发送时间: 2018年6月28日 23:59
> >> 收件人: dev@ofbiz.apache.org
> >> 主题: Re: [Discussion]: Add method attribute to request-map (Was: svn
> commit: r1834389 - in /ofbiz/ofbiz-frame
-邮件原件-
发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
发送时间: 2018年6月28日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1 to Taher's recommendatio
Mathieu decides, I have got his valuable code I needed :)
-邮件原件-
发件人: Taher Alkhateeb [mailto:slidingfilame...@gmail.com]
发送时间: 2018年7月3日 15:09
收件人: OFBIZ Development Mailing List
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz
]: Add method attribute to request-map (Was: svn commit:
> r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
>
> +1 to Taher's recommendations.
>
> Jacopo
>
> On Thu, Jun 28, 2018 at 9:15 AM, Taher Alkhateeb > wrote:
>
>> A few comments:
>>
>>
Reverted in rev 1834917.
-邮件原件-
发件人: Jacopo Cappellato [mailto:jacopo.cappell...@hotwaxsystems.com]
发送时间: 2018年6月28日 23:59
收件人: dev@ofbiz.apache.org
主题: Re: [Discussion]: Add method attribute to request-map (Was: svn commit:
r1834389 - in /ofbiz/ofbiz-framework/trunk/framework...)
+1
s mentioned our community rule, "a
> proper discussion".
> >
> > I created an issue "Add method attribute to request-map to controll a
> uri can be called GET or POST only" a week ago:
> > https://issues.apache.org/jira/browse/OFBIZ-10438
> >
> >
endations, and I don't know about the rest of the
> > folks opinion here so I invite everyone else to have their input.
> >
> > On Thu, Jun 28, 2018 at 6:46 AM, Shi Jinghai
> wrote:
> >> Hi all,
> >>
> >> Thanks Jacques, Taher and
I created an issue "Add method attribute to request-map to controll a uri can be
called GET or POST only" a week ago:
https://issues.apache.org/jira/browse/OFBIZ-10438
Thanks Mathieu, he submitted his patches very quickly while I was preparing
mine. I tested them and submitted to
Le 28/06/2018 à 09:56, Mathieu Lirzin a écrit :
Hello Taher,
Taher Alkhateeb writes:
A few comments:
1- I would suggest to try and avoid in the future committing any
design changes to the framework without discussing it properly in the
mailing list first
The limit between a “regular” and “d
Hello Taher,
Taher Alkhateeb writes:
> A few comments:
>
> 1- I would suggest to try and avoid in the future committing any
> design changes to the framework without discussing it properly in the
> mailing list first
The limit between a “regular” and “design” change can sometimes hard to
define
at 6:46 AM, Shi Jinghai wrote:
> Hi all,
>
> Thanks Jacques, Taher and Nicolas mentioned our community rule, "a proper
> discussion".
>
> I created an issue "Add method attribute to request-map to controll a uri can
> be called GET or POST only" a week
Hi all,
Thanks Jacques, Taher and Nicolas mentioned our community rule, "a proper
discussion".
I created an issue "Add method attribute to request-map to controll a uri can
be called GET or POST only" a week ago:
https://issues.apache.org/jira/browse/OFBIZ-10438
Thanks M
That's great thanks Deepak,
Ismail, please understand that this ML (dev ML) is used by developers to
discuss developing new stuff or improving stuff.
As suggested by Deepak, for questions regarding the usage of OFBiz please ask
them on the user ML
Thanks
Jacques
Le 12/02/2017 à 09:09, Deep
Hi Ismail,
If Service return success then it will render view mentioned in response
name success, and if service fails and return error it will render view
mentioned in response name error.
Please refer ServiceUtil and ModelService java file for more reference.
Please use user mailing list for th
Hello Dears.
There are anyone can help me to explain the elements on code below
and what the "success" & "error" .
Thanks to all.
Best Regards,
Ismail Alkouz
Java Developer
[Description: Logo for Office-4]
[Description: bi email-3-02]
P.O.Box
[
https://issues.apache.org/jira/browse/OFBIZ-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux closed OFBIZ-5765.
--
Resolution: Incomplete
> missing request map for changing curre
here are some inconsistencies. But I don't
see how the attached patch could solve them in the backend since it's a
ecommerce request map. It could be still applied for ecommerce where people
could use something like proposed in OFBIZ-5767. But this should be done w/o
introducing regre
code.
Anyway I reverted the changes for OFBIZ-5767 in
trunk r1650583
R14.12 r1650584
R13.07 r1650585
R12.04 r1650586
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: http
be a separate company and/or product store setup.
Thoughts from other community members would be helpful in resolving this issue.
{quote}
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
>
that would pretty
much be a separate company and/or product store setup.
Thoughts from other community members would be helpful in resolving this issue.
{quote}
> missing request map for changing currency
> -
>
>
[
https://issues.apache.org/jira/browse/OFBIZ-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jacques Le Roux reassigned OFBIZ-5765:
--
Assignee: Jacques Le Roux (was: Ashish Vijaywargiya)
> missing request map
other one for accountant and tax authority.
Right now I'm confused, for I don't know what intended design is.
As it is now, it's incosistent.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
>
t intended design is.
As it is now, it's incosistent.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Projec
.)
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OFBiz
> Issue Type: Bug
> Components:
l in resolving this issue.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OFBiz
> Issue Type:
[
https://issues.apache.org/jira/browse/OFBIZ-5765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Vijaywargiya reassigned OFBIZ-5765:
--
Assignee: Ashish Vijaywargiya
> missing request map for changing curre
king currency from session.
I think I tracked root problem, possibly fixed:
https://issues.apache.org/jira/browse/OFBIZ-5767
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://iss
ssue is kinda related with OFBIZ-4412.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OFBiz
>
apped to any requests in eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OF
mapping to set shopping
cart currency.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OFBiz
>
n eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OFBiz
> Issu
apped to any requests in eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OF
st, they are
were mapped to any requests in eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
&
st, they are
were mapped to any requests in eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
&
apped to any requests in eccommerce controller.xml.
> missing request map for changing currency
> -
>
> Key: OFBIZ-5765
> URL: https://issues.apache.org/jira/browse/OFBIZ-5765
> Project: OF
Josip Almasi created OFBIZ-5765:
---
Summary: missing request map for changing currency
Key: OFBIZ-5765
URL: https://issues.apache.org/jira/browse/OFBIZ-5765
Project: OFBiz
Issue Type: Bug
o ask questions. Use rather user ML for such questions:
http://cwiki.apache.org/confluence/display/OFBADMIN/Mailing+Lists
> URL parameter passed to secure (https) request-map is not allowed for
> secur
URL parameter passed to secure (https) request-map is not allowed for security
reasons
--
Key: OFBIZ-4596
URL: https://issues.apache.org/jira/browse/OFBIZ-4596
Assignee: Jacques Le Roux
Thanks Wai,
Your patch is in
trunk r1184906
R11.04 r1184911.
> createuserlogin, createUserLogin duplicate request map entries
> --
>
> Key: OFBIZ-4486
>
gin duplicate request map entries
> --
>
> Key: OFBIZ-4486
> URL: https://issues.apache.org/jira/browse/OFBIZ-4486
> Project: OFBiz
> Issue Type: Bug
> Components: s
createuserlogin, createUserLogin duplicate request map entries
--
Key: OFBIZ-4486
URL: https://issues.apache.org/jira/browse/OFBIZ-4486
Project: OFBiz
Issue Type: Bug
obal GL Account - Found URL parameter [glAccountId] passed to
> secure (https) request-map with uri [updateGlAccount]
> ---
>
> Key: OFBIZ-3316
&g
Release Branch 10.04
SVN trunk
Resolution: Fixed
Thanks Ankit,
Your patch is in untrk at r948017, R9.04 at r948021, R10.04 at r948019
> Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to
> secure (https) request-map with uri [updateGlA
TH :)
> Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to
> secure (https) request-map with uri [updateGlAccount]
> --
will have a look...
> Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to
> secure (https) request-map with uri [updateGlAccount]
> --
t it appears the only link to
updateGlAccount is in GlobalGlAccountsForms.xml -> EditGlAccount which worked
correctly. Checked the 9.04 branch and it appears to be correct as well.
> Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to
> secure (https) request
vent: org.ofbiz.webapp.event.EventHandlerException: Found URL
parameter [glAccountId] passed to secure (https) request-map with uri
[updateGlAccount] with an event that calls service [updateGlAccount]; this is
not allowed for security reasons! The data should be encrypted by making it
part of the request body (a form f
Edit/Navigate Global GL Account - Found URL parameter [glAccountId] passed to
secure (https) request-map with uri [updateGlAccount]
---
Key: OFBIZ-3316
please reopen with more arguments
> Added a value attribute to request-map in Work Effort module
>
>
> Key: OFBIZ-2734
> URL: https://issues.apache.org/jira/browse/OFBIZ-2734
>
ixed there.it does not need a
mapping...
> Added a value attribute to request-map in Work Effort module
>
>
> Key: OFBIZ-2734
> URL: https://issues.apache.org/jira/browse/OFBIZ-2734
&g
.
Regards:
Simranjeet Singh
> Added a value attribute to request-map in Work Effort module
>
>
> Key: OFBIZ-2734
> URL: https://issues.apache.org/jira/browse/OFBIZ-2734
>
lue attribute to request-map in Work Effort module
>
>
> Key: OFBIZ-2734
> URL: https://issues.apache.org/jira/browse/OFBIZ-2734
> Project: OFBiz
> Issue Type: Bug
IZ-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Simranjeet Singh updated OFBIZ-2734:
>
>
> Attachment: Work_Effort_Request_map.patch
>
>> Added a value attribu
[
https://issues.apache.org/jira/browse/OFBIZ-2734?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simranjeet Singh updated OFBIZ-2734:
Attachment: Work_Effort_Request_map.patch
> Added a value attribute to request-map in W
Added a value attribute to request-map in Work Effort module
Key: OFBIZ-2734
URL: https://issues.apache.org/jira/browse/OFBIZ-2734
Project: OFBiz
Issue Type: Bug
Hi all,
Almost every controller.xml file has the following request-maps:
1) In which situations is used the "view" request?
It has auth="false" (why?), which allows not authe
81 matches
Mail list logo
