Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adrian Crum
On 5/12/2012 9:12 PM, Adam Heath wrote: On 05/12/2012 07:17 AM, Adrian Crum wrote: Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
On 05/12/2012 07:17 AM, Adrian Crum wrote: Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without going into too much detail, here is a sum

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adrian Crum
Okay, rev 1337518 gets the tests to pass, but it isn't a fix - it merely masks the real problem. I made the commit so others can continue with their work, and I will continue working on the real problem. Without going into too much detail, here is a summary of the problem: 1. Previously, Mini-

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adrian Crum
I believe the check-errors fix revealed a test failure that was being hidden before the fix. -Adrian On 5/12/2012 8:24 AM, Jacopo Cappellato wrote: yeah, it could be something unrelated to Adrian's commit. Adrian let me know if you find something or if you want me to have a look as well. Jac

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Jacopo Cappellato
yeah, it could be something unrelated to Adrian's commit. Adrian let me know if you find something or if you want me to have a look as well. Jacopo On May 12, 2012, at 9:20 AM, Adam Heath wrote: > Hold off. On trunk, I get issues, but if I reverse the below patch, it > doesn't solve the probl

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adam Heath
Hold off. On trunk, I get issues, but if I reverse the below patch, it doesn't solve the problem. git bisect can be confused when 2 problems are happening. I'll check this further in the morning. On 05/12/2012 02:08 AM, Adrian Crum wrote: The tests cases pass on my local machine. Could you

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adrian Crum
Thanks Jacopo! I am working on it. -Adrian On 5/12/2012 8:14 AM, Jacopo Cappellato wrote: Adrian, I am forwarding you a zip file with my test results. Jacopo On May 12, 2012, at 9:08 AM, Adrian Crum wrote: The tests cases pass on my local machine. Could you provide the test report XML fi

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Jacopo Cappellato
Adrian, I am forwarding you a zip file with my test results. Jacopo On May 12, 2012, at 9:08 AM, Adrian Crum wrote: > The tests cases pass on my local machine. Could you provide the test report > XML file please? > > -Adrian > > On 5/12/2012 3:59 AM, Adam Heath wrote: >> On 05/11/2012 05:25

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-12 Thread Adrian Crum
The tests cases pass on my local machine. Could you provide the test report XML file please? -Adrian On 5/12/2012 3:59 AM, Adam Heath wrote: On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewv

Re: svn commit: r1337103 - /ofbiz/trunk/framework/minilang/src/org/ofbiz/minilang/method/envops/CheckErrors.java

2012-05-11 Thread Adam Heath
On 05/11/2012 05:25 AM, adri...@apache.org wrote: Author: adrianc Date: Fri May 11 10:25:33 2012 New Revision: 1337103 URL: http://svn.apache.org/viewvc?rev=1337103&view=rev Log: Fixed broken Mini-language element (second try). Modified: ofbiz/trunk/framework/minilang/src/org/ofbiz/minil