Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Deepak Dixit
I checked all the possible menu items. Thanks Regards -- Deepak Dixit On Jul 5, 2013, at 7:33 PM, Jacques Le Roux wrote: Yes I wondered about that also, but, from his assertion, thought Deepak checked all others Deepak? Jacques From: Adrian Crum adrian.c...@sandglass-software.com

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Jacques Le Roux
Hi Deepak, Adrian, If I understood well, only menu items are concerned. Because there are no reasons to want a hidden form for a menu item. In other cases, for security reasons, we want to be sure to have hidden forms. If we need to check all menus items, we either need to create a tool or rely

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Jacques Le Roux
Hoo, thanks Deepak! Jacques Deepak Dixit wrote: I checked all the possible menu items. Thanks Regards Yes I wondered about that also, but, from his assertion, thought Deepak checked all others Deepak? Jacques From: Adrian Crum adrian.c...@sandglass-software.com That doesn't

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Scott Gray
IMO the bigger question to consider is why does this link have an event attached to it? What makes it so special that it needs one when virtually every other navigation link doesn't? Regards Scott On 6/07/2013, at 8:18 PM, Jacques Le Roux wrote: Hoo, thanks Deepak! Jacques Deepak

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-06 Thread Jacques Le Roux
Yes another solution would have been to create services. But it's more work and need to analyse why it's like that if we don't want to introduce possible regressions After all, it's just about being able to open a menu-item in a tab Jacques From: Scott Gray scott.g...@hotwaxmedia.com IMO the

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
This doesn't make sense. Why are those two menu items exceptions to the rule? -Adrian On 7/5/2013 7:57 AM, jler...@apache.org wrote: Author: jleroux Date: Fri Jul 5 06:57:03 2013 New Revision: 1499918 URL: http://svn.apache.org/r1499918 Log: A patch from Deepak Dixit for Application Menu

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
Hi Adrian, These controller request has event, and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links to hidden for for service type of event as

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
On 7/5/2013 12:19 PM, Deepak Dixit wrote: Hi Adrian, These controller request has event, and if an request event attribute is not null then WidgetWorker.determineAutoLinkType() return hidden-form as link type and its create an empty form for the same. WidgetWorker method convert hyper links

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Adrian Crum
That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all other requests that include an event? -Adrian On 7/5/2013 12:19 PM, Deepak Dixit wrote: Hi Adrian, These controller request has event, and if an request event

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Deepak Dixit
I found these reported request :) All the request with event attribute will be render in same way and create hidden form. Thanks Regards -- Deepak Dixit On Jul 5, 2013, at 5:04 PM, Adrian Crum wrote: That doesn't answer my question. Why are only two requests being changed? What makes

Re: svn commit: r1499918 - in /ofbiz/trunk/applications: marketing/widget/sfa/SfaMenus.xml order/widget/ordermgr/OrderMenus.xml

2013-07-05 Thread Jacques Le Roux
Yes I wondered about that also, but, from his assertion, thought Deepak checked all others Deepak? Jacques From: Adrian Crum adrian.c...@sandglass-software.com That doesn't answer my question. Why are only two requests being changed? What makes those two requests the exception to all other