Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Since nobody answered, I will remove it in few days as a lazy consensus Jacques Le 03/10/2016 à 13:16, Jacques Le Roux a écrit : Hi Ashish, At r1763154 I did all the similar trivial changes. To All, Adam, I wonder about keeping this code put in in 2008 with

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Jacques, This is good idea to keep such information on JIRA ticket so anyone can easily pick it. I have created https://issues.apache.org/jira/browse/OFBIZ-8341 If I find more such classes then I will add in this ticket, and will also try to provide the patch for this soon. Thanks &

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Harsh, Any chances about that, should we not create a Jira? Thanks Jacques Le 17/09/2016 à 13:52, Harsh Vijaywargiya a écrit : Hi Jacques, Ashish I also noted few classes with such patterns during clean up, and in first attempt I just cleaned the default TODOs. I will provide a patch

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, At r1763154 I did all the similar trivial changes. To All, Adam, I wonder about keeping this code put in in 2008 with http://svn.apache.org/viewvc?view=revision=713573 /** * Finds product variants based on a product ID and a distinct feature. */ public static Map

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Jacques, Ashish I also noted few classes with such patterns during clean up, and in first attempt I just cleaned the default TODOs. I will provide a patch with this and other suggested enhancements. Thanks & Regards, Harsh On Saturday 17 September 2016 04:56 PM, Jacques Le Roux wrote:

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, This should be improved, exception in services should use Debug.logError, use return ServiceUtil.returnError and not swallow the exception Le 17/09/2016 à 12:34, ash...@apache.org a écrit : product = EntityQuery.use(delegator).from("Product").where("productId",

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, The comment above should be removed as well Le 17/09/2016 à 12:34, ash...@apache.org a écrit : public String complete(boolean force) throws GeneralException { // clear out empty lines -// this.checkEmptyLines(); // removing, this seems to be causeing issues

Re: svn commit: r1761181 [1/2] - in /ofbiz/trunk/applications/product/src/main/java/org/apache/ofbiz: product/category/ product/category/ftl/ product/config/ product/feature/ product/imagemanagement/

Hi Ashish, I think we lose some information here Le 17/09/2016 à 12:34, ash...@apache.org a écrit : public static Map prodFindDistinctVariants(DispatchContext dctx, Map context) { -// * String productId -- Parent (virtual) product