Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Thank you very much for the revert Jacques. On Apr 13, 2017 10:19 AM, "Jacques Le Roux" wrote: Le 12/04/2017 à 21:36, Taher Alkhateeb a écrit : > You are right about the revert I got that confused. My problem, however, is > not that of introducing bugs in the

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Le 12/04/2017 à 21:36, Taher Alkhateeb a écrit : You are right about the revert I got that confused. My problem, however, is not that of introducing bugs in the code. My problem is committing without understanding. Trust me, when I do something I try as much as possible to understand what I'm

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

You are right about the revert I got that confused. My problem, however, is not that of introducing bugs in the code. My problem is committing without understanding. If some code is misbehaving I don't just comment it out without understanding what it does. I have committed a fix, so please

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Le 12/04/2017 à 19:44, Taher Alkhateeb a écrit : Your reply indicates that you do not understand what you committed Jacques! I trust Swapnil and Deepak and tested the change which worked. But as I said in the Jira it was a random issue for me so hard to test! You don't need to go far to

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

I'd expect that as a committer you would follow all Jiras and even all Jira comments not only those you are interested Moreover you were the one who introduced this issue http://ofbiz.markmail.org/search/?q=dependsOn+%22%3Aplugins%3A%24%7BpluginId%7D%3Ainstall%22 So I'd expect you to care

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

I cannot follow up with every single JIRA, also, I assume if you commit code then you know what you're doing. On Wed, Apr 12, 2017 at 8:38 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Also I'd have expected that you had commented in the Jira before! > > Why wait the commit? > >

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Do you have neat references? Commits numbers? Thanks Jacques Le 12/04/2017 à 19:44, Taher Alkhateeb a écrit : Your reply indicates that you do not understand what you committed Jacques! You don't need to go far to know what is the problem, it's right there in front of you, it's in this email

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Your reply indicates that you do not understand what you committed Jacques! You don't need to go far to know what is the problem, it's right there in front of you, it's in this email thread with the EXACT line that's causing the problem. Let me give you a hint: Build file

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Also I'd have expected that you had commented in the Jira before! Why wait the commit? Jacques Le 12/04/2017 à 19:35, Jacques Le Roux a écrit : Please explain more or point to links where it's already explained Thanks Jacques Le 12/04/2017 à 18:54, Taher Alkhateeb a écrit : This commit

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

Please explain more or point to links where it's already explained Thanks Jacques Le 12/04/2017 à 18:54, Taher Alkhateeb a écrit : This commit is completely wrong and poorly thought and does not fix the root cause. Please revert On Wed, Apr 12, 2017 at 7:38 PM, wrote:

Re: svn commit: r1791143 - /ofbiz/ofbiz-framework/trunk/framework/resources/templates/build.gradle

This commit is completely wrong and poorly thought and does not fix the root cause. Please revert On Wed, Apr 12, 2017 at 7:38 PM, wrote: > Author: jleroux > Date: Wed Apr 12 16:38:59 2017 > New Revision: 1791143 > > URL: http://svn.apache.org/viewvc?rev=1791143=rev > Log: