Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml

2019-09-29 Thread Deepak Nigam
Thanks, Swapnil and Pierre for your inputs. I'll do an SVN prop change. Thanks & Regards -- Deepak Nigam On Sun, Sep 29, 2019 at 3:56 PM Pierre Smits wrote: > Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As per > established conventions. > > On Sat, 28 Sep 2019 at 15:50 S

Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml

2019-09-29 Thread Pierre Smits
Fyi: improvement (tickets) get ‘implemented’, and bugs get ‘fixed’. As per established conventions. On Sat, 28 Sep 2019 at 15:50 Swapnil M Mane wrote: > Hi Deepak, > > Happy to see your commits in action. :) > Just a minor suggestion, we put Jira ticket ID in separate line in commit > log. > Als

Re: svn commit: r1867663 - /ofbiz/ofbiz-framework/trunk/framework/common/config/CommonEntityLabels.xml

2019-09-28 Thread Swapnil M Mane
Hi Deepak, Happy to see your commits in action. :) Just a minor suggestion, we put Jira ticket ID in separate line in commit log. Also, add colon ':' in Thanks statement. And since the ticket type is 'Improvement', it seems to me, we should use 'Improved' instead of 'Fixed'. Here is commit templa