gt;> this "-" could be configured in a properties file, and I think
>>>>> that's a good idea. Otherwise, if you have four or five features
>>>>> you will easily overrun the 20-character productId key limit.
>>>>> Keeping it in properties file is a
gt;>> This patch is a good idea, but I think Scott Gray suggested that
>>>>> this "-" could be configured in a properties file, and I think
>>>>> that's a good idea. Otherwise, if you have four or five features
>>>>> you will easily overrun the 20-character productId key limit.
>>>>> Keeping it in properties file is a
features
you will easily overrun the 20-character productId key limit.
Keeping it in properties file is a good way to allow it to be
modified. Otherwise it's not very nice to have to go into the code
to do it.
Jonathon, you up for doing this and sending in another patch?
Si
----------
On Jan 22, 2007, at 11:45 AM, Si Chen wrote:
David,
Unfortunately I find this to be somewhat unsatisfactory for two
reasons:
1. Any potential problem when present should be addressed or at
least considered. This bit of code possibly adds a trivial
enhancement in the eyes of some user
ry nice to have to go into the code
to do it.
Jonathon, you up for doing this and sending in another patch?
Si
----------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeature
gt; that many features
> >>> saving 1 character might not be much of a bonus.
> >>>
> >>> Regards
> >>> Scott
> >>>
> >>> Jacopo Cappellato wrote:
> >>>> I agree with Si.
> >>>>
> >>>> Jacop
ise, if you have four or five features
you will easily overrun the 20-character productId key limit.
Keeping it in properties file is a good way to allow it to be
modified. Otherwise it's not very nice to have to go into the code
to do it.
Jonathon, you up for doing this and sending in
to the code
to do it.
Jonathon, you up for doing this and sending in another patch?
Si
----------------------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
From
oing this and sending in
another patch?
Si
------------------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/
ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007
David,
Whether OOTB Ofbiz will support both ways or not
doesn't make exposing the primary key to the user any
less dangerous.
The generated Id in the variant example should be the
marketing product id in GoodIdentification, not the
primary key Product.productId. The marketing product
id you show
-----------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/
ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007 12:48:56 -
To:
commits@ofbiz.apache.org
To:
commits@ofbiz.apache.org
you up for doing this and sending in another patch?
Si
--------------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007 12:48:56 -
To:
---------------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007 12:48:56 -
To:
commits@ofbiz.apache.org
To:
commits@ofbiz.apache
in properties file is a good way to
allow it to be
modified. Otherwise it's not very nice to
have
to go into the
code to do it.
Jonathon, you up for doing this and sending in
another patch?
Si
------------
Sub
+1
Jacques
- Original Message -
From: "David E. Jones" <[EMAIL PROTECTED]>
To:
Cc: "Tom Anderson" <[EMAIL PROTECTED]>
Sent: Saturday, January 20, 2007 8:15 AM
Subject: Re: [Fwd: svn commit: r495891 -
/ofbiz/trunk/applications/produ
Maybe, as a compromise, to avoid the properties file issue you could
just put an extra field in the UI for the character(s) to use to
separate the base ID from the feature idCode(s).
-David
On Jan 20, 2007, at 12:04 AM, Jonathon -- Improov wrote:
Si,
> This patch is a good idea, but I
t many features
> >>> saving 1 character might not be much of a bonus.
> >>>
> >>> Regards
> >>> Scott
> >>>
> >>> Jacopo Cappellato wrote:
> >>>> I agree with Si.
> >>>>
>
Si,
> This patch is a good idea, but I think Scott Gray suggested that this
> "-" could be configured in a properties file, and I think that's a good
> idea. Otherwise, if you have four or five features you will easily
> overrun the 20-character productId key limit. Keeping it in properties
> f
--------
----
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/
ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007 12:48:56 -
To:
commits@ofbiz.apache.org
To:
commits@ofbiz.apache.org
Aut
>> Keeping it in properties file is a good way to
> allow it to be
> >>> modified. Otherwise it's not very nice to have
> to go into the
> >>> code to do it.
> >>>
> >>> Jonathon, you up for doing this and send
y nice to have to go into the
code to do it.
Jonathon, you up for doing this and sending in another patch?
Si
------------
Subject:
svn commit: r495891 - /ofbiz/trunk/applications/product/src/org/
ofbiz/product/feature/ProductFeatureSer
do it.
Jonathon, you up for doing this and sending in another patch?
Si
------------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTE
n another patch?
Si
--------
Subject:
svn commit: r495891 -
/ofbiz/trunk/applications/product/src/org/ofbiz/product/feature/ProductFeatureServices.java
From:
[EMAIL PROTECTED]
Date:
Sat, 13 Jan 2007 12:48:56 -
To:
commits@ofbiz.apache.org
To:
commits@ofbiz.apache.org
Author: jleroux
Date: Sat
Hey there -
This patch is a good idea, but I think Scott Gray suggested that this
"-" could be configured in a properties file, and I think that's a good
idea. Otherwise, if you have four or five features you will easily
overrun the 20-character productId key limit. Keeping it in properties
Author: jleroux
Date: Sat Jan 13 04:48:55 2007
New Revision: 495891
URL: http://svn.apache.org/viewvc?view=rev&rev=495891
Log:
A patch from Jonathon Wong "Prepend feature idCodes with '-'"
(https://issues.apache.org/jira/browse/OFBIZ-620)
Modified:
ofbiz/trunk/applications/product/src/org/o
25 matches
Mail list logo
