Done at revision: 750018
I did not used UtilXml or JAXP directly yet, will hopefully do it later...
If you think more should be done please proceed...
Jacques
From: "Jacques Le Roux"
I had a closer look, I think we should keep scaleImageInAllSize() in product component as it's specific to i
I had a closer look, I think we should keep scaleImageInAllSize() in product component as it's specific to it (I will rename the
package org.ofbiz.product.image.ImageTransform)
Hence some errors labels should be kept in ProductErrorUiLabels.xml and some
other put in a new CommonErrorUiLabels.xml
Jacques Le Roux wrote:
> We cross 2 issues if we want to move ImageTransform to common
> 1) ImageTransform. depends on jdom which is in webapp/lib => should we
> move it to common/lib also (makes sense IMO)
It doesn't really depend on jdom. Look at the source, it's doing nothing
special with jdom
We cross 2 issues if we want to move ImageTransform to common
1) ImageTransform. depends on jdom which is in webapp/lib => should we move it
to common/lib also (makes sense IMO)
2) I think we shoul aldo move all the keys 'should we rather create a CommonErrorUiLabels.xml file ?)
What do you thi
Yes, I thought about that too. Where do you think we should put it ? framework/images is mostly for static content, rather common I
guess ?
BTW, I have refactored the code below since...
Jacques
From: "Adam Heath"
jler...@apache.org wrote:
Added: ofbiz/trunk/applications/product/src/org/ofb
jler...@apache.org wrote:
> Added:
> ofbiz/trunk/applications/product/src/org/ofbiz/image/ImageTransform.java
> URL:
> http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/image/ImageTransform.java?rev=739042&view=auto
>
