Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread David E Jones
On Dec 7, 2009, at 2:36 PM, Adam Heath wrote: > Jacques Le Roux wrote: >> Reverted at r888111 in trunk, R9.04 at r888113 > > Actually, there's more to this. > > If you are *just* using ControlServlet parts of ofbiz, which does > serverhit stuff, then you will probably never ever hit this bug. >

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Jacques Le Roux
Thanks Adam, All this is very interesting. I never tried webslinger, because I don't know how to use it and did not get a chance to dig in code to understand Jacques () ascii ribbon campaign against HTML e-mail /\ www.asciiribbon.org From: "Adam Heath" Adam Heath wrote: Jacques Le Roux

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adam Heath
Adam Heath wrote: > Jacques Le Roux wrote: >> Reverted at r888111 in trunk, R9.04 at r888113 > > Actually, there's more to this. > > If you are *just* using ControlServlet parts of ofbiz, which does > serverhit stuff, then you will probably never ever hit this bug. > > However, when using websli

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adam Heath
Jacques Le Roux wrote: > Reverted at r888111 in trunk, R9.04 at r888113 Actually, there's more to this. If you are *just* using ControlServlet parts of ofbiz, which does serverhit stuff, then you will probably never ever hit this bug. However, when using webslinger, which is a faster rendering t

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Jacques Le Roux
Reverted at r888111 in trunk, R9.04 at r888113 Jacques () ascii ribbon campaign against HTML e-mail /\ www.asciiribbon.org From: "Adam Heath" David E Jones wrote: Just a quick thing I noticed while looking at this again: this won't prevent conflicts in multi-server deployments. -David T

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Jacques Le Roux
From: "Adrian Crum" Have you visited the related Jira issue? I can repeat the problem with my local machine, and the patch does indeed fix it. I agree it doesn't solve the multi-server issue. I don't know why the original idea of a sequence ID wasn't used. Because no update path (change i

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adam Heath
David E Jones wrote: > On Dec 7, 2009, at 1:37 PM, Adam Heath wrote: > >> David E Jones wrote: >>> Just a quick thing I noticed while looking at this again: this won't >>> prevent conflicts in multi-server deployments. >>> >>> -David >> This patch is completely, 100% wrong, and won't fix the prob

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread David E Jones
On Dec 7, 2009, at 1:37 PM, Adam Heath wrote: > David E Jones wrote: >> Just a quick thing I noticed while looking at this again: this won't prevent >> conflicts in multi-server deployments. >> >> -David > > This patch is completely, 100% wrong, and won't fix the problem. > > > install ofbiz

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adrian Crum
Have you visited the related Jira issue? I can repeat the problem with my local machine, and the patch does indeed fix it. I agree it doesn't solve the multi-server issue. I don't know why the original idea of a sequence ID wasn't used. -Adrian Adam Heath wrote: David E Jones wrote: Just

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adam Heath
David E Jones wrote: > Just a quick thing I noticed while looking at this again: this won't prevent > conflicts in multi-server deployments. > > -David This patch is completely, 100% wrong, and won't fix the problem. install ofbiz, install demo data, run it. /usr/sbin/ab -c30 -t 50 http://loc

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Adrian Crum
Jacques, Anyone wanting to have detailed records of every server hit will have to expect it to affect performance. You can't track server hits for free. If performance becomes a problem, there is another way to do synchronization that would be a little faster. -Adrian Jacques Le Roux wrote

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread Jacques Le Roux
Ha yes! It's only better for a sile OFBiz instance :/ (and we have still not feedback on performances) What would you suggest ? If I remember well Karim's solution was good but without an upgrade path... Jacques () ascii ribbon campaign against HTML e-mail /\ www.asciiribbon.org From: "Dav

Re: svn commit: r887916 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/stats/ServerHitBin.java

2009-12-07 Thread David E Jones
Just a quick thing I noticed while looking at this again: this won't prevent conflicts in multi-server deployments. -David On Dec 7, 2009, at 7:00 AM, jler...@apache.org wrote: > Author: jleroux > Date: Mon Dec 7 13:00:09 2009 > New Revision: 887916 > > URL: http://svn.apache.org/viewvc?rev