[GitHub] incubator-omid issue #41: [OMID-102] Support for user Filter when using copr...

Github user JamesRTaylor commented on the issue: https://github.com/apache/incubator-omid/pull/41 This is great, @yonigottesman! Do the Phoenix unit tests FlappingTransactionIT.testInflightUpdateNotSeen() and testInflightDeleteNotSeen() pass with this change? You can try running them

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206935434 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206934998 --- Diff: hbase-coprocessor/src/test/java/org/apache/omid/transaction/TestSnapshotFilter.java --- @@ -226,8 +222,115 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206936274 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -52,6 +52,7 @@ static byte[] DELETE_TOMBSTONE =

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206860096 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206861622 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206848753 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/OmidSnapshotFilter.java --- @@ -83,92 +76,97 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206867892 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user JamesRTaylor commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206927180 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206856182 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206857467 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206862264 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206843754 --- Diff: hbase-common/src/main/java/org/apache/omid/transaction/CellUtils.java --- @@ -382,13 +385,16 @@ public int hashCode() {

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206852241 --- Diff: hbase-coprocessor/src/main/java/org/apache/omid/transaction/TransactionVisibilityFilter.java --- @@ -0,0 +1,248 @@ +/* + *

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user ohadshacham commented on a diff in the pull request: https://github.com/apache/incubator-omid/pull/41#discussion_r206839768 --- Diff: hbase-client/src/test/java/org/apache/omid/transaction/TestCellUtils.java --- @@ -99,11 +99,11 @@ public void

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

GitHub user yonigottesman reopened a pull request: https://github.com/apache/incubator-omid/pull/41 [OMID-102] Support for user Filter when using coprocessor for snapshot filtering You can merge this pull request into a Git repository by running: $ git pull

[GitHub] incubator-omid pull request #41: [OMID-102] Support for user Filter when usi...

Github user yonigottesman closed the pull request at: https://github.com/apache/incubator-omid/pull/41 ---

[GitHub] incubator-omid pull request #40: [OMID-106] Delete should use write timestam...

Github user ohadshacham closed the pull request at: https://github.com/apache/incubator-omid/pull/40 ---

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565538#comment-16565538 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on the issue:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565535#comment-16565535 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565532#comment-16565532 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565529#comment-16565529 ] ASF GitHub Bot commented on OMID-102: - Github user JamesRTaylor commented on a diff in the pull

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565272#comment-16565272 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565269#comment-16565269 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565262#comment-16565262 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565268#comment-16565268 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565266#comment-16565266 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565261#comment-16565261 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565267#comment-16565267 ] ASF GitHub Bot commented on OMID-102: - Github user ohadshacham commented on a diff in the pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565061#comment-16565061 ] ASF GitHub Bot commented on OMID-102: - GitHub user yonigottesman reopened a pull request:

[jira] [Commented] (OMID-102) Implement visibility filter as pure HBase Filter

[ https://issues.apache.org/jira/browse/OMID-102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16565060#comment-16565060 ] ASF GitHub Bot commented on OMID-102: - Github user yonigottesman closed the pull request at:

[jira] [Commented] (OMID-106) Delete does not use write timestamp after checkpoint

[ https://issues.apache.org/jira/browse/OMID-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564988#comment-16564988 ] ASF GitHub Bot commented on OMID-106: - Github user ohadshacham closed the pull request at:

[jira] [Commented] (OMID-105) Family deletion seek should continue when a tentative value is found

[ https://issues.apache.org/jira/browse/OMID-105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16564987#comment-16564987 ] ASF GitHub Bot commented on OMID-105: - Github user ohadshacham closed the pull request at: