Re: Review Request 36002: OODT-855: Avrorpc communication channel for catalog

2015-09-15 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36002/#review99161 --- Ship it! Ship It! - Lewis McGibbney On July 2, 2015, 1:14 p.m

Re: Review Request 37705: Full implementation of Avro RPC cas-workflow module.

2015-09-15 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37705/#review99159 --- Ship it! Ship It! - Lewis McGibbney On Sept. 4, 2015, 2:29 p.m

Re: Review Request 36953: Full implementation of AvroRPC alongside XMLRPC in filemgr module

2015-09-07 Thread Lewis McGibbney
gt; https://reviews.apache.org/r/36953/ > --- > > (Updated Aug. 27, 2015, 10:54 p.m.) > > > Review request for oodt, Lewis McGibbney and Chris Mattmann. > > > Repository: oodt > > > Description > --- > > Separated the FileManager logic from

Re: Review Request 38021: OODT-872 Upgrade Jena dependencies to org.apache.jena 3.0.0

2015-09-07 Thread Lewis McGibbney
and grid componenets pass. Had to remove the -Xdoclint:none from core/pom.xml due to javac 8 restrictions. Also stepped through a good bit of code and made implemented generic type safety. Thanks, Lewis McGibbney

Re: Review Request 37705: Full implementation of Avro RPC cas-workflow module.

2015-09-05 Thread Lewis McGibbney
/AvroRpcWorkflowManager.java:[510,52] incompatible types [ERROR] required: java.util.List [ERROR] found:java.util.List [ERROR] -> [Help 1] {code} It seems there are some Type issues within the newly introduced classes. Can you investigate? - Lewis McGibbney On Sept. 4, 2015, 2:29 p.m., R

Re: Review Request 38021: OODT-872 Upgrade Jena dependencies to org.apache.jena 3.0.0

2015-09-05 Thread Lewis McGibbney
on > > project oodt-commons: There are test failures. > > [ERROR] > > [ERROR] Please refer to > > /Users/mattmann/tmp/oodt0.11/commons/target/surefire-reports for the > > individual test results. > > [ERROR] -> [Help 1] > > [ERROR] > > [

Re: Review Request 37701: Full Avro RPC impementation in crawler module.

2015-09-03 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37701/#review97620 --- Ship it! Ship It! - Lewis McGibbney On Aug. 27, 2015, 12:11 p.m

Review Request 38021: OODT-872 Upgrade Jena dependencies to org.apache.jena 3.0.0

2015-09-01 Thread Lewis McGibbney
safety. Thanks, Lewis McGibbney

Re: Review Request 37705: Full implementation of Avro RPC cas-workflow module.

2015-08-24 Thread Lewis McGibbney
, 2015, 12:39 a.m., Radu Manole wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37705/ > --- > > (Updated Aug. 24, 2015, 12:39 a.m.) > >

Re: Review Request 36953: Full implementation of AvroRPC alongside XMLRPC in filemgr module

2015-08-24 Thread Lewis McGibbney
ted e-mail. To reply, visit: > https://reviews.apache.org/r/36953/ > --- > > (Updated Aug. 24, 2015, 5:19 p.m.) > > > Review request for oodt, Lewis McGibbney and Chris Mattmann. > > > Repository: oodt > > > Description > --- > > Separa

Re: Review Request 26064: OODT-754 contribute ProdTypePatternMetExtractor

2014-09-27 Thread Lewis McGibbney
good for me * Generally a good patch... and extremely useful as well. Thanks for this - Lewis McGibbney On Sept. 26, 2014, 1:04 a.m., Ricky Nguyen wrote: > > --- > This is an automatically generated e-mail. To reply, visit

Re: Review Request 22791: Streaming OODT Changes

2014-08-14 Thread Lewis McGibbney
> On Aug. 13, 2014, 11:44 p.m., Lewis McGibbney wrote: > > Hey Michael, > > Can you please talk a bit about how streaming works for the FileMgr? > > I am really interested about that. > > Michael Starch wrote: > The filemanager has two primary functio

Re: Review Request 24060: OODT-721: Fix File Manager Tests - Remove Duplicate XML

2014-07-30 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24060/#review49192 --- Ship it! Ship It! - Lewis McGibbney On July 29, 2014, 6:23 p.m

Re: Review Request 24065: OODT-722: Fix file manager unit tests in the 'repository' package

2014-07-30 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24065/#review49194 --- Ship it! Ship It! - Lewis McGibbney On July 29, 2014, 8:13 p.m

Re: Review Request 24060: OODT-721: Fix File Manager Tests - Remove Duplicate XML

2014-07-30 Thread Lewis McGibbney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24060/#review49191 --- Ship it! SHIP IT - Lewis McGibbney On July 29, 2014, 6:23 p.m

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
> On July 23, 2014, 11:50 p.m., Lewis McGibbney wrote: > > Checked out fresh copy of trunk, applied patch > > mvn install > > > > Results : > > > > Failed tests: > > > > testGetElements(org.apache.oodt.cas.filemgr.validation.TestXMLValida

Re: Review Request 23878: Successor to rlaidlaw reviewboard #23870 for OODT-685

2014-07-24 Thread Lewis McGibbney
ibrary/Java/JavaVirtualMachines/jdk1.7.0_55.jdk/Contents/Home/jre Default locale: en_US, platform encoding: UTF-8 OS name: "mac os x", version: "10.9.3", arch: "x86_64", family: "mac" Thanks, Lewis McGibbney

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
estFileManagerCli): org.apache.oodt.cas.cli.exception.CmdLineConstructionException: Invalid option: 'typeName' Tests run: 190, Failures: 1, Errors: 1, Skipped: 0 I seriously think that we should commit this patch as a solution to stabalizing trunk codebase in filemgr - Lewis McGibbney On July 23, 2014, 11:

Re: Review Request 23870: OODT-685: update the file manager unit tests to reflect changes in the project directory structure

2014-07-24 Thread Lewis McGibbney
://reviews.apache.org/r/23878/ Nice work rlaidlaw... REALLY nice work. - Lewis McGibbney On July 23, 2014, 11:33 p.m., Ross Laidlaw wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 22671: OODT-685 Fix OODT 0.7-SNAPSHOT Jenkins nightly build on Ubuntu (1st pass - e.g. define new test structure and resources)

2014-06-16 Thread Lewis McGibbney
can be done includes review if generated filemgr artifact before and after the patch has been attached to verify that OODT-688 has been addressed. Thanks, Lewis McGibbney

Re: Review Request 22671: OODT-685 Fix OODT 0.7-SNAPSHOT Jenkins nightly build on Ubuntu (1st pass - e.g. define new test structure and resources)

2014-06-16 Thread Lewis McGibbney
if generated filemgr artifact before and after the patch has been attached to verify that OODT-688 has been addressed. Thanks, Lewis McGibbney

Re: Review Request 22671: OODT-685 Fix OODT 0.7-SNAPSHOT Jenkins nightly build on Ubuntu (1st pass - e.g. define new test structure and resources)

2014-06-16 Thread Lewis McGibbney
automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22671/#review45888 --- On June 17, 2014, 3:02 a.m., Lewis McGibbney wrote: > > ---

Re: Review Request 22671: OODT-685 Fix OODT 0.7-SNAPSHOT Jenkins nightly build on Ubuntu (1st pass - e.g. define new test structure and resources)

2014-06-16 Thread Lewis McGibbney
locally will not result in stable build for filemgr or pushpull. Testing which can be done includes review if generated filemgr artifact before and after the patch has been attached to verify that OODT-688 has been addressed. Thanks, Lewis McGibbney