Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6371 --- Ship it! LGTM - brian On 2012-03-23 21:19:16, Ricky Nguyen wrote:

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

> On 2012-03-26 21:06:00, brian Foster wrote: > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java, > > line 48 > > > > > > i don't think this case is ever true... this chec

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6368 --- trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/ --- (Updated 2012-03-23 21:19:16.059506) Review request for oodt, Chris Mattmann, br

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6282 --- Great patch! Couple comments trunk/filemgr/src/main/java/org/apa

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/#review6348 --- Ship it! LGTM. trunk/filemgr/src/main/java/org/apache/oodt/cas/file

Review Request: filemgr query throws NPE when sorting by key with possibly empty values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4458/ --- Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl John,