Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-26 Thread Mattmann, Chris A (388J)
Hey Ricky, +1, sounds fine and thanks for fixing them! Cheers, Chris On Mar 23, 2012, at 3:07 PM, Nguyen, Ricky wrote: > filed subtask OODT-431 under OODT-410. > simple fix, didn't think i needed review board since all discussion happened > for OODT-410 already. > committed and seems like jenk

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-23 Thread Mattmann, Chris A (388J)
You rock thanks Ricky! Sent from my iPhone On Mar 23, 2012, at 3:08 PM, "Nguyen, Ricky" wrote: > filed subtask OODT-431 under OODT-410. > simple fix, didn't think i needed review board since all discussion happened > for OODT-410 already. > committed and seems like jenkins build succeeds. > >

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-23 Thread Nguyen, Ricky
filed subtask OODT-431 under OODT-410. simple fix, didn't think i needed review board since all discussion happened for OODT-410 already. committed and seems like jenkins build succeeds. On Mar 22, 2012, at 8:13 AM, Ramirez, Paul M (388J) wrote: > Hey Chris, > > Yep, you're right so I'll look i

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-22 Thread Ramirez, Paul M (388J)
Hey Chris, Yep, you're right so I'll look into this further. I know that commit broke the build as Jenkins keeps telling the list. I wonder if the bug was there before. If I recall you just expanded the unit test. Anyhow when I have more time I'll try to track this down if someone doesn't get t

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-21 Thread Mattmann, Chris A (388J)
Hi Paul, On Mar 21, 2012, at 3:41 PM, Ramirez, Paul M (388J) wrote: > Hey Guys, > > This commit broke the unit test > (org.apache.oodt.cas.filemgr.catalog.TestMappedDataSourceCatalog) with the > addition of: > > assertEquals("ShouldBeFirstForPage.txt", > ((Product)myCat.getFirstPage(type).ge

Re: svn commit: r1302489 - in /oodt/trunk: CHANGES.txt filemgr/src/main/java/org/apache/oodt/cas/filemgr/catalog/DataSourceCatalog.java filemgr/src/test/org/apache/oodt/cas/filemgr/catalog/TestDataSou

2012-03-21 Thread Ramirez, Paul M (388J)
Hey Guys, This commit broke the unit test (org.apache.oodt.cas.filemgr.catalog.TestMappedDataSourceCatalog) with the addition of: assertEquals("ShouldBeFirstForPage.txt", ((Product)myCat.getFirstPage(type).getPageProducts().get(0)).getProductName()); The data source catalog is sorted by produ