[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15208226#comment-15208226
]
Ferenc Denes commented on OOZIE-2429:
-
[~rkanter] Thanks for the review and the fix
>
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207676#comment-15207676
]
Robert Kanter commented on OOZIE-2429:
--
+1 on the addendum patch.
> TestEventGeneration test is
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207589#comment-15207589
]
Hadoop QA commented on OOZIE-2429:
--
Testing JIRA OOZIE-2429
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15207081#comment-15207081
]
Hadoop QA commented on OOZIE-2429:
--
Testing JIRA OOZIE-2429
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206938#comment-15206938
]
Robert Kanter commented on OOZIE-2429:
--
Ok, the braces are fine.
I kicked off Jenkins, the
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15206147#comment-15206147
]
Ferenc Denes commented on OOZIE-2429:
-
[~rkanter] Thanks for the review.
1. I have checked the size
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205606#comment-15205606
]
Robert Kanter commented on OOZIE-2429:
--
Two minor things on the amendment patch:
- With
{code}
+
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200564#comment-15200564
]
Purshotam Shah commented on OOZIE-2429:
---
+1
> TestEventGeneration test is flakey
>
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15179030#comment-15179030
]
Robert Kanter commented on OOZIE-2429:
--
+1
[~puru]?
> TestEventGeneration test is flakey
>
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177812#comment-15177812
]
Ferenc Denes commented on OOZIE-2429:
-
Rebuilt it, just the good old testSamplers remained, there is a
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177714#comment-15177714
]
Hadoop QA commented on OOZIE-2429:
--
Testing JIRA OOZIE-2429
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15177549#comment-15177549
]
Ferenc Denes commented on OOZIE-2429:
-
The failed test cases are unrelated.
> TestEventGeneration
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176642#comment-15176642
]
Hadoop QA commented on OOZIE-2429:
--
Testing JIRA OOZIE-2429
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15176052#comment-15176052
]
Ferenc Denes commented on OOZIE-2429:
-
[~puru], [~rkanter] thanks for the comments. I have attached
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15165924#comment-15165924
]
Robert Kanter commented on OOZIE-2429:
--
Ya, something like that sounds good to me. [~fdenes]?
>
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15163401#comment-15163401
]
Purshotam Shah commented on OOZIE-2429:
---
I think the patch try to avoid any operation if there are
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159893#comment-15159893
]
Robert Kanter commented on OOZIE-2429:
--
Actually, I think we probably could put something in
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15159890#comment-15159890
]
Robert Kanter commented on OOZIE-2429:
--
[~puru], the verifyPrecondition takes care of skipping when
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15152380#comment-15152380
]
Ferenc Denes commented on OOZIE-2429:
-
[~puru] Thank for the review. I have spent some more time
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15138036#comment-15138036
]
Purshotam Shah commented on OOZIE-2429:
---
{code}
}
if (formerCoordinatorStatus !=
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15115401#comment-15115401
]
Ferenc Denes commented on OOZIE-2429:
-
Test cases are unrelated (the on in question disappeared).
>
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101769#comment-15101769
]
Ferenc Denes commented on OOZIE-2429:
-
Thanks for the review.
1. In the if statement (as in the patch)
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15101975#comment-15101975
]
Hadoop QA commented on OOZIE-2429:
--
Testing JIRA OOZIE-2429
Cleaning local git workspace
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15097419#comment-15097419
]
Robert Kanter commented on OOZIE-2429:
--
A few things:
# I think we're wrapping too much in the {{if}}
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15087279#comment-15087279
]
Ferenc Denes commented on OOZIE-2429:
-
With the patch I have:
1. Fixed the event generation core, such
[
https://issues.apache.org/jira/browse/OOZIE-2429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15085752#comment-15085752
]
Ferenc Denes commented on OOZIE-2429:
-
Looks like that not only the the test is wrong (where the
26 matches
Mail list logo
