Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-12 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review19086 --- +1. Good tests for JMSTopicService! - Mona Chitnis On April 10, 20

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-10 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/ --- (Updated April 10, 2013, 7:09 a.m.) Review request for oozie. Changes ---

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-09 Thread Virag Kothari
> On April 8, 2013, 7:47 p.m., Mona Chitnis wrote: > > trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.java, > > line 255 > > > > > > this patch needs to be rebased with updated trunk. I see more if-

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-09 Thread Virag Kothari
> On April 8, 2013, 7:14 p.m., Mona Chitnis wrote: > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, > > line 26 > > > > > > Is this class corresponding to a DB table? I think the nor

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-08 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18792 --- trunk/client/src/main/java/org/apache/oozie/client/rest/JsonToBean.j

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-04-08 Thread Mona Chitnis
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18790 --- trunk/client/src/main/java/org/apache/oozie/client/rest/JsonTags.jav

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-03-22 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/ --- (Updated March 23, 2013, 1:32 a.m.) Review request for oozie. Changes ---

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-03-22 Thread Virag Kothari
> On March 22, 2013, 2:37 a.m., Mohammad Islam wrote: > > trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionInfoBean.java, > > line 38 > > > > > > Is the parameter tzId required? no usage. Not require

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-03-21 Thread Mohammad Islam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/#review18233 --- trunk/core/src/main/java/org/apache/oozie/client/rest/JMSConnectionI

Re: Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-03-21 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/ --- (Updated March 21, 2013, 7:40 p.m.) Review request for oozie. Changes ---

Review Request: OOZIE-1235: Client API for retrieving topic and jms connection related details

2013-03-01 Thread Virag Kothari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9709/ --- Review request for oozie. Description --- https://issues.apache.org/jira/br